Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: PJ4: allow building in Thumb-2 mode
Date: Mon, 24 Nov 2014 18:17:02 +0100	[thread overview]
Message-ID: <4653047.WBmUTsHC57@wuerfel> (raw)
In-Reply-To: <CAKv+Gu_YuHbO7+jusczcJTHF8fM4pF1z2h55BZK0mrHK702z_A@mail.gmail.com>

On Monday 24 November 2014 16:34:47 Ard Biesheuvel wrote:
> On 24 November 2014 at 16:29, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday 24 November 2014 12:56:40 Ard Biesheuvel wrote:
> >> Two files that get included when building the multi_v7_defconfig target
> >> fail to build when selecting THUMB2_KERNEL for this configuration.
> >>
> >> In both cases, we can just build the file as ARM code, as none of its
> >> symbols are exported to modules, so there are no interworking concerns.
> >> In the iwmmxt.S case, add ENDPROC() declarations so the symbols are
> >> annotated as functions, resulting in the linker to emit the appropriate
> >> mode switches.
> >>
> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >
> > Ah, very nice. I tried this before, but my version didn't actually
> > work, presumably because I didn't know about the ENDPROC() stuff.
> >
> > Have you tested this on a machine that has IWMMXT enabled?
> >
> 
> No, I don't have access to such a machine, unfortunately.

Adding a few mvebu folks to Cc, maybe one of them can test your patch.
It's also possible that Olof or Kevin have a PJ4 machine with iwmmxt 
in their boot farms.

	Arnd

  reply	other threads:[~2014-11-24 17:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 11:56 [PATCH] ARM: PJ4: allow building in Thumb-2 mode Ard Biesheuvel
2014-11-24 14:57 ` Nicolas Pitre
2014-11-24 15:29 ` Arnd Bergmann
2014-11-24 15:34   ` Ard Biesheuvel
2014-11-24 17:17     ` Arnd Bergmann [this message]
2014-11-24 17:36       ` Gregory CLEMENT
2014-11-24 17:48         ` Ard Biesheuvel
2014-11-24 19:01           ` Gregory CLEMENT
2014-11-24 19:49             ` Ard Biesheuvel
2014-11-25 16:14               ` Gregory CLEMENT
2014-11-26 10:21                 ` Ard Biesheuvel
2014-11-24 17:56       ` Olof Johansson
2014-11-24 18:28         ` Ard Biesheuvel
2014-11-24 18:48           ` Olof Johansson
2014-11-25 12:33             ` Ard Biesheuvel
2014-11-24 18:50         ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4653047.WBmUTsHC57@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox