[PATCH v4 12/21] serial: support for 16550A serial ports on LP-8x4x

One Thousand Gnomes
2014-04-16T20:00:51Z

On Wed, 16 Apr 2014 23:01:47 +0400
Sergei Ianovich <ynvich@gmail.com> wrote:

> One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> wrote:
> >> + baud = uart_get_baud_rate(port, termios, old,
> >> + port->uartclk / 16 / 0xffff,
> >> + port->uartclk / 16);
> >> + switch (baud) {
> >> + case 2400:
> >> + len |= 1;
> >> + break;
> >> + case 4800:
> >> + len |= 2;
> >> + break;
> >> + case 19200:
> >> + len |= 4;
> >> + break;
> >> + case 38400:
> >> + len |= 5;
> >> + break;
> >> + case 57600:
> >> + len |= 6;
> >> + break;
> >> + case 115200:
> >> + len |= 7;
> >> + break;
> >> + case 9600:
> >> + default:
> >> + len |= 3;
> >> + break;
> >> + };
> >
> >Some explanation of this would be useful - eg why is it set to 7 for
> >115200 baud and 3 for 115201 baud ?
>
> I am not related to the device vendor in any way, so please take my answers for what they are worth.
>
> It seems that there is not enough pins to properly connect the chips to the memory bus and just you the standard 8250 UART driver. Instead, clock divisor is set using this register.
>
> So, if you know you're asking for (115200) you get it. If you don't or guess (115201), you get the default 9600.

Thats not quite what the code actually implements though.

> This is a policy, it may not be the right way to write a driver, but it is cheap and it works.

If thats how the hardware works and only supports a few fixed rates then
fine, but for default: you need to actually update he baudrate in the
passed termios struct so that the userspace knows its request was not
matched.

Take a look how the standard 8250 termios does it.

Also looking at this and some of the other serial bits I see no
dependencies on the problematic DMA driver, so does that mean you've got
a set of pieces that can be submitted anyway while the DMA driver
discussion continues ?

Alan