From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] io-64-nonatomic: Add relaxed accessor variants
Date: Mon, 25 Apr 2016 17:41:21 +0200 [thread overview]
Message-ID: <4658440.AyDy7GFvoa@wuerfel> (raw)
In-Reply-To: <571E3781.3070609@arm.com>
On Monday 25 April 2016 16:28:01 Robin Murphy wrote:
> >>>
> >>> We _could_ - indeed I started doing that, but then decided that the
> >>> obfuscation of horrible macro-templated functions wasn't worth saving a
> >>> couple of hundred bytes in some code that isn't exactly difficult to
> >>> maintain and has needed touching once in 4 years.
> >>>
> >>> If you did want to go down the macro route, I may as well also generate both
> >>> lo-hi and hi-lo headers all from a single template, it'd be really clever...
> >>> <alarm bells>
> >>
> >> I certainly wasn't suggesting any more than the obvious macroisation,
> >> but I'll leave it up to Arnd, as I think this falls on his lap.
> >
> > I'd prefer the open-coded variant as well.
>
> By that, do you mean sticking with the smmu_writeq() implementation in
> the driver and dropping this patch, or merging this patch as-is without
> further macro-magic?
>
Sorry, that was really ambiguous on my end. I meant leaving patch 4/7
as it is in the version you posted.
However, leaving the open-coded writel_relaxed() in the driver or just
using the non-relaxed hi_lo_readq() would be totally fine too.
Arnd
next prev parent reply other threads:[~2016-04-25 15:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 17:12 [PATCH 0/7] arm-smmu: Implementation and context format differentiation Robin Murphy
2016-04-13 17:12 ` [PATCH 1/7] iommu/arm-smmu: Differentiate specific implementations Robin Murphy
2016-04-13 21:15 ` Chalamarla, Tirumalesh
2016-04-13 17:12 ` [PATCH 2/7] iommu/arm-smmu: Convert ThunderX workaround to new method Robin Murphy
2016-04-13 21:16 ` Chalamarla, Tirumalesh
2016-04-13 17:12 ` [PATCH 3/7] iommu/arm-smmu: Work around MMU-500 prefetch errata Robin Murphy
2016-04-21 16:15 ` Will Deacon
2016-04-21 16:16 ` Will Deacon
2016-04-13 17:13 ` [PATCH 4/7] io-64-nonatomic: Add relaxed accessor variants Robin Murphy
2016-04-21 16:18 ` Will Deacon
2016-04-22 17:08 ` Robin Murphy
2016-04-25 13:32 ` Will Deacon
2016-04-25 15:21 ` Arnd Bergmann
2016-04-25 15:28 ` Robin Murphy
2016-04-25 15:41 ` Arnd Bergmann [this message]
2016-04-25 16:11 ` Will Deacon
2016-04-25 16:11 ` Arnd Bergmann
2016-04-26 10:38 ` [PATCH v2] " Robin Murphy
2016-04-13 17:13 ` [PATCH 5/7] iommu/arm-smmu: Tidy up 64-bit/atomic I/O accesses Robin Murphy
2016-04-13 17:13 ` [PATCH 6/7] iommu/arm-smmu: Decouple context format from kernel config Robin Murphy
2016-04-21 16:30 ` Will Deacon
2016-04-22 17:38 ` Robin Murphy
2016-04-25 11:02 ` Will Deacon
2016-04-25 13:14 ` Robin Murphy
2016-04-25 13:41 ` Will Deacon
2016-04-25 16:21 ` Robin Murphy
2016-04-28 16:12 ` [PATCH v2] " Robin Murphy
2016-04-13 17:13 ` [PATCH 7/7] iommu/arm-smmu: Support SMMUv1 64KB supplement Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4658440.AyDy7GFvoa@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox