public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/9] Doc/DT: Add DT binding documentation for MIPI DSI CM Panel
Date: Mon, 17 Mar 2014 15:22:10 +0100	[thread overview]
Message-ID: <4670830.fkS1noPxcd@avalon> (raw)
In-Reply-To: <1393590016-9361-7-git-send-email-tomi.valkeinen@ti.com>

Hi Tomi,

Thank you for the patch.

On Friday 28 February 2014 14:20:13 Tomi Valkeinen wrote:
> Add DT binding documentation for MIPI DSI Command Mode Panel.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Reviewed-by: Archit Taneja <archit@ti.com>
> ---
>  .../devicetree/bindings/video/panel-dsi-cm.txt     | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/video/panel-dsi-cm.txt
> 
> diff --git a/Documentation/devicetree/bindings/video/panel-dsi-cm.txt
> b/Documentation/devicetree/bindings/video/panel-dsi-cm.txt new file mode
> 100644
> index 000000000000..73f422556d4f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/panel-dsi-cm.txt
> @@ -0,0 +1,26 @@
> +Generic MIPI DSI Command Mode Panel
> +===================================
> +
> +Required properties:
> +- compatible: "panel-dsi-cm"
> +
> +Optional properties:
> +- label: a symbolic name for the panel
> +- gpios: panel reset gpio and TE gpio
> +
> +Required nodes:
> +- Video port for DSI input
> +
> +Example
> +-------
> +
> +lcd0: display {
> +	compatible = "tpo,taal", "panel-dsi-cm";
> +	label = "lcd0";
> +
> +	gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;	/* 102, reset */

If the panel uses a TE GPIO but no reset GPIO, do you plan to express this 
with a "hole" for the reset GPIO ? e.g. something like

	gpios = <0>, <&gpio4 6 GPIO_ACTIVE_HIGH>;

Wouldn't it be better to split the gpios property into "reset-gpios" and "te-
gpios" ?

> +
> +	lcd0_in: endpoint {
> +		remote-endpoint = <&dsi1_out_ep>;
> +	};
> +};

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2014-03-17 14:22 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 12:20 [PATCH 0/9] Doc/DT: DT bindings for various display components Tomi Valkeinen
2014-02-28 12:20 ` [PATCH 1/9] Doc/DT: Add OMAP DSS DT Bindings Tomi Valkeinen
2014-02-28 12:20 ` [PATCH 2/9] Doc/DT: Add DT binding documentation for Analog TV Connector Tomi Valkeinen
2014-02-28 12:20 ` [PATCH 3/9] Doc/DT: Add DT binding documentation for DVI Connector Tomi Valkeinen
2014-02-28 13:43   ` Philipp Zabel
2014-03-03  6:25     ` Tomi Valkeinen
2014-02-28 15:59   ` Russell King - ARM Linux
2014-02-28 16:12     ` Tomi Valkeinen
2014-02-28 16:23       ` Russell King - ARM Linux
2014-02-28 16:28         ` Warner Losh
2014-03-03  6:42         ` Tomi Valkeinen
2014-03-04 12:54         ` Daniel Vetter
2014-03-05  8:41         ` Tomi Valkeinen
2014-03-06  8:39           ` Geert Uytterhoeven
2014-03-06  8:52             ` Tomi Valkeinen
2014-03-07 14:17               ` Philipp Zabel
2014-03-10 10:32                 ` Tomi Valkeinen
2014-02-28 16:25       ` Sebastian Reichel
2014-02-28 16:25     ` Philipp Zabel
2014-03-10 21:45       ` Rob Herring
2014-03-11  6:39         ` Tomi Valkeinen
2014-03-11  8:00           ` Geert Uytterhoeven
2014-03-11  8:04             ` Tomi Valkeinen
2014-03-11 11:19               ` Philipp Zabel
2014-03-11  6:43       ` Tomi Valkeinen
2014-02-28 12:20 ` [PATCH 4/9] Doc/DT: Add DT binding documentation for HDMI Connector Tomi Valkeinen
2014-02-28 16:06   ` Russell King - ARM Linux
2014-02-28 16:15     ` Tomi Valkeinen
2014-02-28 16:34       ` Russell King - ARM Linux
2014-03-01 18:58         ` Geert Uytterhoeven
2014-03-03  7:23           ` Tomi Valkeinen
2014-03-05  8:42           ` Tomi Valkeinen
2014-03-04 12:59     ` Daniel Vetter
2014-02-28 12:20 ` [PATCH 5/9] Doc/DT: Add DT binding documentation for MIPI DPI Panel Tomi Valkeinen
2014-02-28 13:40   ` Philipp Zabel
2014-03-03  6:05     ` Tomi Valkeinen
2014-03-17 14:19   ` Laurent Pinchart
2014-03-18  6:41     ` Tomi Valkeinen
2014-03-18  7:06       ` Tomi Valkeinen
2014-02-28 12:20 ` [PATCH 6/9] Doc/DT: Add DT binding documentation for MIPI DSI CM Panel Tomi Valkeinen
2014-03-17 14:22   ` Laurent Pinchart [this message]
2014-03-18  6:33     ` Tomi Valkeinen
2014-03-18 12:43       ` Laurent Pinchart
2014-02-28 12:20 ` [PATCH 7/9] Doc/DT: Add DT binding documentation for Sony acx565akm panel Tomi Valkeinen
2014-02-28 13:38   ` Philipp Zabel
2014-02-28 13:47     ` Tomi Valkeinen
2014-02-28 12:20 ` [PATCH 8/9] Doc/DT: Add DT binding documentation for TFP410 encoder Tomi Valkeinen
2014-02-28 13:37   ` Philipp Zabel
2014-02-28 12:20 ` [PATCH 9/9] Doc/DT: Add DT binding documentation for tpd12s015 encoder Tomi Valkeinen
2014-02-28 16:13   ` Russell King - ARM Linux
2014-02-28 16:30     ` Tomi Valkeinen
2014-02-28 12:37 ` [PATCH 0/9] Doc/DT: DT bindings for various display components Tomasz Figa
2014-02-28 12:57 ` Sebastian Hesselbarth
2014-02-28 13:14   ` Tomi Valkeinen
2014-02-28 13:51     ` Sebastian Hesselbarth
2014-02-28 15:39       ` Tomi Valkeinen
2014-02-28 16:48       ` Russell King - ARM Linux
2014-02-28 13:47   ` Philipp Zabel
2014-02-28 13:56     ` Sebastian Hesselbarth
2014-02-28 16:27 ` Russell King - ARM Linux
2014-02-28 16:48   ` Tomi Valkeinen
2014-02-28 16:56     ` Russell King - ARM Linux
2014-03-03  8:04       ` Tomi Valkeinen
2014-03-07 12:56         ` Tomi Valkeinen
2014-03-10 16:05         ` Rob Herring
2014-03-10 16:40           ` Tomi Valkeinen
2014-03-10 20:32             ` Rob Herring
2014-03-12  8:15 ` Tomi Valkeinen
2014-03-17 13:55   ` Tomi Valkeinen
2014-03-21 15:37     ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4670830.fkS1noPxcd@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox