[PATCH 5/5] ARM: qcom: Add Qualcomm APQ8084 SoC

Stanimir Varbanov
2015-01-06T15:24:22Z

Hi Arnd,

Thanks for the comments!

On 12/12/2014 07:33 PM, Arnd Bergmann wrote:
> On Friday 12 December 2014 19:14:01 Stanimir Varbanov wrote:
>> +config ARCH_APQ8084
>> + bool "Enable support for APQ8084"
>> + select HAVE_ARM_ARCH_TIMER
>> + select PCI
>> + select PCI_DOMAINS
>> + select PCI_MSI
>> +
>
> I would prefer not to see 'select PCI' here. Also the driver is written
> to work without PCI_MSI, so I'd be much happier with just
>
> config ARCH_APQ8084
> bool "Enable support for APQ8084"
> select HAVE_ARM_ARCH_TIMER
> select PCI_DOMAINS if PCI

What about this

config ARCH_APQ8084
bool "Enable support for APQ8084"
select HAVE_ARM_ARCH_TIMER
select MIGHT_HAVE_PCI
select PCI_DOMAINS if PCI

--
regards,
Stan