From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, Laurent.pinchart@ideasonboard.com,
jonas@kwiboo.se, jernej.skrabec@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
marex@denx.de, stefan@agner.ch, dmitry.baryshkov@linaro.org,
Liu Ying <victor.liu@nxp.com>
Subject: Re: [PATCH 4/5] drm/bridge: imx8mp-hdmi-tx: Set output_port to 1
Date: Fri, 18 Oct 2024 09:32:22 +0200 [thread overview]
Message-ID: <46745071.fMDQidcC6G@steina-w> (raw)
In-Reply-To: <20241018064813.2750016-5-victor.liu@nxp.com>
Hi,
Am Freitag, 18. Oktober 2024, 08:48:12 CEST schrieb Liu Ying:
> Set DW HDMI platform data's output_port to 1 in imx8mp_dw_hdmi_probe()
> so that dw_hdmi_probe() called by imx8mp_dw_hdmi_probe() can tell the
> DW HDMI bridge core driver about the output port we are using, hence
> the next bridge can be found in dw_hdmi_parse_dt() according to the port
> index, and furthermore the next bridge can be attached to bridge chain in
> dw_hdmi_bridge_attach() when the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is
> set. The output_port value aligns to the value used by devicetree.
> This is a preparation for making the i.MX8MP LCDIF driver use
> drm_bridge_connector which requires the DRM_BRIDGE_ATTACH_NO_CONNECTOR
> flag.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c
> index 8fcc6d18f4ab..54a53f96929a 100644
> --- a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c
> +++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c
> @@ -96,6 +96,7 @@ static int imx8mp_dw_hdmi_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(hdmi->pixclk),
> "Unable to get pixel clock\n");
>
> + plat_data->output_port = 1;
> plat_data->mode_valid = imx8mp_hdmi_mode_valid;
> plat_data->phy_ops = &imx8mp_hdmi_phy_ops;
> plat_data->phy_name = "SAMSUNG HDMI TX PHY";
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2024-10-18 7:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 6:48 [PATCH 0/5] drm: lcdif: Use drm_bridge_connector Liu Ying
2024-10-18 6:48 ` [PATCH 1/5] arm64: dts: imx8mp-kontron-bl-osm-s: Add HDMI connector Liu Ying
2024-10-18 7:41 ` Alexander Stein
2024-10-18 6:48 ` [PATCH 2/5] arm64: dts: imx8mp-kontron-smarc-eval-carrier: " Liu Ying
2024-10-18 7:41 ` Alexander Stein
2024-10-18 6:48 ` [PATCH 3/5] arm64: dts: imx8mp-msc-sm2s-ep1: " Liu Ying
2024-10-18 7:41 ` Alexander Stein
2024-10-18 8:48 ` Marek Vasut
2024-10-18 9:00 ` Liu Ying
2024-10-18 9:35 ` Marek Vasut
2024-10-21 7:15 ` Frieder Schrempf
2024-10-18 6:48 ` [PATCH 4/5] drm/bridge: imx8mp-hdmi-tx: Set output_port to 1 Liu Ying
2024-10-18 7:32 ` Alexander Stein [this message]
2024-10-18 12:31 ` Dmitry Baryshkov
2024-10-18 13:12 ` Alexander Stein
2024-10-21 1:50 ` Liu Ying
2024-10-18 6:48 ` [PATCH 5/5] drm: lcdif: Use drm_bridge_connector Liu Ying
2024-10-18 7:34 ` Biju Das
2024-10-18 7:37 ` Liu Ying
2024-10-18 7:43 ` Biju Das
2024-10-18 7:35 ` Alexander Stein
2024-10-18 12:15 ` Dmitry Baryshkov
2024-10-21 1:51 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46745071.fMDQidcC6G@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=stefan@agner.ch \
--cc=tzimmermann@suse.de \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).