From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
arinc.unal@arinc9.com
Cc: mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
"Arınç ÜNAL" <arinc.unal@arinc9.com>
Subject: Re: [PATCH] arm64: dts: rockchip: set PHY address of MT7531 switch to 0x1f
Date: Thu, 14 Mar 2024 13:31:13 +0100 [thread overview]
Message-ID: <4682635.taCxCBeP46@diego> (raw)
In-Reply-To: <20240314-for-rockchip-mt7531-phy-address-v1-1-743b5873358f@arinc9.com>
Am Donnerstag, 14. März 2024, 13:24:35 CET schrieb Arınç ÜNAL via B4 Relay:
> From: Arınç ÜNAL <arinc.unal@arinc9.com>
>
> The MT7531 switch listens on PHY address 0x1f on an MDIO bus. I've got two
> findings that support this. There's no bootstrapping option to change the
> PHY address of the switch. The Linux driver hardcodes 0x1f as the PHY
> address of the switch. So the reg property on the device tree is currently
> ignored by the Linux driver.
>
> Therefore, describe the correct PHY address on Banana Pi BPI-R2 Pro that
> has this switch.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Fixes: c1804463e5c6 ("arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board")
> ---
> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index 7b5f3904ef61..03d6d920446a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -525,9 +525,9 @@ &mdio0 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - switch@0 {
> + switch@1f {
> compatible = "mediatek,mt7531";
> - reg = <0>;
> + reg = <0x1f>;
>
> ports {
> #address-cells = <1>;
>
> ---
> base-commit: 0276d797531ea2d1865a04fbe54c659608f5788f
> change-id: 20240314-for-rockchip-mt7531-phy-address-ba6c2fff485f
>
> Best regards,
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-14 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 12:24 [PATCH] arm64: dts: rockchip: set PHY address of MT7531 switch to 0x1f Arınç ÜNAL via B4 Relay
2024-03-14 12:31 ` Heiko Stübner [this message]
[not found] ` <3eb63e39-c7f2-4411-bb84-e4c152be1f0c@arinc9.com>
2024-03-14 13:49 ` Heiko Stübner
2024-03-24 22:38 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4682635.taCxCBeP46@diego \
--to=heiko@sntech.de \
--cc=arinc.unal@arinc9.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=erkin.bozoglu@xeront.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mithat.guner@xeront.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).