From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32278CCFA05 for ; Thu, 6 Nov 2025 18:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IbaUwN97vGeANThuFDgulgsFTpORSyAqqWAycmMvn0Q=; b=ZVM+g0pkxNu3u3jjz3VUAWO+uY IW+QpEjXOX4b4Jpkv943KA10kj0d2uczYp/Qj73J/c8sTyhmaC/LCrmxivrIK0Ql2ktNgN1+1xz9q i8i0rJa8Hy2fdbEjGr635lQjgAkjL2U8BgFXBIInIFR7g3EiHj9K1lMvh1ooPSFgTQkFNMMTYdCT+ J4OS1/Im8fxI2tjx2Gk9LObPMvLAyyXLzbyDwdVfclSVuWJmkVIZdnC1p5IP1rM645OKwdqN7+ejx 3rKHjPnOKjSoAoHTsoFW3gUGINmRtNoha64WdCuhP/z4RcqjWd7heR71smbSZQer0de9w/N41MlCE YiE1SSmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vH4XE-0000000G5D3-2mNC; Thu, 06 Nov 2025 18:16:36 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vH4XC-0000000G5Cf-011K for linux-arm-kernel@lists.infradead.org; Thu, 06 Nov 2025 18:16:35 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 055C04447C; Thu, 6 Nov 2025 18:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yoseli.org; s=gm1; t=1762452989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IbaUwN97vGeANThuFDgulgsFTpORSyAqqWAycmMvn0Q=; b=UAurMIDhvSirMkEYhH8XOdIrF0QaJtlbdslpce4O9SGmzZ/RKVM2eyy3koQ1nl05Ga1WZP MIIwfeUBRdE4R7HtdNQgD57Z4zaSOcFfy76RbFos318PSt9gCCOHdXeT1e6e5LB2nBJaY5 kJXkGISsNkt9PJKtrBDT/Tx0VhibOWRh4auHXKLPA90bT2s7UzHj0wpVY0I8P+vTQ5s7hj NIyGIKu2Hj5jB9mUJ0LU5oE8qRFon9ywu8lkYFg9UgTtm7vwwFR0z5q4c3E8s81VgjVZ68 dyfbk+1hPIPAUNuMSq9bPGb6asMguUHhfTTRJXxiGnA/qEm0HkKKA3TKKcUu7A== From: Jean-Michel Hautbois To: Frank Li Cc: Greg Ungerer , Geert Uytterhoeven , Olivia Mackall , Herbert Xu , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] m68k: coldfire: Add RNG support for MCF54418 Date: Thu, 06 Nov 2025 19:16:17 +0100 Message-ID: <4689159.LvFx2qVVIh@jeanmichel-ms7b89> In-Reply-To: References: <20251106-m5441x-add-rng-support-v1-1-ee8230910d17@yoseli.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddukeejgeekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpeflvggrnhdqofhitghhvghlucfjrghuthgsohhishcuoehjvggrnhhmihgthhgvlhdrhhgruhhtsghoihhsseihohhsvghlihdrohhrgheqnecuggftrfgrthhtvghrnhepffevhfduvdeludeugfdtleduuedvhfeuvdevgfeiieefieevteektdettdeifeetnecukfhppedvrgdtudemvgdtrgemudeileemjedugedtmedvrgegtdemfhefrggrmeejudejvgemudefsgdvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdgrtddumegvtdgrmeduieelmeejudegtdemvdgrgedtmehffegrrgemjedujegvmedufegsvddphhgvlhhopehjvggrnhhmihgthhgvlhdqmhhsjegskeelrdhlohgtrghlnhgvthdpmhgrihhlfhhrohhmpehjvggrnhhmihgthhgvlhdrhhgruhhtsghoihhsseihohhsvghlihdrohhrghdpnhgspghrtghpthhtohepudegpdhrtghpthhtohephfhrrghnkhdrlhhisehngihprdgtohhmpdhrtghpthhtohepghgvrhhgsehlihhnuhigqdhmieekkhdrohhrghdprhgtphhtthhopehgvggvrhhtsehlihhnu higqdhmieekkhdrohhrghdprhgtphhtthhopeholhhivhhirgesshgvlhgvnhhitgdrtghomhdprhgtphhtthhopehhvghrsggvrhhtsehgohhnughorhdrrghprghnrgdrohhrghdrrghupdhrtghpthhtohepshhhrgifnhhguhhosehkvghrnhgvlhdrohhrghdprhgtphhtthhopehsrdhhrghuvghrsehpvghnghhuthhrohhnihigrdguvgdprhgtphhtthhopehkvghrnhgvlhesphgvnhhguhhtrhhonhhigidruggv X-GND-Sasl: jeanmichel.hautbois@yoseli.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251106_101634_715524_04940FAE X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frank, Le jeudi 6 novembre 2025, 17:05:15 heure normale d=E2=80=99Europe centrale = =46rank Li a=20 =C3=A9crit : > On Thu, Nov 06, 2025 at 08:10:08AM +0100, Jean-Michel Hautbois wrote: > > Add platform device support for the MCF54418 RNGB hardware with clock > > enabled at platform initialization. > >=20 > > The imx-rngc driver now uses devm_clk_get_optional() to support both > > Coldfire (always-on clock) and i.MX platforms (managed clock). > >=20 > > Signed-off-by: Jean-Michel Hautbois > > --- > >=20 > > arch/m68k/coldfire/device.c | 28 ++++++++++++++++++++++++++++ > > arch/m68k/coldfire/m5441x.c | 2 +- > > arch/m68k/include/asm/m5441xsim.h | 9 +++++++++ > > drivers/char/hw_random/Kconfig | 3 ++- > > drivers/char/hw_random/imx-rngc.c | 9 ++++++++- > > 5 files changed, 48 insertions(+), 3 deletions(-) > >=20 > > diff --git a/arch/m68k/coldfire/device.c b/arch/m68k/coldfire/device.c > > index > > b6958ec2a220cf91a78a14fc7fa18749451412f7..9d8f844e319a98f0afb79cceb544c= 2d > > 3029482a4 100644 --- a/arch/m68k/coldfire/device.c > > +++ b/arch/m68k/coldfire/device.c > > @@ -622,6 +622,31 @@ static struct platform_device mcf_flexcan0 =3D { > >=20 > > }; > > #endif /* MCFFLEXCAN_SIZE */ > >=20 > > +#ifdef MCF_RNG_BASE > > +/* > > + * Random Number Generator (RNG) - only on MCF54418 > > + */ > > +static struct resource mcf_rng_resource[] =3D { >=20 > const? Why not, but I wanted to be consistent with all the other structures in thi= s=20 file. JM > Frank >=20 > > + { > > + .start =3D MCF_RNG_BASE, > > + .end =3D MCF_RNG_BASE + MCF_RNG_SIZE - 1, > > + .flags =3D IORESOURCE_MEM, > > + }, > > + { > > + .start =3D MCF_IRQ_RNG, > > + .end =3D MCF_IRQ_RNG, > > + .flags =3D IORESOURCE_IRQ, > > + }, > > +}; >=20 > ...