From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39C1BC433EF for ; Mon, 28 Mar 2022 17:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=48/+J4QlZOjnnq7f1CgfU7HFCBy4HQnK/QeyA9tC5GQ=; b=2mZBJ7FN7xF/IG Vb7lKKTm2+rWYGg6yAG4OOLhaJfbR1Uaktbb8ueIcgEIu79T+92pvdP1qwexIElu6l03/X0iL+6bw ZUXHiCkIxvESjHHe9Z3jlc33voFSK2iYnMrZYcYA/Gn0YulAN0bQOhsBGAgxBa5VvCvV41bwEmljF +GKpQamnAjlf++BLZgVb4v2ELAiPBAWqj/f79f1hUJJnIfGDr4YjH5zCZPCM5Ij0sAassxGVPaWEm Ghuq0EGmX+vxZQXGnOub4s58pkJICXClze/KCVmNhWHdTSsmxHfpm89t25Q8lSIsqISeXPEQwIO6K lstAC3QkTmqEX2/vhMdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYsrn-009ayR-SQ; Mon, 28 Mar 2022 17:09:20 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYsrk-009axh-Be for linux-arm-kernel@lists.infradead.org; Mon, 28 Mar 2022 17:09:17 +0000 Received: by mail-ej1-x633.google.com with SMTP id bi12so30099529ejb.3 for ; Mon, 28 Mar 2022 10:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oz/GhbrsSoiiuJbFSvXUMfpNUWNZ2X3Kmt6C0b9MtEY=; b=XLFg6dCmzHI6UVEuH8BLYtKKM4uvH1ZozdUxJhyd9zDVCSiCtUzw6R4eiOcIvKdtp+ OKddStrGMKY8ErWM/NqQq/kTWdaunQJTqePkGKtU1344Wj+/F/i30ItvbA4IFnBLSQwF V54eQVV+UGCyhBuPy2yjZg2dmrMr+eoLRbjvlMQ1nkV1S+tR/6RAYXCgx+dCLXCwTgOu w6GK9j/qC32+SQY+8OroKJsE2UtR34akAYW9D+sOA0gZhXFh1I3RJnD6fFQuFmo/0BU/ PRSsL+VvNUjbki90jg38CzUeCr2IKa7ibdhMwchZvJ3LJYdvrreSSh3J/0os/8ijeegd s8YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oz/GhbrsSoiiuJbFSvXUMfpNUWNZ2X3Kmt6C0b9MtEY=; b=clMhiMgWTL/iP3S6MRCvkDiGG2C32hznRcRsWkdcA3wYllAn75dId9cB5azyloIDDz EqA6DCqYTuQ60p2UxnYEG4W5bzhW4I52LrSsGTxcHL7Miv452T7buUQcCh1e27nWfvpB UFMo8SorDfQXu5hILAFmax9Z9Cd4twen2TwVzh7ddCYuS3vyVQwDlHgb7plza61BSbG2 H0tcczDKGOngyBZzfj+wpQfMh7Uebn//LGyQoX0dNIAB+h5Hubhx1Nc7mklWfwADeut5 2A+uSWnNlvI/ADydYjlyH77Hela6AebL0KHjmb6Feliuv3XIep0CU2cYabKdbBgOo9BZ NY2g== X-Gm-Message-State: AOAM533xYwUi3O7N2Mz4hHXD4eAPq10ybnW5AWeOHaLByqmG2ESbvL5E TLmXHoXLKroVDlPlSvULfX8= X-Google-Smtp-Source: ABdhPJxn3BJyJKNC9/61CZcKeOhAnR0kP6RUMvDsLZPNcLzptiHSJT5FmZKkFiS6yu0S2vwJNZhpcA== X-Received: by 2002:a17:907:7ba3:b0:6df:b07c:ee35 with SMTP id ne35-20020a1709077ba300b006dfb07cee35mr28691222ejc.588.1648487353124; Mon, 28 Mar 2022 10:09:13 -0700 (PDT) Received: from jernej-laptop.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id o17-20020a056402439100b0041938757232sm7321011edc.17.2022.03.28.10.09.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 10:09:12 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-media@vger.kernel.org, Sebastian Fricke Cc: acourbot@chromium.org, tfiga@chromium.org, hverkuil-cisco@xs4all.nl, Sebastian Fricke , Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , "open list:STAGING SUBSYSTEM" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list Subject: Re: [RFC PATCH v3 2/2] staging: media: cedrus: Rename H265 to HEVC Date: Mon, 28 Mar 2022 19:09:11 +0200 Message-ID: <4697363.GXAFRqVoOG@jernej-laptop> In-Reply-To: <20220327084308.9053-3-sebastian.fricke@collabora.com> References: <20220327084308.9053-1-sebastian.fricke@collabora.com> <20220327084308.9053-3-sebastian.fricke@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220328_100916_460785_31707DAD X-CRM114-Status: GOOD ( 15.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sebastian! Dne nedelja, 27. marec 2022 ob 10:43:10 CEST je Sebastian Fricke napisal(a): > Rename all instances where the identifier H265 is used with HEVC. > The codec has multiple identifiers H.265 (ITU-T), MPEG-H Part 2 (ISO), > but the actual name of the codec is HEVC (High Efficiency Video Coding). > Also nearly all other related drivers use the term HEVC instead of H265. > > Signed-off-by: Sebastian Fricke This patch is not constructive. I admit, it's unfortunate it's not using same name as other drivers, but anyone dealing with HEVC will know H265 is synonym for it. This patch doesn't improve anything and actually makes any fix harder to backport, if something cames up. According to diffstat, this rewrites more than 50% of cedrus_h265.c, including renaming the file. Additionally, it's easy to miss something to rename and we could play this game in the future too, for no real benefit. So NAK. Best regard, Jernej P.S. Please wait at least few days before resending patches, even if you find something. After all, RFC patches are meant to get some response, it's not expected they will be perfect. > --- > drivers/staging/media/sunxi/cedrus/Makefile | 2 +- > drivers/staging/media/sunxi/cedrus/cedrus.c | 30 +- > drivers/staging/media/sunxi/cedrus/cedrus.h | 14 +- > .../staging/media/sunxi/cedrus/cedrus_dec.c | 10 +- > .../cedrus/{cedrus_h265.c => cedrus_hevc.c} | 438 +++++++++--------- > .../staging/media/sunxi/cedrus/cedrus_hw.c | 4 +- > .../staging/media/sunxi/cedrus/cedrus_regs.h | 394 ++++++++-------- > .../staging/media/sunxi/cedrus/cedrus_video.c | 4 +- > 8 files changed, 448 insertions(+), 448 deletions(-) > rename drivers/staging/media/sunxi/cedrus/{cedrus_h265.c => cedrus_hevc.c} > (53%) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel