From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABA1EC77B78 for ; Wed, 19 Apr 2023 03:40:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q0Df/DG/dNrYcnlvYfrgFB/wRpZBEQwPQo02QWlFikk=; b=xMdPLg3MUcrjBF 1ee3/NhmsuwR1cePN/yeGfXXUur/JC7pFFuUOT5tyiiiBAkb8Y/playlTEI1pt4T6tpXBg2sAgI87 6V1NUgiNU8uJ4rt7Af8y1W6QIj1nixl9lBsyo/ioXU3JpScz4EsRyczJtWfMYFIonjAKPs0BVhf54 EXvZWyfSYM11988ptyjv57lwa4ZEyZ0bS6kPTxKeVlj/8Fk9HDTqhYaZfQewbRkwGeGFni8e5OqqX 3DH9L7SFysOt5IIWidd4+aKJrexm7NpZdE/iGdN+oT5/VEPjqtZFhXMIhlgps2tnbhPcLEkB3PLG5 +9pbuIMerVU01kIPiu+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poyet-003tHd-1k; Wed, 19 Apr 2023 03:39:03 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poyep-003tGL-2n; Wed, 19 Apr 2023 03:39:01 +0000 X-UUID: b5582870de6311edb7d8d11f642b8e78-20230418 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=Sw8keh5rYatayW9tkEyVFjqQPne9nlAKDwSrIEZD0Nk=; b=gKyWxhPxYQIea/F5JNSSJtVQoPVKTH1dbAu79LjQTYc8t3+BO2S0Pr2WHBnaYT6NG1XqSZF0WEuI7aTC+m+AgcbYC6LMsD95o2FV3pb4DKBWbfxQ/oYiG48tWaJKyudFWIn1GpCOyq/+9o1SPM+31Fsmz/Xe7scSyPYvFPRU5hA=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.22,REQID:6018e653-5878-49a4-80b3-bcfe0a235e87,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:120426c,CLOUDID:c40ecda1-8fcb-430b-954a-ba3f00fa94a5,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-UUID: b5582870de6311edb7d8d11f642b8e78-20230418 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1799945915; Tue, 18 Apr 2023 20:38:54 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Wed, 19 Apr 2023 11:38:17 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.239) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Wed, 19 Apr 2023 11:38:17 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ktp7g792VA7nofqs9ytj2np7jG1Q9QYcrM24vOs4SwYnWbVq/AGycW3kxLsK3GjF5U0N8DkfqLOBf8bT/Oar17HKJTprQYpHpLoVUSjRmJr9H3dN2x0Sv6jRPEe4Q1LO/AsWxu/r0V1AF1y9bke36PLUVbdZyaxukRwIg3BlVMp0f6C+6og39zW66FEG4gaiC9UUy0vgRAKstI1+ISdcWfbDaTft2seAWZZJdk7LMQQl3pAs6+/1n1TumJMgJmMewEZzfDcAcypgm9uDSlEnneKAdzUeTs1gun2oew98rCQzPdWCc3m0DbibpAf/AFEkiyWWymc5WBFW+HFcBobq1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sw8keh5rYatayW9tkEyVFjqQPne9nlAKDwSrIEZD0Nk=; b=ENGhp1/+VlHiijoJjnU2crBsCMR9HxKKXXSLEs365CUV+q8qBlf8HR8cGGGZByBOtyy7e8FD9LVGQWqRJVONhQuYLoYODCJx5Za2KxDwXt/DrNeEOan8d/CdqfB8VeyUVn/i5raFRP/Ytlmeua72kEtBSSC1YhwgVec6a+a7y/s0cYnSAjsfOzTeuxrVWc6IBwPuTkosJxBDQfOvoPacL7VonUHI7zRgpjyx2VAlULWTxsv26vrcwIlh20ABnGpwxSYgrnYbTYBW8QZpLtSnz+qjQDshas+TBFrqAggX2/2Zzwk5/GYOaBQndDUayRMjc8+lhiC4ZmO3ln2DSVDJSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sw8keh5rYatayW9tkEyVFjqQPne9nlAKDwSrIEZD0Nk=; b=C/v5xEDIiUBRfFBq3ZpIwp50gYH+2LH4S/ZyXVJO0dC6l/0RMCR3ps+nHEbdyRr0o2ks0qY/N7A7vcLs1SGKLU/kDtaCMpfuRf4yHWbKloSRS2WALJsgGNOybweaDFizW0NJF0FRoq2jiLGDyKmeaVl2HUQ2TuPspfgNTEqnCdo= Received: from SL2PR03MB4204.apcprd03.prod.outlook.com (2603:1096:100:53::15) by PUZPR03MB7212.apcprd03.prod.outlook.com (2603:1096:301:113::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.20; Wed, 19 Apr 2023 03:38:14 +0000 Received: from SL2PR03MB4204.apcprd03.prod.outlook.com ([fe80::d9b0:e117:9f08:3475]) by SL2PR03MB4204.apcprd03.prod.outlook.com ([fe80::d9b0:e117:9f08:3475%5]) with mapi id 15.20.6298.045; Wed, 19 Apr 2023 03:38:14 +0000 From: =?utf-8?B?VGluZ0hhbiBTaGVuICjmsojlu7fnv7Ap?= To: "mathieu.poirier@linaro.org" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-remoteproc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "andersson@kernel.org" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v9 05/11] remoteproc: mediatek: Extract remoteproc initialization flow Thread-Topic: [PATCH v9 05/11] remoteproc: mediatek: Extract remoteproc initialization flow Thread-Index: AQHZYRz7NOKolAghB0WgqNOx57Prf68VLquAgBzv14A= Date: Wed, 19 Apr 2023 03:38:14 +0000 Message-ID: <46baff1f95fa13976d7a07b5e50ff2175e464baa.camel@mediatek.com> References: <20230328022733.29910-1-tinghan.shen@mediatek.com> <20230328022733.29910-6-tinghan.shen@mediatek.com> <20230331174431.GA3504605@p14s> In-Reply-To: <20230331174431.GA3504605@p14s> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SL2PR03MB4204:EE_|PUZPR03MB7212:EE_ x-ms-office365-filtering-correlation-id: 7de2f678-0b84-4bb7-4392-08db408781d4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4loOOYM1hU0mMFDhLz3QqEgiZRV4bYqB7j5Ue4YFWABel59u9vbVwuR6wtZMB9pL0fBb6tgcqt9VDrJrYLoX/YTDVsykbNZMh0XOClEzPwXbCSu7M1XVp23eSLByzdYQDbPlyM93KyzTezLIoGUmnt5VhnzOBodN2+I7ENyhGe6BZxaCbQFjrDnb6GMc4QuR+3iTXJIUgCGY4P0o6+ONVAfl70IIptsDGz35Qftrc5bKkasc7jnraWEnEUjRdMkD5qo0uWp9jUCoFF4XwLJ8H0YSmyNm1kOqtsd8suolsU5AD6vKGXtNUBeRrXUF+cVQY3OUhdH1O0H9tJoQArmrGnbj+kXkhQ62LAItRRT+DdlfLvg8RvFX9C7S4dCrB1MSe9864mHB8cBOcxsD+I5ABlk9oIr3c0zSD7uKHecmV2Qr0XpYIEdzZicvsieh7D/BZPmwHxZKC78sorP6W9Nou242VULrzgCPMz7E/LKBGfW5Oairg8LxUqa5KkgOkUhPVN4lJNWDv0VLy5/kQVRCi3Z41cuOD+Gu2gkYl1xpHUQwkLmtpmuT8pPqSWG5CuYFH7JKGmTCEBBh6VZRnxLXZvnDGJ73W+zRZKI1s94MNp16PC2jx6IUGtnyQWwFu3awIfcu7b/qPHy/MuTjAK6Hm1++1kKHZNXcR2QZknu0rDs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR03MB4204.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(366004)(39860400002)(346002)(136003)(451199021)(2906002)(2616005)(478600001)(71200400001)(86362001)(26005)(6512007)(6506007)(6486002)(36756003)(186003)(38070700005)(85182001)(41300700001)(122000001)(54906003)(38100700002)(8676002)(8936002)(4326008)(66446008)(66556008)(66476007)(91956017)(83380400001)(66946007)(64756008)(76116006)(316002)(6916009)(7416002)(5660300002)(414714003)(473944003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bEc1REduSzNOZXo1OE51VU9iSE1MREpOdXRJSzBjNWNBSWk3NGxKMnNGWjNF?= =?utf-8?B?RWJuQTkxdlN5N00wYjRhaDhaM1dmcUpFM3FLZjdzeEFxUDdaVmVvczN3TlRZ?= =?utf-8?B?RzBSQ05VVHdPcE4xeU12cUdGeHQ0Y1lHTjRKMU5uc3JuWFA2WE9SQXBWaWlh?= =?utf-8?B?dk0xaG1EMkUwUFBqZXh4ZWRwM1cvWGxoMi9hQ09CelkwZ3UzeHg4VzNwcnJC?= =?utf-8?B?TlJVZlpmODN4YlNKVjV0bitieWY0MkZoK24rL3h3QUNRbUVvemxONHhQQVdp?= =?utf-8?B?U3JxNHJUYnl1blBBdVFlUGloTnpaUytMS2haSEJIUjhMdmhGSm56bVBDZ2pO?= =?utf-8?B?WVNGVE1XWU1OcE9KYm91bC9KR0F5Zm1welJtK1RVN0ovcXQxblNuSjZkNXJ5?= =?utf-8?B?T1kxd2dLZmNGRHdYa3NWTGVnV1hFY1JLMXJoVjVoTUtFeWZJR0dnTVhiM0Zj?= =?utf-8?B?TmIwRTduM1pnd2s4a1BISm1qam9kQ3J6dlBuNjk3ZGxiQkpsMmJBVU9vNjBB?= =?utf-8?B?RTZiSTl2b0IzNmU3cldHVDY4dUZoVUlkditVVVlQRGF3TnJGSWQ0T016Wm85?= =?utf-8?B?NTk5bEtHeWdUOVdTZzRjN2NHamZVdmhEcHR0bU9wV203RmNpaVVTUi9pL1lj?= =?utf-8?B?SFRpWjJFMTk1eDJ5MnZ2Smd0TytnSnNKeTNrUXQrMm1xMzAwSHl3SFdqUnpX?= =?utf-8?B?bWFCSHk4SU9rVmdjTENucVd2OGZtZzRSdXM0UUFDSktYZFYrTVV5YnlTcTFu?= =?utf-8?B?Vm1KVGlYVzBTS2Jtc3RSTnZXTThNZVE1ellWVGZlYWhNWFhCbm9FUzRBaThL?= =?utf-8?B?TDVpL3JhaWpmWUh2Y3FaQTNPZVQ3Nm5tWnB6Q0F0b29oRGZ3U2tEUWhMMGdM?= =?utf-8?B?N2ZkaWpHZ040Y040NlI3d0swYVhieDBxbElnOERpd2lPekRZK055aVJyd0hu?= =?utf-8?B?ci9wRUtJT3hxVmJVeS9lSXNLWitjMmNpcmhHS0xvSEpZaE5XVkM2cmV2WG1T?= =?utf-8?B?THpmeGNxWEVlUG1GM2xUeGRwNFFQb2JhNWx2UENlWTUrbWJKazBtRkN1ZzhX?= =?utf-8?B?VFpUZ2lEdDhodjh6ckVxOEFBZ2l0UDhzK25vdDVxbW1oNzRuSm9wOGFSckxT?= =?utf-8?B?VFdzZ3Foek96VUJXaCtKU1BFdzVTRHZBUEVNYUZDS2MzaDI4MytIRXJIWFRm?= =?utf-8?B?QmtpWG9SZk81dHdtb2hQTmY3TkJMNjNBa281Qk5qcDRsWU40WVpQWi90VHph?= =?utf-8?B?Nkp6L25vOC9MMUlFeng0em9ZNjJWWE5TN0lSZU9PcFBVR1dwb0FNMzk1bmdL?= =?utf-8?B?WHFDUlAxdTJQVmVBdktHRTVQb0ExVlFLQXpwQWdubGdMNHdSSEJjNVNIdSt3?= =?utf-8?B?akpOMnBKUUp4dGN2QW9NUkdVUnUveGpLQjFFa3RFeFY0WGpqSDcvR1d4Mm0y?= =?utf-8?B?aThQeUdLV2lTajJPVHJRajZaYmplTGY3cVZVUTlldGZmTmtaTEgva3VGbGdl?= =?utf-8?B?RjI5NTZLZm85V3h4dXJqTDNndzc0K2Nqd3VmYk5jSEZxWWhHYlRTSDBmNGV6?= =?utf-8?B?ZlFtTWRTMW5jUTlCNjdwemNmOFA2K29GZjJ4M3FhRTJ4aXhYazRRc1Z0ZXJa?= =?utf-8?B?dW5kTkNrdnFhRWNBdFdpcDlVTG90OVA3dzJVVDVpRkI0cmE0VUxkMXBMYjV0?= =?utf-8?B?dTQ4UklBcHBQeXV3TTNPcml3RysyU1RaN2xSTWFHMW5uL2V4MmdpNUlJSWZn?= =?utf-8?B?eUp4dHozQ3lxWnNYaTA3dHErdTl2TDNtZXIzZnpkajR2QUp1RjNBQVQrOUk2?= =?utf-8?B?ZUl2bnV1RmNCVmV0WFc4V05rQ2IvdjA5K0FMMGptYURybFJpZU8zUmhUbGg1?= =?utf-8?B?SUxZSnRtbkovTW1tZWRGSkd2V2FxMG5sTGJWTmdWZEdFdGhndU1iVVZBSlJo?= =?utf-8?B?SlFTbEVrK25EZVFJalVqaWw0OUFRSkVJYnlFd1hSaTN3OVFldDk4U2ZhT0Ro?= =?utf-8?B?by9mZCtRVDRLbWJySDVXMGJVbkJnSm5UcVZFa01VbG9GejdWam5VeGI2NXRI?= =?utf-8?B?RG5JRzUvR2dtZ0F6eTMvQkVvSTBMQTgrNkJFekNRbFVnd1IzZzJLWmtNMUJq?= =?utf-8?B?UG0xZ0xWcWVieHBsVWNFUlRlVk9nOERteGE0V1hoRnQzWVB4TGcvTVM3VDU4?= =?utf-8?B?M1E9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SL2PR03MB4204.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7de2f678-0b84-4bb7-4392-08db408781d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2023 03:38:14.5903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M5VDdYSP+zYVgnkApikauVT2GjOnN+tPbIu8nuaMsfV4h48M1Eq+TDPHtgf1HpL+FwdJenCJ5+7KKIet7rYTepUPaTBhEw1pJJXRaDNMkWA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR03MB7212 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230418_203859_916961_78A8F450 X-CRM114-Status: GOOD ( 26.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On Fri, 2023-03-31 at 11:44 -0600, Mathieu Poirier wrote: > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > On Tue, Mar 28, 2023 at 10:27:27AM +0800, Tinghan Shen wrote: > > This is the preparation for probing multi-core SCP. The remoteproc > > initialization flow is similar on cores and is reused to avoid > > redundant code. > > > > The registers of config and l1tcm are shared for multi-core > > SCP. Reuse the mapped addresses for all cores. > > > > Signed-off-by: Tinghan Shen > > Reviewed-by: AngeloGioacchino Del Regno > > --- > > drivers/remoteproc/mtk_scp.c | 64 +++++++++++++++++++++++++----------- > > 1 file changed, 45 insertions(+), 19 deletions(-) > > > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > > index a3b9bc158cd9..32ecd1450c6f 100644 > > --- a/drivers/remoteproc/mtk_scp.c > > +++ b/drivers/remoteproc/mtk_scp.c > > @@ -23,6 +23,13 @@ > > #define MAX_CODE_SIZE 0x500000 > > #define SECTION_NAME_IPI_BUFFER ".ipi_buffer" > > > > +struct mtk_scp_of_regs { > > + void __iomem *reg_base; > > + void __iomem *l1tcm_base; > > + size_t l1tcm_size; > > + phys_addr_t l1tcm_phys; > > +}; > > + > > This should represent the cluster with a list of mtk_scp instead of @cluster_cores as > introduced in the next patch. If I'm understanding you correctly, you're suggesting that @cluster_cores should be included as a member of this structure. Is that correct? Best regards, TingHan > > > /** > > * scp_get() - get a reference to SCP. > > * > > @@ -855,7 +862,8 @@ static void scp_remove_rpmsg_subdev(struct mtk_scp *scp) > > } > > } > > > > -static int scp_probe(struct platform_device *pdev) > > +static int scp_rproc_init(struct platform_device *pdev, > > + struct mtk_scp_of_regs *of_regs) > > { > > struct device *dev = &pdev->dev; > > struct device_node *np = dev->of_node; > > @@ -879,6 +887,11 @@ static int scp_probe(struct platform_device *pdev) > > scp->data = of_device_get_match_data(dev); > > platform_set_drvdata(pdev, scp); > > > > + scp->reg_base = of_regs->reg_base; > > + scp->l1tcm_base = of_regs->l1tcm_base; > > + scp->l1tcm_size = of_regs->l1tcm_size; > > + scp->l1tcm_phys = of_regs->l1tcm_phys; > > + > > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sram"); > > scp->sram_base = devm_ioremap_resource(dev, res); > > if (IS_ERR(scp->sram_base)) > > @@ -888,24 +901,6 @@ static int scp_probe(struct platform_device *pdev) > > scp->sram_size = resource_size(res); > > scp->sram_phys = res->start; > > > > - /* l1tcm is an optional memory region */ > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "l1tcm"); > > - scp->l1tcm_base = devm_ioremap_resource(dev, res); > > - if (IS_ERR(scp->l1tcm_base)) { > > - ret = PTR_ERR(scp->l1tcm_base); > > - if (ret != -EINVAL) { > > - return dev_err_probe(dev, ret, "Failed to map l1tcm memory\n"); > > - } > > - } else { > > scp->l1tcm_base = NULL; > > > - scp->l1tcm_size = resource_size(res); > > - scp->l1tcm_phys = res->start; > > - } > > - > > - scp->reg_base = devm_platform_ioremap_resource_byname(pdev, "cfg"); > > - if (IS_ERR(scp->reg_base)) > > - return dev_err_probe(dev, PTR_ERR(scp->reg_base), > > - "Failed to parse and map cfg memory\n"); > > - > > ret = scp->data->scp_clk_get(scp); > > if (ret) > > return ret; > > @@ -957,6 +952,37 @@ static int scp_probe(struct platform_device *pdev) > > return ret; > > } > > > > +static int scp_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct mtk_scp_of_regs scp_regs; > > + struct resource *res; > > + int ret; > > + > > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "cfg"); > > + scp_regs.reg_base = devm_ioremap_resource(dev, res); > > + if (IS_ERR(scp_regs.reg_base)) > > + return dev_err_probe(dev, PTR_ERR(scp_regs.reg_base), > > + "Failed to parse and map cfg memory\n"); > > + > > + /* l1tcm is an optional memory region */ > > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "l1tcm"); > > + scp_regs.l1tcm_base = devm_ioremap_resource(dev, res); > > + if (IS_ERR(scp_regs.l1tcm_base)) { > > + ret = PTR_ERR(scp_regs.l1tcm_base); > > + if (ret != -EINVAL) > > + return dev_err_probe(dev, ret, "Failed to map l1tcm memory\n"); > > + > > + scp_regs.l1tcm_size = 0; > > + scp_regs.l1tcm_phys = 0; > > + } else { > > + scp_regs.l1tcm_size = resource_size(res); > > + scp_regs.l1tcm_phys = res->start; > > + } > > + > > + return scp_rproc_init(pdev, &scp_regs); > > +} > > + > > static int scp_remove(struct platform_device *pdev) > > { > > struct mtk_scp *scp = platform_get_drvdata(pdev); > > -- > > 2.18.0 > > -- Best regards, TingHan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel