From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6121CC27C6E for ; Mon, 17 Jun 2024 07:24:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IpoUfU25aFExpQhRHpFgANp2YolLmCOPv3K1gnuPL2Y=; b=CdJyhSXB0f5K9oXC1fNbO8PCRZ 9xSbjGUrfHo+VIbhUCC0Zo59PH+1B4W37hhHNr115tE2ZJtkxR8XzIbYI5bVJMbjgHoTKBCBxaUnI OSsEJuS6QELqejZ4Y/JNCJdXz9FHFQ2UZe8L4fuuqSDdS6JN1uYXb/pM1XyE3olD7E0DK9bLer8wf GDybXmNHNp0oMbHDaJN+hcF696PGFe+sDpK68/MWBaVIwPYkAdqZl89+hbkZx6ANCZtvojRVfy8j4 +nzqZ7tHP5w1AhL+tnkzydKlOSVhciIsZi1nAwVYzQY+HSznC5vLpPhAsySMxaU2wG501DDHO4uDk m5jHLIHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ6iq-00000009dEy-1zmV; Mon, 17 Jun 2024 07:24:12 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ6im-00000009dDk-2Bww for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 07:24:10 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-35f236a563cso3279691f8f.2 for ; Mon, 17 Jun 2024 00:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1718609044; x=1719213844; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IpoUfU25aFExpQhRHpFgANp2YolLmCOPv3K1gnuPL2Y=; b=qHTwaEAoKYNS3hoiu8l5hr8TRiySu737z0ywqMyUuKrCKR4Yj351k4sHFBDPDmpSR9 F6ZhMSg9v6OojUdIjCDrqW3jLE0RxiuFQ9fCLuIAkiuI31Hi7SEpgZxfdJFoETTbzbXL MZpPNM2QFMymUDrJZsPpFb+Oz8ytYTN08UsFD+jTsIzsXzP/1yiHq4NuGYckE9MBOKU7 1MnPPcbLFqJGhGuJKuZpnbAkyUhyGkLYd5Z5tNo7wUuIuet4Mo4M5bLDrlRzKdTeqgnK 0qd5JcYAU/+t/6Zr8sQzo/OWPVqVhfxpnMj+gQ4fSA8/JBdP6sUwSRDuFdsVPoIdnJ0a hiYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718609044; x=1719213844; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IpoUfU25aFExpQhRHpFgANp2YolLmCOPv3K1gnuPL2Y=; b=PN71dZ5d5OELKgaEsO59aQzz/DuB99OBaxAoQAVTK3EBEo8nwyoik502CdVAK2mIOh G/spMd9YoF7dTJQywuC7rFwIi9jcEnQEQdYnoEDhlzLDCWUvkbMifrIagFk8hZwGUwCR dMMIwpZzFYUURIcrlTj9A8P8z3bwkamjEy4zssrsLt2cBvPCzWAibx7z5aqaTp1qkbOj 7/KtPwLNfm613sc9rZRrz8KwQmvMbd05S7pdFcvEVxSWqbBqxKvm+WSTrpXznjFip+hL 7uVMMPQe70u/e7f8IC9Da7OrnXYIgRm6ODNqFauHkmjoCtSQobLnolNuTunGlIb3oh3e YIYQ== X-Forwarded-Encrypted: i=1; AJvYcCX67UsAT4qwiMJGD8+s3gIhR5ZXpCB3sqE40zEG88KwB7ndVPGNTL3PSCeTCuBVJuMl2y6sJ5fYPfw/Dhxc6S+pCtitxVzVwmJCXCki+phXRhXn4Rw= X-Gm-Message-State: AOJu0Yyet2gPEiP6xAhDUq819go393Z2i4sDq49slq19lNxsFTSPvkfL A8KYJanFksmSzYFCGjXXugw5f6xYhKs4wv0vU5FfXyAflSlGrJXMZ9SLKc6IbVg= X-Google-Smtp-Source: AGHT+IEOD4FT6z5nxG5bniU7J/sW/K0IX0zmiUgy/bxvKupAzvp/m3MmMTj6Dy5w8kPrtiMfENwRjQ== X-Received: by 2002:adf:fa8a:0:b0:360:728d:842b with SMTP id ffacd0b85a97d-3607a77fa69mr6262778f8f.52.1718609044415; Mon, 17 Jun 2024 00:24:04 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3609515e16dsm2528937f8f.44.2024.06.17.00.24.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 00:24:04 -0700 (PDT) Message-ID: <46ca8705-cb3a-4a0c-87bf-d1eea7341822@tuxon.dev> Date: Mon, 17 Jun 2024 10:24:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/12] dt-bindings: rtc: renesas,rzg3s-rtc: Document the Renesas RZ/G3S RTC Content-Language: en-US To: Krzysztof Kozlowski , geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, alexandre.belloni@bootlin.com, magnus.damm@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea References: <20240614071932.1014067-1-claudiu.beznea.uj@bp.renesas.com> <20240614071932.1014067-6-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_002408_601268_133CB5A4 X-CRM114-Status: GOOD ( 12.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16.06.2024 10:40, Krzysztof Kozlowski wrote: > On 14/06/2024 09:19, Claudiu wrote: >> From: Claudiu Beznea >> >> Document the RTC IP (RTCA-3) available on the Renesas RZ/G3S SoC. > >> + >> + clocks: >> + maxItems: 1 >> + description: RTC counter clock > > Just items: with description instead. > OK >> + >> + clock-names: >> + maxItems: 1 > > Nope, it must be specifc. Or just drop. This applies to all your patches. OK > >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - interrupt-names >> + - clocks >> + - clock-names >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + rtc: rtc@1004ec00 { > > Drop label, not used. OK > >> + compatible = "renesas,rzg3s-rtc"; >> + reg = <0x1004ec00 0x400>; >> + interrupts = , >> + , >> + ; >> + interrupt-names = "alarm", "period", "carry"; >> + clocks = <&vbattclk>; >> + clock-names = "counter"; >> + status = "disabled"; > > Why do you paste it eevrywhere? It does no really make sense. Not sure. I'll drop it. Thank you for your review, Claudiu Beznea > > Best regards, > Krzysztof >