From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05088C79F8B for ; Mon, 5 Jan 2026 13:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5pm61tHOxVIMRlo2kMdlbFtWUM1V4vVjtzMYxIxE1KY=; b=vRxGKOzKfBH7xo7inhjNI5jxkW m2uK15x8eEksWlHpQh2MzTz3cWHsq+fIw7iC4+5SEKoswgxuULQB7DD4z3O5Cx/wmBiR5XIy7lRpQ 0pEDRH/nO4H6A8UMClWZNmXWx6G8EEl0sw+Gif3y8Epti7GmY818Py9uxh7wvZVbc4NJRViKFuSFN HVluzwj3QzOR3PV5wST2QF4/5y+2aebP3SJqqRSwDIvmyV9GircH2SFMJgWZaGY7ZlPHmlc3ZpQiU i66X/0uxzZ/UlB0PX22C2KM5WBbuDzlsncCWcJ0+xYOw13WzZm7EkjLOXqO0DqLvxS5B36SXmW4Sd YoWGAJVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vckwc-0000000BUn1-2fvj; Mon, 05 Jan 2026 13:48:26 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vckwZ-0000000BUmI-3K3S for linux-arm-kernel@lists.infradead.org; Mon, 05 Jan 2026 13:48:24 +0000 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-42fb6ce71c7so11503511f8f.1 for ; Mon, 05 Jan 2026 05:48:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767620901; x=1768225701; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=5pm61tHOxVIMRlo2kMdlbFtWUM1V4vVjtzMYxIxE1KY=; b=Ii3MI0O5LvgZ5DeZzVe9Yy4+GcmZyNLOHekR7R8hmfjEcrfFNjs3tfUhyEtg/6eRgd oRjHhwoi5KiAewdIkpQORNtnmfM2ZLmeKhlh6BiDCfXr3YV9qZUmJckXTXGc9rKEdMk7 P7MyI7Fku7P+BRUoOxHsIekToLm0Uimp3+H5prGUDrYUwdfNG4IX8rqIVBpUPMrZ8bXq /3T2nkKx6p8GxmcDW1otim+9EBz611qQna5pM0Ssj7hrw5k/qKLQWZOh0DaYBN97/wEV raBi8cNSl+id+OIwS5GLaPQIuuh4vgk0r1DMq79zf1b9Aaimk9BCGS6UD6sHP6Z883Be N3Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767620901; x=1768225701; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5pm61tHOxVIMRlo2kMdlbFtWUM1V4vVjtzMYxIxE1KY=; b=p9QqX+jZMx8Bpif5A3KE/EQjwM3pwbEqMYB/CzavC4rZzYb2J8DLcO5zLIJNOOW+Sz dSrqtROefFRSMC+JtsVMA61ohPHgQNPLMxbmgA8URAXOwfmVqQustZ2qnZOS1mLoPRqb Voe0RWZSnMIll1Lz8fOQ9VZiv+kyT4yy5dWmhZ8+ZyDIJZIPDwJfbQkqywby3SQZ9GSe 2wbKhBXy8JHTLUjrHms8540q8Y/orLFOYV4g9WJVJrAh5pSfLez+yXp/DPNd6dvGJoKs jngYfdREGw6QdP2Gg3PlxEmnagOkmzWln1wpqezsJGasB/Dq5hHRfG0BbFIsAFY8P9wS RGfw== X-Forwarded-Encrypted: i=1; AJvYcCX26+iDjRcmvsyP2KXoJTXAKzA2SNtShYEGXhThiOw7NbGV+c2+crjdL2UNXogEOyrxeAY00G3S9DPBlSXrnjrQ@lists.infradead.org X-Gm-Message-State: AOJu0YzHaX82r18OO9e/3UVpNhPdds9SWmoRFT3Iy371P46vctzvk5Vj os82i8ZyGgsmN82NPaYJwtCT+Immi0KpT5JEn62vptKBAFbCVQ4v3ydKQppVJBUXT8QaF4Zattc PRGF7 X-Gm-Gg: AY/fxX6qLENZSa5Yu9Pjef1fu4ivzsmzjDpb3OTg/6A5jayET/mmUJR9qh4ACJL0G90 hQ9Bns0aYq84dbVpCWvSUc0A82SZdkYkyiWXo/iHwR9jjN6v8jij5u9O7xNLwEbQyeomwf3KlzH iLowELak6QvHJkd1Ck70xpsQ+uzqP4F4pbFsqFNSywLyol/6nSrY8Xr6Joh8upQDOZ5CW0TlDCL 6XZiR0IaZXvOXFtXdhRC13s6KOEBTmu5wH9R/EvzTDBZeuTd2cWcb+aPpDrs9ZXotn95Jpl+n8J DINved0jt/UZKBljZCzSRRWGg4eaz0zBvsmYkbcRTIILqBbJq8dd9QkZLKpQqF1qSe6D+YiS++G X0vpJvgbkXcQYEWduhh6lYI5EwiIwQVpXr4HLpVJidNEeVr+vWZeWdfYyASwMof6Igq6yNCw6Fs NPiNpQXeCAFXMSHuEH87CmatjMVb612wvPcapRGm+Y6vvsXIl/+U6S3jmYB2bEFLE= X-Google-Smtp-Source: AGHT+IFJH9vjvSt9a1g91foUnNhyxduRLS5b5HEkPDAICFvU5f47KylFUeGSvzLd5WqdKzRrR497ng== X-Received: by 2002:a05:6000:40dc:b0:432:5bac:3915 with SMTP id ffacd0b85a97d-4325bac3a19mr59539111f8f.39.1767620901179; Mon, 05 Jan 2026 05:48:21 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:d4c1:5589:eadb:1033? ([2a01:e0a:3d9:2080:d4c1:5589:eadb:1033]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1b1b1sm100156855f8f.3.2026.01.05.05.48.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jan 2026 05:48:20 -0800 (PST) Message-ID: <46d049cd-3307-4fbb-b33e-69ba05ded106@linaro.org> Date: Mon, 5 Jan 2026 14:48:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Subject: Re: [PATCH] PCI: meson: Drop unused WAIT_LINKUP_TIMEOUT macro To: Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bhelgaas@google.com, robh@kernel.org, mani@kernel.org, kwilczynski@kernel.org, lpieralisi@kernel.org, yue.wang@Amlogic.com References: <20260105125625.239497-1-martin.blumenstingl@googlemail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260105125625.239497-1-martin.blumenstingl@googlemail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260105_054823_841091_B3B7D9AC X-CRM114-Status: GOOD ( 13.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/5/26 13:56, Martin Blumenstingl wrote: > Commit 113d9712f63b ("PCI: meson: Report that link is up while in ASPM > L0s and L1 states") removed the waiting loop in meson_pcie_link_up() > making #define WAIT_LINKUP_TIMEOUT now unused. > > Drop the now unused variable to keep the driver code clean. > > Signed-off-by: Martin Blumenstingl > --- > drivers/pci/controller/dwc/pci-meson.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c > index a1c389216362..0694084f612b 100644 > --- a/drivers/pci/controller/dwc/pci-meson.c > +++ b/drivers/pci/controller/dwc/pci-meson.c > @@ -37,7 +37,6 @@ > #define PCIE_CFG_STATUS17 0x44 > #define PM_CURRENT_STATE(x) (((x) >> 7) & 0x1) > > -#define WAIT_LINKUP_TIMEOUT 4000 > #define PORT_CLK_RATE 100000000UL > #define MAX_PAYLOAD_SIZE 256 > #define MAX_READ_REQ_SIZE 256 Reviewed-by: Neil Armstrong