* [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups
@ 2017-02-08 5:31 Dawei Chien
2017-02-09 21:25 ` Matthias Brugger
0 siblings, 1 reply; 5+ messages in thread
From: Dawei Chien @ 2017-02-08 5:31 UTC (permalink / raw)
To: linux-arm-kernel
Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors.
However, Currently thermal driver don't need read TEMP_MSR3 since
thermal controller only use 3 sensors for each thermal bank.
Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
---
drivers/thermal/mtk_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 34169c3..c124151 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -191,7 +191,7 @@ struct mtk_thermal {
};
const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = {
- TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2
+ TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3
};
const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = {
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups
2017-02-08 5:31 [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups Dawei Chien
@ 2017-02-09 21:25 ` Matthias Brugger
2017-02-13 9:01 ` Dawei Chien
0 siblings, 1 reply; 5+ messages in thread
From: Matthias Brugger @ 2017-02-09 21:25 UTC (permalink / raw)
To: linux-arm-kernel
On 02/08/2017 06:31 AM, Dawei Chien wrote:
> Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors.
> However, Currently thermal driver don't need read TEMP_MSR3 since
> thermal controller only use 3 sensors for each thermal bank.
>
> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
> ---
Actually the commit message should state:
Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
...and get backported to v4.9 and v4.10.
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Regards,
Matthias
> drivers/thermal/mtk_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 34169c3..c124151 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -191,7 +191,7 @@ struct mtk_thermal {
> };
>
> const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = {
> - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2
> + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3
> };
>
> const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = {
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups
2017-02-09 21:25 ` Matthias Brugger
@ 2017-02-13 9:01 ` Dawei Chien
2017-02-19 1:23 ` Eduardo Valentin
0 siblings, 1 reply; 5+ messages in thread
From: Dawei Chien @ 2017-02-13 9:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi, Matthias,
On Thu, 2017-02-09 at 22:25 +0100, Matthias Brugger wrote:
>
> On 02/08/2017 06:31 AM, Dawei Chien wrote:
> > Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors.
> > However, Currently thermal driver don't need read TEMP_MSR3 since
> > thermal controller only use 3 sensors for each thermal bank.
> >
> > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
> > ---
>
> Actually the commit message should state:
> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
>
> ...and get backported to v4.9 and v4.10.
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> Regards,
> Matthias
Thank you for your review. I would add below commit message on next
version. However, currently 8173 thermal driver would not read TEMP_MSR3
since thermal driver only use 3 sensors on each bank, this patch would
not effect temperature.
Only if thermal driver use 4 sensors on any thermal bank, would read
third sensor two times, and lose fourth sensor of vale.
Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
> > drivers/thermal/mtk_thermal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> > index 34169c3..c124151 100644
> > --- a/drivers/thermal/mtk_thermal.c
> > +++ b/drivers/thermal/mtk_thermal.c
> > @@ -191,7 +191,7 @@ struct mtk_thermal {
> > };
> >
> > const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = {
> > - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2
> > + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3
> > };
> >
> > const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = {
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups
2017-02-13 9:01 ` Dawei Chien
@ 2017-02-19 1:23 ` Eduardo Valentin
2017-02-20 11:30 ` Matthias Brugger
0 siblings, 1 reply; 5+ messages in thread
From: Eduardo Valentin @ 2017-02-19 1:23 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Feb 13, 2017 at 05:01:58PM +0800, Dawei Chien wrote:
> Hi, Matthias,
>
> On Thu, 2017-02-09 at 22:25 +0100, Matthias Brugger wrote:
> >
> > On 02/08/2017 06:31 AM, Dawei Chien wrote:
> > > Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors.
> > > However, Currently thermal driver don't need read TEMP_MSR3 since
> > > thermal controller only use 3 sensors for each thermal bank.
> > >
> > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
> > > ---
> >
> > Actually the commit message should state:
> > Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
> >
> > ...and get backported to v4.9 and v4.10.
> >
> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> >
> > Regards,
> > Matthias
>
> Thank you for your review. I would add below commit message on next
> version. However, currently 8173 thermal driver would not read TEMP_MSR3
> since thermal driver only use 3 sensors on each bank, this patch would
> not effect temperature.
> Only if thermal driver use 4 sensors on any thermal bank, would read
> third sensor two times, and lose fourth sensor of vale.
> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
>
Please send a new version with the tag in the commit message.
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups
2017-02-19 1:23 ` Eduardo Valentin
@ 2017-02-20 11:30 ` Matthias Brugger
0 siblings, 0 replies; 5+ messages in thread
From: Matthias Brugger @ 2017-02-20 11:30 UTC (permalink / raw)
To: linux-arm-kernel
On 19/02/17 02:23, Eduardo Valentin wrote:
> On Mon, Feb 13, 2017 at 05:01:58PM +0800, Dawei Chien wrote:
>> Hi, Matthias,
>>
>> On Thu, 2017-02-09 at 22:25 +0100, Matthias Brugger wrote:
>>>
>>> On 02/08/2017 06:31 AM, Dawei Chien wrote:
>>>> Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors.
>>>> However, Currently thermal driver don't need read TEMP_MSR3 since
>>>> thermal controller only use 3 sensors for each thermal bank.
>>>>
>>>> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
>>>> ---
>>>
>>> Actually the commit message should state:
>>> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
>>>
>>> ...and get backported to v4.9 and v4.10.
>>>
>>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>>>
>>> Regards,
>>> Matthias
>>
>> Thank you for your review. I would add below commit message on next
>> version. However, currently 8173 thermal driver would not read TEMP_MSR3
>> since thermal driver only use 3 sensors on each bank, this patch would
>> not effect temperature.
>> Only if thermal driver use 4 sensors on any thermal bank, would read
>> third sensor two times, and lose fourth sensor of vale.
>> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
>>
>
> Please send a new version with the tag in the commit message.
>
And don't forget to add stable at vger.kernel.org so that the fix ends up
in the older kernels as well.
Regards,
Matthias
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-20 11:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-08 5:31 [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups Dawei Chien
2017-02-09 21:25 ` Matthias Brugger
2017-02-13 9:01 ` Dawei Chien
2017-02-19 1:23 ` Eduardo Valentin
2017-02-20 11:30 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).