public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: James Calligeros <jcalligeros99@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
	Baojun Xu <baojun.xu@ti.com>, Frank Li <Frank.Li@nxp.com>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, asahi@lists.linux.dev
Subject: Re: [PATCH v3 5/7] ASoC: soc-dai: add common operation to set TDM idle mode
Date: Tue, 03 Mar 2026 19:10:49 +1000	[thread overview]
Message-ID: <4716405.LvFx2qVVIh@setsuna> (raw)
In-Reply-To: <877brtacgp.wl-kuninori.morimoto.gx@renesas.com>

Hi Kuniori,

On Tuesday, 3 March 2026 12:11:50 pm Australian Eastern Standard Time Kuninori 
Morimoto wrote:
> > +int snd_soc_dai_set_tdm_idle(struct snd_soc_dai *dai,
> > +			     unsigned int tx_mask, unsigned int rx_mask,
> > +			     int tx_mode, int rx_mode);
> 
> Do we need "rx_mode" ?
> Only "tx_mode" is enough if my understanding was correct.

For our (Asahi) purposes yes, we only require TX. However, TAS2770 also
has a bus keeper on SDIN, and I suspect other hardware may too. Rather than
break the API later on should the need to configure this arise,
I decided to add the capability now. I am happy to get rid of it if
we think it is superfluous at this time though.

> This patch-set adds new snd_soc_dai_set_tdm_idle(), but no one is calling
> it. Who use it ??

Currently no one in tree consumes this API, and it is likely that no one will
until we submit our platform driver. See the linked resources in the cover
letter for more details.

In the interests of transparency, I don't expect to have the
platform driver ready for submission any time soon; it is a bit of a mess
and given that I did not write most of it I still need to wrap my head
around why certain decisions were made during its design. However, we
are 100% committed to getting it merged at some point.

If you would prefer I can resubmit this series along with the driver
once it is ready, so that there is an example consumer for the API.

Regards,

James Calligeros




  reply	other threads:[~2026-03-03  9:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-01  8:05 [PATCH v3 0/7] ASoC: basic support for configuring bus keepers James Calligeros
2026-03-01  8:05 ` [PATCH v3 1/7] ASoC: dt-bindings: convert tdm-slot to YAML James Calligeros
2026-03-06  1:07   ` Rob Herring (Arm)
2026-03-01  8:05 ` [PATCH v3 2/7] ASoC: dt-bindings: update tdm-slot.txt references to tdm-slot.yaml James Calligeros
2026-03-06  1:07   ` Rob Herring (Arm)
2026-03-01  8:05 ` [PATCH v3 3/7] ASoC: dt-bindings: add TDM slot idle mode properties James Calligeros
2026-03-06  1:08   ` Rob Herring (Arm)
2026-03-01  8:05 ` [PATCH v3 4/7] ASoC: soc-dai: define possible idle TDM slot modes James Calligeros
2026-03-01  8:05 ` [PATCH v3 5/7] ASoC: soc-dai: add common operation to set TDM idle mode James Calligeros
2026-03-03  2:11   ` Kuninori Morimoto
2026-03-03  9:10     ` James Calligeros [this message]
2026-03-03 18:17       ` Mark Brown
2026-03-01  8:05 ` [PATCH v3 6/7] ASoC: tas2764: expose SDOUT bus keeper via set_tdm_idle operation James Calligeros
2026-03-01  8:05 ` [PATCH v3 7/7] ASoC: tas2770: expose SDOUT bus keeper via set_tdm_idle James Calligeros
2026-03-12 14:33   ` Mark Brown
2026-03-14  2:32     ` James Calligeros
2026-03-16  1:13 ` [PATCH v3 0/7] ASoC: basic support for configuring bus keepers Mark Brown
2026-03-16 17:52 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4716405.LvFx2qVVIh@setsuna \
    --to=jcalligeros99@gmail.com \
    --cc=Frank.Li@nxp.com \
    --cc=asahi@lists.linux.dev \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=kevin-lu@ti.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shenghao-ding@ti.com \
    --cc=shengjiu.wang@nxp.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox