From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: mm: hide __start_rodata_section_aligned for non-debug builds
Date: Tue, 16 Feb 2016 17:34:30 +0100 [thread overview]
Message-ID: <4716656.D1MJCNd1N6@wuerfel> (raw)
In-Reply-To: <CAKv+Gu8JcWg4BkxZFPqTotkfHFtP744XYdSx6XROJSM_8pmt2w@mail.gmail.com>
On Tuesday 16 February 2016 17:12:52 Ard Biesheuvel wrote:
> > +#ifdef CONFIG_DEBUG_RODATA
> > /*
> > * Without CONFIG_DEBUG_ALIGN_RODATA, __start_rodata_section_aligned will
> > * be the first section-aligned location after __start_rodata. Otherwise,
> > * it will be equal to __start_rodata.
> > */
> > __start_rodata_section_aligned = ALIGN(__start_rodata, 1 << SECTION_SHIFT);
> > +#endif
> >
>
> Does
>
> PROVIDE(__start_rodata_section_aligned = xxx);
>
> do the trick as well? If it does, it's a bit cleaner.
>
I would assume not, as the problem is that SECTION_SHIFT is a macro that
is not defined when the MMU is disabled.
Arnd
next prev parent reply other threads:[~2016-02-16 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 16:03 [PATCH 1/2] ARM: mm: DEBUG_RODATA makes no sense with XIP_KERNEL Arnd Bergmann
2016-02-16 16:03 ` [PATCH 2/2] ARM: mm: hide __start_rodata_section_aligned for non-debug builds Arnd Bergmann
2016-02-16 16:12 ` Ard Biesheuvel
2016-02-16 16:34 ` Arnd Bergmann [this message]
2016-02-16 16:36 ` Ard Biesheuvel
2016-02-16 16:05 ` [PATCH 1/2] ARM: mm: DEBUG_RODATA makes no sense with XIP_KERNEL Ard Biesheuvel
2016-02-16 18:41 ` Kees Cook
2016-02-16 20:31 ` Kees Cook
2016-02-16 23:12 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4716656.D1MJCNd1N6@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox