From: "Heiko Stübner" <heiko@sntech.de>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kever.yang@rock-chips.com" <kever.yang@rock-chips.com>,
"finley.xiao@rock-chips.com" <finley.xiao@rock-chips.com>,
"w@1wt.eu" <w@1wt.eu>
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Enable OTP controller for RK3562
Date: Mon, 09 Feb 2026 21:23:09 +0100 [thread overview]
Message-ID: <4721118.KgjxqYA5nG@diego> (raw)
In-Reply-To: <e58ebe6e-1de7-4b72-bf5e-e93cc19e69fd@kwiboo.se>
Am Montag, 9. Februar 2026, 17:54:51 Mitteleuropäische Normalzeit schrieb Jonas Karlman:
> Hi Heiko,
>
> Thanks for including my RK3528 patches :-)
>
> On 2/5/2026 10:23 PM, Heiko Stuebner wrote:
> > Enable the One Time Programmable Controller (OTPC) in RK3562 and add
> > an initial nvmem fixed layout.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3562.dtsi | 46 ++++++++++++++++++++++++
> > 1 file changed, 46 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3562.dtsi b/arch/arm64/boot/dts/rockchip/rk3562.dtsi
> > index f84676b47b27..07626dba21bf 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3562.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3562.dtsi
> > @@ -1093,6 +1093,52 @@ sdmmc1: mmc@ff890000 {
> > status = "disabled";
> > };
> >
> > + otp: otp@ff930000 {
>
> I noticed that the node names is not consistent for all three patches in
> this series.
>
> A quick grep at Linux src also suggest that efuse@ being the most common
> node name used for similar otpc/efuse, efuse is also listed under
> 2.2.2 Generic Names Recommendation in DT spec.
>
> Maybe the nodes should be renamed to use efuse@ or something else?
Fine by me :-)
So we'll make this efuse@ for all 3 newly added otp controllers.
Heiko
next prev parent reply other threads:[~2026-02-09 20:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 21:23 [PATCH 0/3] Add devicetree nodes for RK3528, RK3562 and RK356x Heiko Stuebner
2026-02-05 21:23 ` [PATCH 1/3] arm64: dts: rockchip: Enable OTP controller for RK3562 Heiko Stuebner
2026-02-09 16:54 ` Jonas Karlman
2026-02-09 20:23 ` Heiko Stübner [this message]
2026-02-05 21:23 ` [PATCH 2/3] arm64: dts: rockchip: Enable OTP controller for RK356x Heiko Stuebner
2026-02-05 21:23 ` [PATCH 3/3] arm64: dts: rockchip: Enable OTP controller for RK3528 Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4721118.KgjxqYA5nG@diego \
--to=heiko@sntech.de \
--cc=finley.xiao@rock-chips.com \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox