From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76D23CDB47E for ; Fri, 13 Oct 2023 08:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3OnD4ToIrRg3qRqBJR80mv/jNEt9xvq5yy6Ei9yhmkk=; b=uhM9NopqmV/MW5 ugRgjfRqDpH3RDzK9wN5CZB2XMqqlc3ZgwKUYBUsvQtiyVm95v5APtNPc+Drsce4wF1c816QpN66D RJ/bh9WLwTOBELn0Zcicx8sO+yp2pe/rPvuMKRDVXtO++ibvFdp2dERajviYLhnRLxISMSHdYxtQt xynWKkTfutf7ERCUDGu7la8K5XdbnHX3RSFjfBNHprK6x+Zm3H/lm7vbRVtwl/jlKdbFki8idSss7 yghI7vfreKF0sPLIvJ2R6+CH3aZdQMSFJstFGpLSDqKYlzAKzhtTtRQVqpj9rHZig0xg52fIh76L7 ZlM1ioSNHQLORbpHJYBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qrDjn-002qx2-12; Fri, 13 Oct 2023 08:41:39 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qrDjk-002qvl-11; Fri, 13 Oct 2023 08:41:37 +0000 X-UUID: 4b514c3269a411ee86758d4a7c00f3a0-20231013 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=NU9/QiMH288e/WezTjMGR7zn7MRyFMUPPu5o8ejgFkc=; b=A/BICU42kclo7j0GsE83npBWncvj9KmkNoe0K80ssgM077m1Dh/pnz3fWvJ0D6OBjcg2JIHTXJEe/FH50tyeu63dkHuGnvtoWr6bzN74+JJTCwYqGChtwDesHhUhgFIuSy/XT7YpAqinwdz2JKx83ZD7aDmUswfa+G3KD3cHb18=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.32,REQID:d4fed2d6-a78b-4fc8-a10b-3aa79b8a8536,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:5f78ec9,CLOUDID:43fec0f0-9a6e-4c39-b73e-f2bc08ca3dc5,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-UUID: 4b514c3269a411ee86758d4a7c00f3a0-20231013 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 433734185; Fri, 13 Oct 2023 01:41:25 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 13 Oct 2023 16:31:22 +0800 Received: from APC01-SG2-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 13 Oct 2023 16:31:22 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T72Xr8QgIlKAmuEFmd8YPP70y6toViIGWLm1gpKOMGFRVFdXhuYTgelAiatJMDZpJJv48MqLmYeXXxTfw1cukmDn2UHRpfSpfhoXbvGVZ2HysEmbB+vQaIrka80HeEyae4h4jEXIqOwSuBHYiiWZSUpBsi/v30w6b6deCl0MwJKOIv41CFjyCZYF0YnpzcI3aEn3rtY8avBEBLCtOPbGRbxPZBEM33GXhIf2uL0kdRrimJa0CqrSXVJfWmf6FfuwVfp5jLiiZzxuQuXkL7Yk7tkTy2dXScEo9vzId8ptvKwrB/pYZOupO2zzh+n0S1YrPwMFmMsR9LQNO/PN7qMcSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NU9/QiMH288e/WezTjMGR7zn7MRyFMUPPu5o8ejgFkc=; b=eVy6ir/xP+KPnEv7xgMcqxQn7OEjUcUF4Ki/SqzFM/174Gj+rWfTrxxjEfw8Zv1G46NOwwE2sV4EJfVlcmz8Dk8qKwP6Neuk+JTjtuaJZTDgTSqqA7H1kIbmqKK9q9nIZQ/DBmcIUsMms2OVMdVVraq5grcAgH9C0JjyeyFivALKNMxQyHzo+KbFlFu9Vp+ysr7+fbKZlIfsgMBmAcGGCZIQHVAusEhWS75UFyb1YdNmL8+vAf0o89WASUftG0iG4Lg5PC4Gtv9OUJbXQOvgeCd2QqgO4V0jmDy2DEs3et0VQ18n1n8NkKtMZcBmas7+WnhRmh4eyKvSOZVTzlUBSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NU9/QiMH288e/WezTjMGR7zn7MRyFMUPPu5o8ejgFkc=; b=Fy7vjvZmD7DynyjdbhaY3k0EYmzZ9yHu9+7hXYSaUPqVwceb5JZTen00eZyYZzO3+5nOZpGvgn1+5AT5c/ASRILN9OZUu7LdEFAmmlNyrIRoL1iLYLlKaByqSTKAumTzGORRkTfoWri9/+uG/qRMn4w+VveYTEvUlQGKqbpqrMA= Received: from PSAPR03MB5365.apcprd03.prod.outlook.com (2603:1096:301:17::5) by SEZPR03MB6889.apcprd03.prod.outlook.com (2603:1096:101:a0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.44; Fri, 13 Oct 2023 08:31:19 +0000 Received: from PSAPR03MB5365.apcprd03.prod.outlook.com ([fe80::8416:8e7a:af7f:7ed0]) by PSAPR03MB5365.apcprd03.prod.outlook.com ([fe80::8416:8e7a:af7f:7ed0%5]) with mapi id 15.20.6863.032; Fri, 13 Oct 2023 08:31:19 +0000 From: =?utf-8?B?Smlhbmp1biBXYW5nICjnjovlu7rlhpsp?= To: "daniel@makrotopia.org" , "linux@fw-web.de" , "helgaas@kernel.org" CC: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "john@phrozen.org" , "ansuelsmth@gmail.com" , "robh@kernel.org" , "kw@linux.com" , "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , "bhelgaas@google.com" , "lpieralisi@kernel.org" , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" , Ryder Lee Subject: Re: [PATCH] PCI: mediatek-gen3: fix PCIe #PERST being de-asserted too early Thread-Topic: [PATCH] PCI: mediatek-gen3: fix PCIe #PERST being de-asserted too early Thread-Index: AQHZ+CmNokdPj2qtYky0HrTu34BsUbBDNouAgAAKi4CABC3egA== Date: Fri, 13 Oct 2023 08:31:19 +0000 Message-ID: <472ebdbe8575b99ac8191e626a87814b88e21c31.camel@mediatek.com> References: <20231010160423.GA977719@bhelgaas> <1E611A63-AD66-4E61-90F9-F1DB41BD6466@fw-web.de> In-Reply-To: <1E611A63-AD66-4E61-90F9-F1DB41BD6466@fw-web.de> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PSAPR03MB5365:EE_|SEZPR03MB6889:EE_ x-ms-office365-filtering-correlation-id: 1ff57d07-7c97-4a98-53f6-08dbcbc6c687 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JOUHPQXX2NDrNvRUKrAwgE8iqD7lBgeCaUQIuV7DNduxA1TKIHuuBk88GfedqdD8PIZi/8WTeg+AxOyZ8zpeSUKncYyCxRdOFpiDWaxj5ZIXP1BmExjez0y05Ye5i6WARp/12jjkjzYxFf+PDi/s1bHCoQIKNfAdkyXyuzVBY+JncA23zmCh/KNDOrEYUHyP7ZNrkBSzIJ6mHMQKAtxxyK6T9SlTvrjYah9I7/Lv5/MfNig+up84xh/Q7HQy6qPXicq4miVeZFmJXhsWz2fps8STTITnQgJ3j7rBM7zc3yZCqNd7ogRDn1puXWnZMFkRbRj8DROBdcf5MdfD/x0smpduuPOriRPywvSn0T2BVBf+rrHzNti/7OFH/b9xPNJQfq/QA2tusKA/FLzpvX9DphI7xyNPpljERO2/8LMq+0uBrB2G+qJszL0mNw1JBGCLr9gsLlu3NooCr2a8UrxxrshWnT6hacEZfuKVwmxOSBQbQCcXVuYNigDVIkvyHznuFQQ3DeyuQHfCkOy0oMQh8tR+0TR0oc7btGS8ueMCxDJIEbLufitq11ltYWbET9PQtUuMlFXHZ+6wgOpjMqNE8UHWa7krosql+hrrbQ7veeX0GI5uiFTGNw0+CWapzeqvSh+ly+s/C6SHHtvqHWHU6X/xLjtf/uZ6O4XXmg3/nI2dEje3G0/rYFpVw3lgiiqm x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PSAPR03MB5365.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(39860400002)(136003)(376002)(346002)(230922051799003)(451199024)(186009)(64100799003)(1800799009)(6512007)(478600001)(6486002)(86362001)(966005)(85182001)(36756003)(6506007)(38070700005)(8676002)(71200400001)(4326008)(8936002)(7416002)(122000001)(38100700002)(66946007)(5660300002)(66476007)(66446008)(64756008)(54906003)(316002)(41300700001)(66556008)(110136005)(91956017)(4001150100001)(2906002)(76116006)(26005)(2616005)(107886003)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Y0pxTlkyaVRzemJHamprcTdIdXc5TTlTVVFQWHE2aStZdmRGbnM2STN2ZmNH?= =?utf-8?B?cDZQVTBCNThUbmhETGhwY1IxaTM3VktEV2QxcmdsREZUSzZGUDdYTXorODl2?= =?utf-8?B?V3FuUWU2MFNWblN4bExTbERPZE5qWDEwZTdtT01yc21aMkJidGJobGE1T3No?= =?utf-8?B?RndrV2toQkh4ZndtdGJRd3lyL0FWeWQrVmhIN3VjbzRGaVpEcEZtOENtd1lF?= =?utf-8?B?MkJCSWRhRWRCQklGckN0VVFDSG1qNTZpeEdzcHRaOFQ2NHpBNE1Mai9TVi9Z?= =?utf-8?B?V0ZIV1pXdG9xOWJRNDNqM09rSjgwdUpmcGlIWmwwMFYvVEx2YmtUOVhrd3kx?= =?utf-8?B?M3hPZWZoZ1B4eUI4NHl2cmZxRmFsR2VkTmU5VTdUR1NIWmx0RExFdWlxWDAz?= =?utf-8?B?WVVkTzlKbUJkZlkwS2pLM2NuS0k5YnhycW9mVkRBd0FsekhFbGE2b3lDT0Jn?= =?utf-8?B?bzBuR1dkUjlVb2RheEtZZXNGYjFMN0lEbUJYY1hzeEhZSytBbkNDK0NJZFdz?= =?utf-8?B?UzR1b3loSFduc1hUbS9leEl1YVkyMTBQbXpJRGQ2NElnNDhkdUJhbVZrTEpI?= =?utf-8?B?VlpPNVdmdjhxTzhIZ2NBcWhvL1RrUzR2eTh5OFh3SXhNWUtRQlQyazdmSnBH?= =?utf-8?B?RTNxemJ5UE85S2cwMlpIN3o2VDFhRUZaL2dra0pRb2h1N0ZIcm8xZzhxcURN?= =?utf-8?B?dkFoTDNHMDJiSVpPRlo1Sm1adkN1czNNRm42UUNIalpDejJ4TjlNREYrZWFr?= =?utf-8?B?a211MG5lZE1neWFJV3BicDdVbHBJa2hjak9NdGdJSmJaenVXdmRPRUtDemo0?= =?utf-8?B?alNkOUd3QUFSVEpWZ09XZkVBSWNVcDUzbmtYd01SbUxnVCtWVEdzK2JvNGFl?= =?utf-8?B?Z2h6UGJDRVNCRU5JVlE3Q3VzSnFpcG82UTBDamJFYUhRNGJ2eVVNVzEvd29r?= =?utf-8?B?RHp3aVdrNEFZTm9FNlUzVUhLMHJpbkQ0U2NiclRvSEpEOUxyekxFK2lEY281?= =?utf-8?B?NzNMcUwyVFdjOWVhTHViZEVaamVPYkVRZXlnWkFpUjRjUFg4aEQ0Y3d5YVg5?= =?utf-8?B?RGNqOTdURVRwUHJqOGRwSVRoYzlKRkhRdGllaUdjQzR1RVl4dkZJaDdERWV2?= =?utf-8?B?TTQ2Q0Y0L1NQYS84eEkzWjF2MHhFS2Fvb3RHV1E0VzU1NUdhR2xxRW0vRjJZ?= =?utf-8?B?L0NRYzliOG45R0tZZlluYXFwS1hsMUNuV0U3QXNGbW80Y1RZUmZmU0tDcEJR?= =?utf-8?B?U1hHV3BmbUczMnBCYkthWG1FajFwZzI0d2d4czhrYUFJNC91SnArUXlEakcz?= =?utf-8?B?UytIYlFnUkgySjgyV1QwOUlmaGtXUHlDanpnVnFGSzZWODY3ZlUrRUVOODBi?= =?utf-8?B?clE1TVdVNmxHWmNWakMrbnFzZWljQ1ZBTmJaTUVuQXJtZjY4dEExQi9BSmJj?= =?utf-8?B?Z0UvcWRXdFUrRXNLekVmSlZ4K1RWQkNDbnY5TE15ZHlSSzJQV3hab1R4aUtl?= =?utf-8?B?Y2tHQ2xSMm91ZkEwTlJ2MDdodW4xVVp1alVreFZXZ2RJL0Q4UlJ4ZzlTZE5X?= =?utf-8?B?Yk9lSjJzbzhrYzU1YVZTK253S2RCTWZ6QnlMZEVjM1hFVHNBSmVIRFhUbjJy?= =?utf-8?B?Qm8xZkRiczBiM1lOS0ZCVFpROTF0NzNiVW5KM3ZaM3pLWWo2andIRkExZTZW?= =?utf-8?B?RVlNWjR3M3g3bS9xSkJzdXdRR3FsSU5IRVdmZklZQUpCT1lYQVZicnVadUpB?= =?utf-8?B?Qlk3dkZqNFNwUCtCZm5McDg1Z1NNLzA5cjhHclRBekJvM0V3NUxzVzVkOHNQ?= =?utf-8?B?QkJJdEF4T0ZZdk9XL0dManRwZzM2d21BcTF5cU55dmt2S0Q4NHBsa2VuTm9i?= =?utf-8?B?alRYTlluUDFTWjczK0RaN1FVWGFJVjVHNGVHRndtYXhTTmsvQ0pIN3doRnNM?= =?utf-8?B?Smg5c2NyUy9QTC85WTlFTElRK3lMSVlFSnJsYlZwSE5WVDRsVGhBZ3B2eEVr?= =?utf-8?B?U01nZFd6MUdvVmVYd3crVjVOTkpqNTBNN3ppcW1meXRhendZZVIwM1NvMlBW?= =?utf-8?B?RHg0eDUwcStVZEQreW5vVEdMT25meUJRSmc2UWVRNnhsWW15dnpaZEZhYy9V?= =?utf-8?B?SjU5Yjl4UDRSbnVEZVpNbWo0RlBlaUM2cHJic3FGWU1wZlgra0srbGVmeWlL?= =?utf-8?B?T1E9PQ==?= Content-ID: <75D311B36D31614190EE559DB0CB1A1C@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PSAPR03MB5365.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ff57d07-7c97-4a98-53f6-08dbcbc6c687 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2023 08:31:19.7725 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BbpqqJRZ2KzfuEQiU8yrO0L/CYV2/CBLBc4zO9hN8kqnXP266Nnlnl5U2yCcp4E76BI3vOQ1DMnxErPE9aP55EO9aOcuI3POkHgVTQmYoPA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR03MB6889 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231013_014136_365232_6125840E X-CRM114-Status: GOOD ( 33.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2023-10-10 at 18:42 +0200, Frank Wunderlich wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > Am 10. Oktober 2023 18:04:23 MESZ schrieb Bjorn Helgaas < > helgaas@kernel.org>: > > On Fri, Oct 06, 2023 at 09:45:58AM +0200, Daniel Golle wrote: > > > The driver for MediaTek gen3 PCIe hosts de-asserts all reset > > > signals at the same time using a single register write operation. > > > Delay the de-assertion of the #PERST signal by 100ms as required > > > by > > > PCIe CEM clause 2.2, some PCIe devices fail to come up otherwise. > > > > > > Signed-off-by: Daniel Golle > > > drivers/pci/controller/pcie-mediatek-gen3.c | 8 +++++++- > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c > > > b/drivers/pci/controller/pcie-mediatek-gen3.c > > > index e0e27645fdf4..ba8cfce03aad 100644 > > > --- a/drivers/pci/controller/pcie-mediatek-gen3.c > > > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c > > > @@ -350,7 +350,13 @@ static int mtk_pcie_startup_port(struct > > > mtk_gen3_pcie *pcie) > > > > > > > I feel like I'm missing something because this patch seems to be > > adding a delay for T_PVPERL, but the comment before the existing > > msleep() claims *it* is the T_PVPERL delay: > > > > * Described in PCIe CEM specification sections 2.2 (PERST# > > Signal) > > * and 2.2.1 (Initial Power-Up (G3 to S0)). > > * The deassertion of PERST# should be delayed 100ms > > (TPVPERL) > > * for the power and clock to become stable. > > > > > msleep(100); > > > > > > /* De-assert reset signals */ > > > - val &= ~(PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB | > > > PCIE_PE_RSTB); > > > + val &= ~(PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB); > > > + writel_relaxed(val, pcie->base + PCIE_RST_CTRL_REG); > > > + > > > + msleep(100); > > > > > > > So I'm confused about these two sleeps. Are they for different > > parameters? > > > > T_PVPERL is defined from "Power stable to PERST# inactive". Do we > > have any actual indication of when to start that delay, i.e., do we > > have a clue about when power became stable? > > > > > + /* De-assert PERST# signals */ > > > + val &= ~(PCIE_PE_RSTB); > > > writel_relaxed(val, pcie->base + PCIE_RST_CTRL_REG); > > > > > > /* Check if the link is up or not */ > > > -- > > > 2.42.0 > > > linux-arm-kernel mailing list > > > linux-arm-kernel@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > Hi > > Seems it is same as the patch i've sent some time ago and which was > rejected because of the additional delay... > > https://patchwork.kernel.org/project/linux-mediatek/patch/20230402131347.99268-1-linux@fw-web.de/ > > Or am i wrong? > regards Frank Hi Daniel, Did you found this issue on MT7986(BPI-R3) or other platforms? Can you share the PCIe device model that failed to link up? Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel