* [PATCH 1/6] crypto: gemin: Fix error check for dma_map_sg [not found] <20220825072421.29020-1-jinpu.wang@ionos.com> @ 2022-08-25 7:24 ` Jack Wang 2022-09-02 10:13 ` Herbert Xu 2022-08-25 7:24 ` [PATCH 5/6] crypto: allwinner: Fix dma_map_sg error check Jack Wang 1 sibling, 1 reply; 5+ messages in thread From: Jack Wang @ 2022-08-25 7:24 UTC (permalink / raw) To: herbert, linux-crypto Cc: Corentin Labbe, Hans Ulli Kroll, Linus Walleij, David S. Miller, linux-arm-kernel, linux-kernel dma_map_sg return 0 on error. Cc: Corentin Labbe <clabbe@baylibre.com> Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: linux-crypto@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Fixes: 46c5338db7bd ("crypto: sl3516 - Add sl3516 crypto engine") Signed-off-by: Jack Wang <jinpu.wang@ionos.com> --- drivers/crypto/gemini/sl3516-ce-cipher.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/gemini/sl3516-ce-cipher.c b/drivers/crypto/gemini/sl3516-ce-cipher.c index 14d0d83d388d..34fea8aa91b6 100644 --- a/drivers/crypto/gemini/sl3516-ce-cipher.c +++ b/drivers/crypto/gemini/sl3516-ce-cipher.c @@ -149,7 +149,7 @@ static int sl3516_ce_cipher(struct skcipher_request *areq) if (areq->src == areq->dst) { nr_sgs = dma_map_sg(ce->dev, areq->src, sg_nents(areq->src), DMA_BIDIRECTIONAL); - if (nr_sgs <= 0 || nr_sgs > MAXDESC / 2) { + if (!nr_sgs || nr_sgs > MAXDESC / 2) { dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs); err = -EINVAL; goto theend; @@ -158,14 +158,14 @@ static int sl3516_ce_cipher(struct skcipher_request *areq) } else { nr_sgs = dma_map_sg(ce->dev, areq->src, sg_nents(areq->src), DMA_TO_DEVICE); - if (nr_sgs <= 0 || nr_sgs > MAXDESC / 2) { + if (!nr_sgs || nr_sgs > MAXDESC / 2) { dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs); err = -EINVAL; goto theend; } nr_sgd = dma_map_sg(ce->dev, areq->dst, sg_nents(areq->dst), DMA_FROM_DEVICE); - if (nr_sgd <= 0 || nr_sgd > MAXDESC) { + if (!nr_sgd || nr_sgd > MAXDESC) { dev_err(ce->dev, "Invalid sg number %d\n", nr_sgd); err = -EINVAL; goto theend_sgs; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/6] crypto: gemin: Fix error check for dma_map_sg 2022-08-25 7:24 ` [PATCH 1/6] crypto: gemin: Fix error check for dma_map_sg Jack Wang @ 2022-09-02 10:13 ` Herbert Xu 0 siblings, 0 replies; 5+ messages in thread From: Herbert Xu @ 2022-09-02 10:13 UTC (permalink / raw) To: Jack Wang Cc: linux-crypto, Corentin Labbe, Hans Ulli Kroll, Linus Walleij, David S. Miller, linux-arm-kernel, linux-kernel On Thu, Aug 25, 2022 at 09:24:16AM +0200, Jack Wang wrote: > dma_map_sg return 0 on error. > > Cc: Corentin Labbe <clabbe@baylibre.com> > Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: linux-crypto@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Fixes: 46c5338db7bd ("crypto: sl3516 - Add sl3516 crypto engine") > Signed-off-by: Jack Wang <jinpu.wang@ionos.com> > --- > drivers/crypto/gemini/sl3516-ce-cipher.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/gemini/sl3516-ce-cipher.c b/drivers/crypto/gemini/sl3516-ce-cipher.c > index 14d0d83d388d..34fea8aa91b6 100644 > --- a/drivers/crypto/gemini/sl3516-ce-cipher.c > +++ b/drivers/crypto/gemini/sl3516-ce-cipher.c > @@ -149,7 +149,7 @@ static int sl3516_ce_cipher(struct skcipher_request *areq) > if (areq->src == areq->dst) { > nr_sgs = dma_map_sg(ce->dev, areq->src, sg_nents(areq->src), > DMA_BIDIRECTIONAL); > - if (nr_sgs <= 0 || nr_sgs > MAXDESC / 2) { > + if (!nr_sgs || nr_sgs > MAXDESC / 2) { > dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs); > err = -EINVAL; > goto theend; The original code is correct and this patch is arguably making it less robust. So I'll drop this particular patch. Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 5/6] crypto: allwinner: Fix dma_map_sg error check [not found] <20220825072421.29020-1-jinpu.wang@ionos.com> 2022-08-25 7:24 ` [PATCH 1/6] crypto: gemin: Fix error check for dma_map_sg Jack Wang @ 2022-08-25 7:24 ` Jack Wang 2022-08-25 20:36 ` Jernej Škrabec 2022-09-02 10:18 ` Herbert Xu 1 sibling, 2 replies; 5+ messages in thread From: Jack Wang @ 2022-08-25 7:24 UTC (permalink / raw) To: herbert, linux-crypto Cc: Corentin Labbe, David S. Miller, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Dan Carpenter, Minghao Chi, Peng Wu, Alexey Khoroshilov, linux-arm-kernel, linux-sunxi, linux-kernel dma_map_sg return 0 on error. Cc: Corentin Labbe <clabbe.montjoie@gmail.com> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: Chen-Yu Tsai <wens@csie.org> Cc: Jernej Skrabec <jernej.skrabec@gmail.com> Cc: Samuel Holland <samuel@sholland.org> Cc: Dan Carpenter <dan.carpenter@oracle.com> Cc: Minghao Chi <chi.minghao@zte.com.cn> Cc: Peng Wu <wupeng58@huawei.com> Cc: Alexey Khoroshilov <khoroshilov@ispras.ru> Cc: linux-crypto@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-sunxi@lists.linux.dev Cc: linux-kernel@vger.kernel.org Fixes: 06f751b61329 ("crypto: allwinner - Add sun8i-ce Crypto Engine") Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms") Signed-off-by: Jack Wang <jinpu.wang@ionos.com> --- drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 6 +++--- drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c | 2 +- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 4 ++-- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c index 74b4e910a38d..be7f46faef7e 100644 --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c @@ -208,7 +208,7 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine *engine, void *async_req if (areq->src == areq->dst) { nr_sgs = dma_map_sg(ce->dev, areq->src, ns, DMA_BIDIRECTIONAL); - if (nr_sgs <= 0 || nr_sgs > MAX_SG) { + if (!nr_sgs || nr_sgs > MAX_SG) { dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs); err = -EINVAL; goto theend_iv; @@ -216,13 +216,13 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine *engine, void *async_req nr_sgd = nr_sgs; } else { nr_sgs = dma_map_sg(ce->dev, areq->src, ns, DMA_TO_DEVICE); - if (nr_sgs <= 0 || nr_sgs > MAX_SG) { + if (!nr_sgs || nr_sgs > MAX_SG) { dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs); err = -EINVAL; goto theend_iv; } nr_sgd = dma_map_sg(ce->dev, areq->dst, nd, DMA_FROM_DEVICE); - if (nr_sgd <= 0 || nr_sgd > MAX_SG) { + if (!nr_sgd || nr_sgd > MAX_SG) { dev_err(ce->dev, "Invalid sg number %d\n", nr_sgd); err = -EINVAL; goto theend_sgs; diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c index 8b5b9b9d04c3..0e6843ec197f 100644 --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c @@ -389,7 +389,7 @@ int sun8i_ce_hash_run(struct crypto_engine *engine, void *breq) cet->t_asym_ctl = 0; nr_sgs = dma_map_sg(ce->dev, areq->src, ns, DMA_TO_DEVICE); - if (nr_sgs <= 0 || nr_sgs > MAX_SG) { + if (!nr_sgs || nr_sgs > MAX_SG) { dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs); err = -EINVAL; goto theend; diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c index 910d6751644c..fdcc98cdecaa 100644 --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c @@ -232,13 +232,13 @@ static int sun8i_ss_cipher(struct skcipher_request *areq) nr_sgd = nr_sgs; } else { nr_sgs = dma_map_sg(ss->dev, areq->src, nsgs, DMA_TO_DEVICE); - if (nr_sgs <= 0 || nr_sgs > 8) { + if (!nr_sgs || nr_sgs > 8) { dev_err(ss->dev, "Invalid sg number %d\n", nr_sgs); err = -EINVAL; goto theend_iv; } nr_sgd = dma_map_sg(ss->dev, areq->dst, nsgd, DMA_FROM_DEVICE); - if (nr_sgd <= 0 || nr_sgd > 8) { + if (!nr_sgd || nr_sgd > 8) { dev_err(ss->dev, "Invalid sg number %d\n", nr_sgd); err = -EINVAL; goto theend_sgs; diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c index 36a82b22953c..fcb8c41cc957 100644 --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c @@ -527,7 +527,7 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq) rctx->method = ss->variant->alg_hash[algt->ss_algo_id]; nr_sgs = dma_map_sg(ss->dev, areq->src, sg_nents(areq->src), DMA_TO_DEVICE); - if (nr_sgs <= 0 || nr_sgs > MAX_SG) { + if (!nr_sgs || nr_sgs > MAX_SG) { dev_err(ss->dev, "Invalid sg number %d\n", nr_sgs); err = -EINVAL; goto theend; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 5/6] crypto: allwinner: Fix dma_map_sg error check 2022-08-25 7:24 ` [PATCH 5/6] crypto: allwinner: Fix dma_map_sg error check Jack Wang @ 2022-08-25 20:36 ` Jernej Škrabec 2022-09-02 10:18 ` Herbert Xu 1 sibling, 0 replies; 5+ messages in thread From: Jernej Škrabec @ 2022-08-25 20:36 UTC (permalink / raw) To: herbert, linux-crypto, Jack Wang Cc: Corentin Labbe, David S. Miller, Chen-Yu Tsai, Samuel Holland, Dan Carpenter, Minghao Chi, Peng Wu, Alexey Khoroshilov, linux-arm-kernel, linux-sunxi, linux-kernel Dne četrtek, 25. avgust 2022 ob 09:24:20 CEST je Jack Wang napisal(a): > dma_map_sg return 0 on error. > > Cc: Corentin Labbe <clabbe.montjoie@gmail.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Jernej Skrabec <jernej.skrabec@gmail.com> > Cc: Samuel Holland <samuel@sholland.org> > Cc: Dan Carpenter <dan.carpenter@oracle.com> > Cc: Minghao Chi <chi.minghao@zte.com.cn> > Cc: Peng Wu <wupeng58@huawei.com> > Cc: Alexey Khoroshilov <khoroshilov@ispras.ru> > Cc: linux-crypto@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-sunxi@lists.linux.dev > Cc: linux-kernel@vger.kernel.org > Fixes: 06f751b61329 ("crypto: allwinner - Add sun8i-ce Crypto Engine") > Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms") > Signed-off-by: Jack Wang <jinpu.wang@ionos.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 6 +++--- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c | 2 +- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 4 ++-- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c > b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c index > 74b4e910a38d..be7f46faef7e 100644 > --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c > +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c > @@ -208,7 +208,7 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine > *engine, void *async_req > > if (areq->src == areq->dst) { > nr_sgs = dma_map_sg(ce->dev, areq->src, ns, DMA_BIDIRECTIONAL); > - if (nr_sgs <= 0 || nr_sgs > MAX_SG) { > + if (!nr_sgs || nr_sgs > MAX_SG) { > dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs); > err = -EINVAL; > goto theend_iv; > @@ -216,13 +216,13 @@ static int sun8i_ce_cipher_prepare(struct > crypto_engine *engine, void *async_req nr_sgd = nr_sgs; > } else { > nr_sgs = dma_map_sg(ce->dev, areq->src, ns, DMA_TO_DEVICE); > - if (nr_sgs <= 0 || nr_sgs > MAX_SG) { > + if (!nr_sgs || nr_sgs > MAX_SG) { > dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs); > err = -EINVAL; > goto theend_iv; > } > nr_sgd = dma_map_sg(ce->dev, areq->dst, nd, DMA_FROM_DEVICE); > - if (nr_sgd <= 0 || nr_sgd > MAX_SG) { > + if (!nr_sgd || nr_sgd > MAX_SG) { > dev_err(ce->dev, "Invalid sg number %d\n", nr_sgd); > err = -EINVAL; > goto theend_sgs; > diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c > b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c index > 8b5b9b9d04c3..0e6843ec197f 100644 > --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c > +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c > @@ -389,7 +389,7 @@ int sun8i_ce_hash_run(struct crypto_engine *engine, void > *breq) cet->t_asym_ctl = 0; > > nr_sgs = dma_map_sg(ce->dev, areq->src, ns, DMA_TO_DEVICE); > - if (nr_sgs <= 0 || nr_sgs > MAX_SG) { > + if (!nr_sgs || nr_sgs > MAX_SG) { > dev_err(ce->dev, "Invalid sg number %d\n", nr_sgs); > err = -EINVAL; > goto theend; > diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c > b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c index > 910d6751644c..fdcc98cdecaa 100644 > --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c > +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c > @@ -232,13 +232,13 @@ static int sun8i_ss_cipher(struct skcipher_request > *areq) nr_sgd = nr_sgs; > } else { > nr_sgs = dma_map_sg(ss->dev, areq->src, nsgs, DMA_TO_DEVICE); > - if (nr_sgs <= 0 || nr_sgs > 8) { > + if (!nr_sgs || nr_sgs > 8) { > dev_err(ss->dev, "Invalid sg number %d\n", nr_sgs); > err = -EINVAL; > goto theend_iv; > } > nr_sgd = dma_map_sg(ss->dev, areq->dst, nsgd, DMA_FROM_DEVICE); > - if (nr_sgd <= 0 || nr_sgd > 8) { > + if (!nr_sgd || nr_sgd > 8) { > dev_err(ss->dev, "Invalid sg number %d\n", nr_sgd); > err = -EINVAL; > goto theend_sgs; > diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c > b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c index > 36a82b22953c..fcb8c41cc957 100644 > --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c > +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c > @@ -527,7 +527,7 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void > *breq) rctx->method = ss->variant->alg_hash[algt->ss_algo_id]; > > nr_sgs = dma_map_sg(ss->dev, areq->src, sg_nents(areq->src), > DMA_TO_DEVICE); - if (nr_sgs <= 0 || nr_sgs > MAX_SG) { > + if (!nr_sgs || nr_sgs > MAX_SG) { > dev_err(ss->dev, "Invalid sg number %d\n", nr_sgs); > err = -EINVAL; > goto theend; > -- > 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 5/6] crypto: allwinner: Fix dma_map_sg error check 2022-08-25 7:24 ` [PATCH 5/6] crypto: allwinner: Fix dma_map_sg error check Jack Wang 2022-08-25 20:36 ` Jernej Škrabec @ 2022-09-02 10:18 ` Herbert Xu 1 sibling, 0 replies; 5+ messages in thread From: Herbert Xu @ 2022-09-02 10:18 UTC (permalink / raw) To: Jack Wang Cc: linux-crypto, Corentin Labbe, David S. Miller, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Dan Carpenter, Minghao Chi, Peng Wu, Alexey Khoroshilov, linux-arm-kernel, linux-sunxi, linux-kernel On Thu, Aug 25, 2022 at 09:24:20AM +0200, Jack Wang wrote: > dma_map_sg return 0 on error. > > Cc: Corentin Labbe <clabbe.montjoie@gmail.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Jernej Skrabec <jernej.skrabec@gmail.com> > Cc: Samuel Holland <samuel@sholland.org> > Cc: Dan Carpenter <dan.carpenter@oracle.com> > Cc: Minghao Chi <chi.minghao@zte.com.cn> > Cc: Peng Wu <wupeng58@huawei.com> > Cc: Alexey Khoroshilov <khoroshilov@ispras.ru> > Cc: linux-crypto@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-sunxi@lists.linux.dev > Cc: linux-kernel@vger.kernel.org > Fixes: 06f751b61329 ("crypto: allwinner - Add sun8i-ce Crypto Engine") > Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms") > Signed-off-by: Jack Wang <jinpu.wang@ionos.com> > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 6 +++--- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c | 2 +- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 4 ++-- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c > index 74b4e910a38d..be7f46faef7e 100644 > --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c > +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c > @@ -208,7 +208,7 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine *engine, void *async_req > > if (areq->src == areq->dst) { > nr_sgs = dma_map_sg(ce->dev, areq->src, ns, DMA_BIDIRECTIONAL); > - if (nr_sgs <= 0 || nr_sgs > MAX_SG) { > + if (!nr_sgs || nr_sgs > MAX_SG) { This is also less robust than the original code and I'll be reverting it. Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-02 10:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220825072421.29020-1-jinpu.wang@ionos.com>
2022-08-25 7:24 ` [PATCH 1/6] crypto: gemin: Fix error check for dma_map_sg Jack Wang
2022-09-02 10:13 ` Herbert Xu
2022-08-25 7:24 ` [PATCH 5/6] crypto: allwinner: Fix dma_map_sg error check Jack Wang
2022-08-25 20:36 ` Jernej Škrabec
2022-09-02 10:18 ` Herbert Xu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).