From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@denx.de>, Peng Fan <peng.fan@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC
Date: Mon, 23 May 2022 13:43:36 +0200 [thread overview]
Message-ID: <4742272.31r3eYUQgx@steina-w> (raw)
In-Reply-To: <4df03cc1-59b1-3e99-4f1b-4300688db061@denx.de>
Am Montag, 23. Mai 2022, 13:18:01 CEST schrieb Marek Vasut:
> On 5/23/22 13:08, Alexander Stein wrote:
>
> Hi,
>
> [...]
>
> >> +&snvs {
> >> + snvs-lpgpr {
> >> + compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-
> >
> > lpgpr";
> >
> >> + };
> >> +};
> >> +
> >>
> >> &uart1 {
> >>
> >> pinctrl-names = "default";
> >> pinctrl-0 = <&pinctrl_uart1>;
> >
> > Shouldn't this go into imx8mm.dtsi?
>
> No, not everyone uses this register for boot counter or wants to expose
> it to Linux that way. This is board-specific behavior.
Sure the actual usage of the general purpose registers is very much board-
specific. Nevertheless the DT describes the hardware and there is snvs-lpgpr
in all imx8mm. IMHO there is no harm exposing those GPR unconditionally.
Best regards,
Alexander
>
> (the other SNVS related entries should be in the SoC common file
> however, those are SoC-specific).
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-23 12:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 17:57 [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC Marek Vasut
2022-05-23 11:04 ` Fabio Estevam
2022-05-23 11:08 ` (EXT) " Alexander Stein
2022-05-23 11:18 ` Marek Vasut
2022-05-23 11:43 ` Alexander Stein [this message]
2022-05-23 12:09 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4742272.31r3eYUQgx@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=festevam@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
--cc=peng.fan@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox