From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 411D4ECAAD2 for ; Sat, 27 Aug 2022 11:08:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CJ+nOmCwXcYG4/cL7lo2wHiy9PyQ4aFrRA1Z4idEQlA=; b=SdocmQJv9K0uDm xzbk8MI3x7fyGJTJkcG5VFeAiRSxffjZhY5nuM4lcxI4NQpN4cSs2jiQh7KxNO2P4VIXr4obirzAn f83wxXCk98doVUnSUahiQRwk1Cf5SqYjZLcALW1r9hkIaB/iiDJN9q0t7xMVlY26rEhPjfwiVRTZr SLCyPMEFUf5rLRj2j/lrg5TzhmWUDW+pfazko+SIo8vW/fzPD3hZdO/IycYgnA4lV+1hg3y4QNs5s Du8iclpuBHvJ+uUVMU5R4IzadIPKzc3PxYR7OMXKyPDN5U4MMrrOFS8ZJZG9stahp+VmrY5XKP9Zw CdKw+OVz/8YRPcZ+znoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRtfG-008NEc-0r; Sat, 27 Aug 2022 11:07:46 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRtfC-008NBq-Hf for linux-arm-kernel@lists.infradead.org; Sat, 27 Aug 2022 11:07:44 +0000 Received: by mail-ed1-x530.google.com with SMTP id w20so4845113edd.10 for ; Sat, 27 Aug 2022 04:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=KkLBgHjqLVMK1fwCBUUK4kuHMU4tLcffN+IAMJpgXe8=; b=iZpl5NHEwzGcgFJBKmhpTHZLBNZEpO8w0BHof64cEERIZrF6+Bd+Vxx8nYg++2wVaV j8IoizILxnTbZt1KfTHo3mX2j42E70ofeASh58y3f16tcyPprgEI6gtRtqkRF4rq3Woj lJks/rDU+GKqtjkdhZ6favIWbiBado7MbQyunsRHc6vvnIAbk123KY9MxiDkS2OoaTnQ 5yewCscX4Bhy1hXUkWmd335icJFNuX4pJ5aBqFrfaCdgKGRq2gd+hO/BX2qY2byewzu0 qiRSDPIfzv5b2lM4bxd9NTpwBV866P8HQqprxDsrYNp2WNxg7JZ3rlj1ppoAvcE530yW hp+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=KkLBgHjqLVMK1fwCBUUK4kuHMU4tLcffN+IAMJpgXe8=; b=JzmaIfuqZWUMx38qrOJpupgbKsvGebF1rmSwOFrKrcPjdiFz4DGPZnhT90cGET0yIT WXMLuzsbQ6aSLyECgQy5UuPr5OqB0EVYoQB/VTwFP5Jxj51u7AgBCojQaWb8pGM5ffIj M9NrcXURmPAMOtTDyppui8PP9WRFp/4ACW+NSJRNHfCfpWZ50wtpZYGPFLwk5O5eE3e4 xQ7cK9nfn73Z9TqJl1KCebSjPuOjdgui1en62dG/gb/1Npxz50UpAKi++XNNJbF71993 HQPTiZ5Co5Ze2pIyKTA1zqeeB7jE4tnjQ1D5Idm5zcW3Yqc495N0PtrGChVoAfygjpnU Ub4A== X-Gm-Message-State: ACgBeo0hDmaungipumuobYXhV2cGfkLQzlaFka5AyKDcf14mIgEnbzRh DNu712co/r6GRTUckX0ReHo= X-Google-Smtp-Source: AA6agR79JkqEXhoYIuRUBbhwrFqT1EXnC+yp4Avh6kLZcgbJbvYbPwfxQgOUH7aOk4HPN/63R0no5w== X-Received: by 2002:aa7:d5da:0:b0:448:ec:7b31 with SMTP id d26-20020aa7d5da000000b0044800ec7b31mr4228814eds.193.1661598459413; Sat, 27 Aug 2022 04:07:39 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id uo39-20020a170907cc2700b0073da32b7db0sm1918147ejc.199.2022.08.27.04.07.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Aug 2022 04:07:39 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Yang Yingliang Cc: mturquette@baylibre.com, sboyd@kernel.org, wens@csie.org Subject: Re: [PATCH -next 3/3] clk: sunxi-ng: ccu-sun9i-a80-usb: Use dev_err_probe() helper Date: Sat, 27 Aug 2022 13:07:38 +0200 Message-ID: <4742528.GXAFRqVoOG@jernej-laptop> In-Reply-To: <20220827094151.3323450-3-yangyingliang@huawei.com> References: <20220827094151.3323450-1-yangyingliang@huawei.com> <20220827094151.3323450-3-yangyingliang@huawei.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220827_040742_661300_4CEDE912 X-CRM114-Status: GOOD ( 15.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sobota, 27. avgust 2022 ob 11:41:51 CEST je Yang Yingliang napisal(a): > dev_err() can be replace with dev_err_probe() which will check if error > code is -EPROBE_DEFER. > > Signed-off-by: Yang Yingliang Reviewed-by: Jernej Skrabec Best regards, Jernej > --- > drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c > b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c index 575ae4ccc65f..a0fb0da8f356 > 100644 > --- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c > +++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c > @@ -101,12 +101,9 @@ static int sun9i_a80_usb_clk_probe(struct > platform_device *pdev) return PTR_ERR(reg); > > bus_clk = devm_clk_get(&pdev->dev, "bus"); > - if (IS_ERR(bus_clk)) { > - ret = PTR_ERR(bus_clk); > - if (ret != -EPROBE_DEFER) > - dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret); > - return ret; > - } > + if (IS_ERR(bus_clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk), > + "Couldn't get bus clk\n"); > > /* The bus clock needs to be enabled for us to access the registers */ > ret = clk_prepare_enable(bus_clk); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel