From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Frank Wunderlich <frank-w@public-files.de>,
david@ixit.cz
Cc: Martin Filla <freebsd@sysctl.cz>,
Charalampos Mitrodimas <charmitro@posteo.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
David Heidelberg <david@ixit.cz>
Subject: Re: [PATCH v4 3/4] arm64: dts: rockchip: Use reference PCIe clock generator for BPI-R2-Pro
Date: Tue, 10 Mar 2026 10:05:04 +0100 [thread overview]
Message-ID: <4743255.cEBGB3zze1@phil> (raw)
In-Reply-To: <20260304-rk3568-bri-r2-pro-fix-pcie-v4-3-37abd7ba29d0@ixit.cz>
Am Mittwoch, 4. März 2026, 12:05:29 Mitteleuropäische Normalzeit schrieb David Heidelberg via B4 Relay:
> From: David Heidelberg <david@ixit.cz>
>
> Describe properly PCIe clock, which allow us correct the
> topology (removing the vcc3v3-{minipcie,ngff} dependency on pi6c as
> supply) and adding the clock dependency in the PCIe nodes.
>
> Suggested-by: Heiko Stuebner <heiko@sntech.de>
> Tested-by: Martin Filla <freebsd@sysctl.cz>
> Signed-off-by: David Heidelberg <david@ixit.cz>
I think patches 2+3 could do something like [0],
to actually model the clock-generator as one node.
Heiko
[0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v7.1-armsoc/dts64&id=cfe2d65332eff95ac7308478897760888f957aeb
next prev parent reply other threads:[~2026-03-10 9:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 11:05 [PATCH v4 0/4] Rework BPI-R2-Pro PCIe clock topology David Heidelberg via B4 Relay
2026-03-04 11:05 ` [PATCH v4 1/4] arm64: dts: rockchip: assign pipe clock to rk356x PCIe lanes David Heidelberg via B4 Relay
2026-03-04 13:36 ` Shawn Lin
2026-03-04 11:05 ` [PATCH v4 2/4] arm64: dts: rockchip: Introduce the reference PCIe clk generator for BPI-R2-Pro David Heidelberg via B4 Relay
2026-03-04 11:05 ` [PATCH v4 3/4] arm64: dts: rockchip: Use reference PCIe clock " David Heidelberg via B4 Relay
2026-03-10 9:05 ` Heiko Stuebner [this message]
2026-03-04 11:05 ` [PATCH v4 4/4] arm64: dts: rockchip: Define PCIe clock pinctrl " David Heidelberg via B4 Relay
2026-03-24 19:53 ` (subset) [PATCH v4 0/4] Rework BPI-R2-Pro PCIe clock topology Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4743255.cEBGB3zze1@phil \
--to=heiko@sntech.de \
--cc=charmitro@posteo.net \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=freebsd@sysctl.cz \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox