* [PATCH v2] ARM: at91: cam60: fix incorrect placement of __initdata tag
@ 2013-09-30 15:38 Bartlomiej Zolnierkiewicz
2013-09-30 15:48 ` Nicolas Ferre
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-09-30 15:38 UTC (permalink / raw)
To: linux-arm-kernel
__initdata tag should be placed between the variable name and equal
sign for the variable to be placed in the intended .init.data section.
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
v2:
- use __initdata as it is OK to do it
arch/arm/mach-at91/board-cam60.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-at91/board-cam60.c b/arch/arm/mach-at91/board-cam60.c
index ade948b..ecabbed 100644
--- a/arch/arm/mach-at91/board-cam60.c
+++ b/arch/arm/mach-at91/board-cam60.c
@@ -108,16 +108,14 @@ static struct spi_board_info cam60_spi_devices[] __initdata = {
#endif
};
-
/*
* MACB Ethernet device
*/
-static struct __initdata macb_platform_data cam60_macb_data = {
+static struct macb_platform_data cam60_macb_data __initdata = {
.phy_irq_pin = AT91_PIN_PB5,
.is_rmii = 0,
};
-
/*
* NAND Flash
*/
--
1.8.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2] ARM: at91: cam60: fix incorrect placement of __initdata tag
2013-09-30 15:38 [PATCH v2] ARM: at91: cam60: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
@ 2013-09-30 15:48 ` Nicolas Ferre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2013-09-30 15:48 UTC (permalink / raw)
To: linux-arm-kernel
On 30/09/2013 17:38, Bartlomiej Zolnierkiewicz :
> __initdata tag should be placed between the variable name and equal
> sign for the variable to be placed in the intended .init.data section.
Yes, okay. But please do not mix the removal of white lines with your
modification.
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Anyway, no need to resend it:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> v2:
> - use __initdata as it is OK to do it
>
> arch/arm/mach-at91/board-cam60.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-at91/board-cam60.c b/arch/arm/mach-at91/board-cam60.c
> index ade948b..ecabbed 100644
> --- a/arch/arm/mach-at91/board-cam60.c
> +++ b/arch/arm/mach-at91/board-cam60.c
> @@ -108,16 +108,14 @@ static struct spi_board_info cam60_spi_devices[] __initdata = {
> #endif
> };
>
> -
> /*
> * MACB Ethernet device
> */
> -static struct __initdata macb_platform_data cam60_macb_data = {
> +static struct macb_platform_data cam60_macb_data __initdata = {
> .phy_irq_pin = AT91_PIN_PB5,
> .is_rmii = 0,
> };
>
> -
> /*
> * NAND Flash
> */
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-30 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-30 15:38 [PATCH v2] ARM: at91: cam60: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
2013-09-30 15:48 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox