From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DD90C38A2D for ; Wed, 26 Oct 2022 18:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YRDxpwd4wBHWVBU3Stwn/y5Iy5+AN6g4TMrr0/YdAPg=; b=cgbRLfVFhDNwp7 kGQUjOC1fk2ESiKrSXJc/nvO7Z1fyM5P/FZPzJqjGE1BKEAcqPHQp0HeaAp9yCU6F3+1lH/q3uQkl o8myVFhUUjWI6Zq1rpLckPgtx/V8BUmMbrxzkVunRiBWhYnZqvlubRDQ9cxI2nqSlmHSxHidhwFFm RKwTsxPw6zdeAiVCn9JfWu48iHdaO7p0khZJLJkbrgJoEphgvyNOr7RRN2unQFsvtDJvqHtq210wI t9QesVA6YbI4Xf9z3S19kmks/dNpw40xoehzY0kJhkRQPLTu1Yx1SS4JYRiv6WcvDQzylZct+FRHl uvNIskBa4eoSEHu9+6+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onlGH-00AZWJ-6u; Wed, 26 Oct 2022 18:36:21 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onlGD-00AZTv-4H for linux-arm-kernel@lists.infradead.org; Wed, 26 Oct 2022 18:36:18 +0000 Received: from fabians-envy.localnet ([84.167.206.69]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MNso2-1oPT6s04Pw-00OFWf; Wed, 26 Oct 2022 20:35:58 +0200 From: Fabian Vogt To: Arnd Bergmann , Linus Walleij , Geert Uytterhoeven , Daniel Tang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Davis Subject: Re: [PATCH v2 1/2] ARM: nspire: Use syscon-reboot to handle restart Date: Wed, 26 Oct 2022 20:35:52 +0200 Message-ID: <4750364.GXAFRqVoOG@fabians-envy> In-Reply-To: <20221026161302.5319-2-afd@ti.com> References: <20221026161302.5319-1-afd@ti.com> <20221026161302.5319-2-afd@ti.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:hLePCTnLfGCqdPeOJbHL/d/IYxK0n7hZ4Rjwu0vVpkB6KS8ePho f0YuVo702j3Il5Ygms5NROXe30Zi6C9Lv7dCAJjM5RwqCAf/RbZNKM5Yn1vAuEsyHUdXJm2 X6I/Twr9flRSh+weOGsTIvJRW9/Bq4vnhO/3kv2HPt8fHjZ3h1rIS8zehC6uqQpgv9urJcz cuo6hgoE2i97P31dPR3Eg== X-UI-Out-Filterresults: notjunk:1;V03:K0:d+7iQcA1o5M=:5Lwg2tg18+FQ0mfQop7/yN YZvt44e9rJQezCUlVkL/YW45SKHRYdAeKzbLhC9DHetsRU/WOPClb1eEvTnuDx+0C8MPTNUZ+ 9ZKi5odJtSNrZY9vs559SHwfz+vb8Z0ujxLVm0zjT5s2ME5mUa+P2fuOGLcFwui+Gy/VZGM4P LzFBYNtDR0OFGpc2XJbsrSh+2IPcQbQtPL0gjzrpoKfOmfp+0jowdmhHYJn94OqFu6cc50a/9 QfWdAGdfW3gyVZ73gKTW1tHuaUiJIumQjN2/EdUKvNw4ipIH7pFiPA8wM0a8oAhVdUjXHxAJU JGMQFKFb3bX/ErtKhoZTebyJktGaUdoVmB13rByOaokSd98Y+eZELO0chzu2j0pVbyT/iRZbc ebsaofaSF77QQNinf/QBoj3TvyBoa2K3MQepJgbLfHAVEmLyoAJ2+GLG3GKwatKY8wgcA3QmH 5o3ez/FTTvnYKpXK6hBW9kgyJjJni6U4hpEPxMsvRBsUEDeKQUXl9+NAClu6DqzQ3PM/7nCd+ WINiQE9k7KJZ2R/KxxuZNHEekYjWeirHH4gHzfjgogUk+TykF6TRlDXLl1lLpRfd82fktOeuR EKxB8U8NAonBl+Yg8AGmMtEktpYFrz/1KfNlesFFy5ep71hguM2QEgI++ujVPhAULDCWLv3wV ls6AOaHlcy4uWzt02XrALwaEVcNYWHd0LBH9MA9NSIuQk7u5WnwCeFxEeporvjRgab3q58R3G nizrhfM6TaXlWFLGnG8/HnKaFQyV5b0WLGtd5czrsK0lW0gJ+Fgxe91hi+4PAlivXnLlToqW2 aGhBVAL+bbVzB3YyBvTa+G4VwlWtA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221026_113617_509655_256B7FEF X-CRM114-Status: GOOD ( 20.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Mittwoch, 26. Oktober 2022, 18:13:01 CEST schrieb Andrew Davis: > Writing this bit can be handled by the syscon-reboot driver. Add the > info to DT and remove the machine_desc version. > > Signed-off-by: Andrew Davis > Reviewed-by: Linus Walleij finally got this to run on real HW after reverting to an older .config and refreshing options. Rebooting works fine here. Thanks a lot! Tested-by: Fabian Vogt Reviewed-by: Fabian Vogt > --- > arch/arm/boot/dts/nspire.dtsi | 7 +++++++ > arch/arm/mach-nspire/Kconfig | 2 ++ > arch/arm/mach-nspire/mmio.h | 3 --- > arch/arm/mach-nspire/nspire.c | 10 ---------- > 4 files changed, 9 insertions(+), 13 deletions(-) > > diff --git a/arch/arm/boot/dts/nspire.dtsi b/arch/arm/boot/dts/nspire.dtsi > index bb240e6a3a6f..6357b803521e 100644 > --- a/arch/arm/boot/dts/nspire.dtsi > +++ b/arch/arm/boot/dts/nspire.dtsi > @@ -172,7 +172,14 @@ rtc: rtc@90090000 { > }; > > misc: misc@900a0000 { > + compatible = "syscon", "simple-mfd"; > reg = <0x900a0000 0x1000>; > + > + reboot { > + compatible = "syscon-reboot"; > + offset = <0x08>; > + value = <0x02>; > + }; > }; > > pwr: pwr@900b0000 { > diff --git a/arch/arm/mach-nspire/Kconfig b/arch/arm/mach-nspire/Kconfig > index b7a3871876d7..0ffdcaca1e6b 100644 > --- a/arch/arm/mach-nspire/Kconfig > +++ b/arch/arm/mach-nspire/Kconfig > @@ -9,5 +9,7 @@ config ARCH_NSPIRE > select ARM_VIC > select ARM_TIMER_SP804 > select NSPIRE_TIMER > + select POWER_RESET > + select POWER_RESET_SYSCON > help > This enables support for systems using the TI-NSPIRE CPU > diff --git a/arch/arm/mach-nspire/mmio.h b/arch/arm/mach-nspire/mmio.h > index 48e32f13f311..2ce0656139ec 100644 > --- a/arch/arm/mach-nspire/mmio.h > +++ b/arch/arm/mach-nspire/mmio.h > @@ -5,9 +5,6 @@ > * Copyright (C) 2013 Daniel Tang > */ > > -#define NSPIRE_MISC_PHYS_BASE 0x900A0000 > -#define NSPIRE_MISC_HWRESET 0x08 > - > #define NSPIRE_PWR_PHYS_BASE 0x900B0000 > #define NSPIRE_PWR_VIRT_BASE 0xFEEB0000 > #define NSPIRE_PWR_BUS_DISABLE1 0x18 > diff --git a/arch/arm/mach-nspire/nspire.c b/arch/arm/mach-nspire/nspire.c > index 2d4abb0288b9..1e13337972dd 100644 > --- a/arch/arm/mach-nspire/nspire.c > +++ b/arch/arm/mach-nspire/nspire.c > @@ -27,16 +27,6 @@ static const char *const nspire_dt_match[] __initconst = { > NULL, > }; > > -static void nspire_restart(enum reboot_mode mode, const char *cmd) > -{ > - void __iomem *base = ioremap(NSPIRE_MISC_PHYS_BASE, SZ_4K); > - if (!base) > - return; > - > - writel(2, base + NSPIRE_MISC_HWRESET); > -} > - > DT_MACHINE_START(NSPIRE, "TI-NSPIRE") > .dt_compat = nspire_dt_match, > - .restart = nspire_restart, > MACHINE_END _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel