From: Krzysztof Kozlowski <krzk@kernel.org>
To: Peter Chen <peter.chen@cixtech.com>,
soc@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org,
arnd@arndb.de, jassisinghbrar@gmail.com
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com,
maz@kernel.org, kajetan.puchalski@arm.com,
Guomin Chen <Guomin.Chen@cixtech.com>,
Lihua Liu <Lihua.Liu@cixtech.com>
Subject: Re: [PATCH v6 05/10] dt-bindings: mailbox: add cix,sky1-mbox
Date: Wed, 16 Apr 2025 08:34:32 +0200 [thread overview]
Message-ID: <47583cb5-d211-407c-8b7e-d79934a90b28@kernel.org> (raw)
In-Reply-To: <20250415072724.3565533-6-peter.chen@cixtech.com>
On 15/04/2025 09:27, Peter Chen wrote:
> From: Guomin Chen <Guomin.Chen@cixtech.com>
>
> Add a dt-binding for the Cixtech Mailbox Controller.
>
> Reviewed-by: Peter Chen <peter.chen@cixtech.com>
> Signed-off-by: Lihua Liu <Lihua.Liu@cixtech.com>
> Signed-off-by: Guomin Chen <Guomin.Chen@cixtech.com>
You send patches to soc@ AFTER you get community review, not during.
Look again at document I linked some time ago. New files are not sent to
review to soc@.
> ---
> Changes for v3:
> - Replace the direction attribute of the mailbox with the strings "rx" and "tx"
>
> .../bindings/mailbox/cix,sky1-mbox.yaml | 71 +++++++++++++++++++
> 1 file changed, 71 insertions(+)
That's a completely new file? If you add new patches, mention in the
changelog.
And keep the changelog from the other patchset. What changed here? were
my comments resolved or not?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-16 6:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 7:27 [PATCH v6 00/10] arm64: Introduce CIX P1 (SKY1) SoC Peter Chen
2025-04-15 7:27 ` [PATCH v6 01/10] dt-bindings: vendor-prefixes: Add CIX Technology Group Co., Ltd Peter Chen
2025-04-15 7:27 ` [PATCH v6 02/10] dt-bindings: arm: add CIX P1 (SKY1) SoC Peter Chen
2025-04-15 7:27 ` [PATCH v6 03/10] arm64: Kconfig: add ARCH_CIX for cix silicons Peter Chen
2025-04-15 7:27 ` [PATCH v6 04/10] arm64: defconfig: Enable CIX SoC Peter Chen
2025-04-15 7:27 ` [PATCH v6 05/10] dt-bindings: mailbox: add cix,sky1-mbox Peter Chen
2025-04-16 6:34 ` Krzysztof Kozlowski [this message]
2025-04-16 8:48 ` Peter Chen
2025-04-17 6:16 ` Krzysztof Kozlowski
2025-04-15 7:27 ` [PATCH v6 06/10] mailbox: add CIX mailbox driver Peter Chen
2025-04-15 18:39 ` Sudeep Holla
2025-04-16 1:04 ` Peter Chen
2025-04-22 1:33 ` Peter Chen
2025-04-15 7:27 ` [PATCH v6 07/10] arm64: defconfig: enable CIX mailbox Peter Chen
2025-04-16 6:35 ` Krzysztof Kozlowski
2025-04-16 8:56 ` Peter Chen
2025-04-15 7:27 ` [PATCH v6 08/10] dt-bindings: clock: cix: Add CIX sky1 scmi clock id Peter Chen
2025-04-16 6:35 ` Krzysztof Kozlowski
2025-04-16 6:38 ` Krzysztof Kozlowski
2025-04-16 8:26 ` Peter Chen
2025-04-16 8:29 ` Krzysztof Kozlowski
2025-04-16 8:55 ` Peter Chen
2025-04-15 7:27 ` [PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts support Peter Chen
2025-04-15 13:48 ` Kajetan Puchalski
2025-04-16 1:13 ` Peter Chen
2025-04-17 6:18 ` Krzysztof Kozlowski
2025-04-17 6:37 ` Peter Chen
2025-04-17 6:58 ` Krzysztof Kozlowski
2025-04-17 8:24 ` Peter Chen
2025-04-17 6:19 ` Krzysztof Kozlowski
2025-04-17 6:38 ` Peter Chen
2025-04-15 7:27 ` [PATCH v6 10/10] MAINTAINERS: Add CIX SoC maintainer entry Peter Chen
2025-04-24 9:11 ` [PATCH v6 00/10] arm64: Introduce CIX P1 (SKY1) SoC Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47583cb5-d211-407c-8b7e-d79934a90b28@kernel.org \
--to=krzk@kernel.org \
--cc=Guomin.Chen@cixtech.com \
--cc=Lihua.Liu@cixtech.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=kajetan.puchalski@arm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
--cc=soc@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).