From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED3BC636C8 for ; Thu, 15 Jul 2021 18:31:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAEC5613BB for ; Thu, 15 Jul 2021 18:31:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAEC5613BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=unAXIRRN1/ZsTxDS2F8LcLmJShxDI7jZQAdpbe1hPHo=; b=WIZ/KJzCw4SK+R Inso7/HaRV69Vo0ipouFfvu1aqgBPT0fAX3wmLTvspMznSwmYW2UJlO9DHiNbpTCulYpU8iFcwrMk LYvKotDw4Wywp5fFd4SMPcFuL8bZ8/nKNmwu/MjV2YvrU5BbA8euSuVd6Ky8sKs14UUQZ0A6HuTDl +sgSQlBepyDV/WRh1ld7hAb9Vj+Ur+rDeDA1HYtatnHJjmX4tOLjqfnwA570Yjd4NWxqp4mKffR+P GRSRFF2C91JH0HhIzilXMw3j3Ya4ks2DWH41unWkGAtTAOdLMv9hq2msINWneZsielRlbbYy7PWiA 3qoubFxGqztCvjukO1ZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m467T-001yVt-QT; Thu, 15 Jul 2021 18:29:59 +0000 Received: from mga07.intel.com ([134.134.136.100]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m467Q-001yVL-9B for linux-arm-kernel@lists.infradead.org; Thu, 15 Jul 2021 18:29:57 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10046"; a="274433649" X-IronPort-AV: E=Sophos;i="5.84,243,1620716400"; d="scan'208";a="274433649" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2021 11:29:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,243,1620716400"; d="scan'208";a="413725599" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga003.jf.intel.com with ESMTP; 15 Jul 2021 11:29:47 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 15 Jul 2021 11:29:47 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 15 Jul 2021 11:29:46 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2242.010; Thu, 15 Jul 2021 11:29:46 -0700 From: "Luck, Tony" To: "Williams, Dan J" , "Winiarska, Iwona" CC: "linux-kernel@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "corbet@lwn.net" , "jae.hyun.yoo@linux.intel.com" , "Lutomirski, Andy" , "linux-hwmon@vger.kernel.org" , "andrew@aj.id.au" , "mchehab@kernel.org" , "jdelvare@suse.com" , "mingo@redhat.com" , "bp@alien8.de" , "devicetree@vger.kernel.org" , "tglx@linutronix.de" , "linux@roeck-us.net" , "linux-doc@vger.kernel.org" , "linux-aspeed@lists.ozlabs.org" , "robh+dt@kernel.org" , "yazen.ghannam@amd.com" , "gregkh@linuxfoundation.org" , "joel@jms.id.au" , "linux-arm-kernel@lists.infradead.org" , "andriy.shevchenko@linux.intel.com" , "x86@kernel.org" , "pierre-louis.bossart@linux.intel.com" Subject: RE: [PATCH 01/14] x86/cpu: Move intel-family to arch-independent headers Thread-Topic: [PATCH 01/14] x86/cpu: Move intel-family to arch-independent headers Thread-Index: AQHXd2pbzZadhIqqdEqWEklQPBy5PKtDKGuAgAGQOwCAABg7gP//jU5Q Date: Thu, 15 Jul 2021 18:29:46 +0000 Message-ID: <475c3f70da104d4bac6a902cc41e48d8@intel.com> References: <20210712220447.957418-1-iwona.winiarska@intel.com> <20210712220447.957418-2-iwona.winiarska@intel.com> <32c71687f11fb418dafa45ecf15f7c6b50dd0397.camel@intel.com> <218ef97a68491e88d8012799385ee244544a157a.camel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.1.200.100] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210715_112956_440428_24C80223 X-CRM114-Status: UNSURE ( 9.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Having 2 potential places for the same definition causes a small > ongoing maintenance / review burden, so I vote moving the file rather > than leaving a place holder, but it's ultimately an x86 maintainer > call. I thought the patch kept the old file as a stub with just one line: #include to grab the real data from the new location. So the information isn't in two places. $ git grep -l asm/intel-family.h | wc -l 53 Dang. We seem to love spraying model specific code all over the place :-( My opinion is to post as Iwona wrote it ... but be prepared for the maintainers to say "It's only 53 files ... just fix them all" -Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel