From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Tianling Shen <cnsztl@gmail.com>,
Peter Geis <pgwipeout@gmail.com>, Andy Yan <andyshrk@163.com>,
Chris Morgan <macromorgan@hotmail.com>,
Brian Norris <briannorris@chromium.org>,
Andrew Lunn <andrew@lunn.ch>, Shawn Guo <shawnguo@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Maya Matuszczyk <maccraft123mc@gmail.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
Sascha Hauer <s.hauer@pengutronix.de>,
Vasily Khoruzhick <anarsoul@gmail.com>,
Tianling Shen <cnsztl@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: Add Lunzn Fastrhino R66S
Date: Tue, 02 May 2023 11:30:26 +0200 [thread overview]
Message-ID: <4763863.6tgchFWduM@diego> (raw)
In-Reply-To: <5782501.VdNmn5OnKV@diego>
Am Dienstag, 2. Mai 2023, 11:28:22 CEST schrieb Heiko Stübner:
> Hi,
>
> Am Freitag, 28. April 2023, 03:37:37 CEST schrieb Tianling Shen:
> > Lunzn Fastrhino R66S is a high-performance mini router.
> >
> > Specification:
> > - Rockchip RK3568
> > - 1/2GB LPDDR4 RAM
> > - SD card slot
> > - M.2 Connector
> > - 2x USB 3.0 Port
> > - 2x 2500 Base-T (PCIe, r8125b)
> > - 12v DC Jack
> >
> > Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> > ---
> > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > .../dts/rockchip/rk3568-fastrhino-r66s.dts | 27 +
> > .../dts/rockchip/rk3568-fastrhino-r66s.dtsi | 507 ++++++++++++++++++
> > 3 files changed, 535 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dts
> > create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> > index 2d585bbb8f3a..15089a78555a 100644
> > --- a/arch/arm64/boot/dts/rockchip/Makefile
> > +++ b/arch/arm64/boot/dts/rockchip/Makefile
> > @@ -85,6 +85,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-lubancat-2.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-nanopi-r5c.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-nanopi-r5s.dtb
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dts b/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dts
> > new file mode 100644
> > index 000000000000..fc9e1bdab128
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dts
> > @@ -0,0 +1,27 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> > +
> > +#include "rk3568-fastrhino-r66s.dtsi"
> > +
> > +/ {
> > + model = "Lunzn FastRhino R66S";
> > + compatible = "lunzn,fastrhino-r66s", "rockchip,rk3568";
> > +
> > + aliases {
> > + mmc0 = &sdmmc0;
> > + };
> > +};
> > +
> > +&sdmmc0 {
>
> that whole element seems to be duplicated from rk3568-fastrhino-r66s.dtsi?
> I don't think we need to declare that twice. If something really changes,
> please only declare the new properties when going from dtsi to dts.
Looking at patch3 I see the explanation :-) .
The base dtsi should not contain the &sdmmc0 node, and it should
only be included in the rk3568-fastrhino-r66s.dts, right?
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-02 9:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 1:37 [PATCH 1/3] dt-bindings: Add doc for Fastrhino R66S / R68S Tianling Shen
2023-04-28 1:37 ` [PATCH 2/3] arm64: dts: rockchip: Add Lunzn Fastrhino R66S Tianling Shen
2023-04-28 13:34 ` Krzysztof Kozlowski
2023-04-29 1:29 ` Tianling Shen
2023-05-02 9:28 ` Heiko Stübner
2023-05-02 9:30 ` Heiko Stübner [this message]
2023-05-02 9:53 ` Tianling Shen
2023-05-02 10:04 ` Heiko Stübner
2023-04-28 1:37 ` [PATCH 3/3] arm64: dts: rockchip: Add Lunzn Fastrhino R68S Tianling Shen
2023-04-28 13:33 ` [PATCH 1/3] dt-bindings: Add doc for Fastrhino R66S / R68S Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4763863.6tgchFWduM@diego \
--to=heiko@sntech.de \
--cc=anarsoul@gmail.com \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=andyshrk@163.com \
--cc=briannorris@chromium.org \
--cc=cnsztl@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.reichel@collabora.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).