From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0F56C77B73 for ; Tue, 2 May 2023 09:31:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oHS8HPDBPrZWezVD7ZWYeOUQCjPmkeefaOWAiPVQN1I=; b=UQ6akqJhLr/+7t Hb5uoLA1f/K+26Gd9ZHNVUAX2cn9qoHalZgSqzCl0UVFbhKnVNR/dGQBjYRhEiTqZwWV2l9fGw5xm Wa3JY//kT5SYVMtsnsi2XeVxfNXfdyqOwivnug0tXgCUulMf/8BlzxDi4Y+O/gN1HYTPNHJ2Ar+Qz M5EMVt3b96Wn19PTVecapKhdtiH5r+Wxm+Olv/iDjOfSCWV+BUHoH1im1jSjKBJ5If0U8Yy5za7QY LCDNRnTfE42R2+IsVfDNTDWZQYkXhEur02jv51Wmx1hKiE51s1QwZmbIAEyyYPDGNhmqVdaQohbkU cbz2B7HLNQs/S+lk0RTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ptmLH-000mHS-09; Tue, 02 May 2023 09:30:39 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ptmLE-000mGT-36; Tue, 02 May 2023 09:30:38 +0000 Received: from ip4d1634d3.dynamic.kabel-deutschland.de ([77.22.52.211] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ptmL5-0006gj-Ni; Tue, 02 May 2023 11:30:27 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Rob Herring , Krzysztof Kozlowski , Jagan Teki , Tianling Shen , Peter Geis , Andy Yan , Chris Morgan , Brian Norris , Andrew Lunn , Shawn Guo , Bjorn Andersson , Sebastian Reichel , Maya Matuszczyk , Michael Riesch , Sascha Hauer , Vasily Khoruzhick , Tianling Shen Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] arm64: dts: rockchip: Add Lunzn Fastrhino R66S Date: Tue, 02 May 2023 11:30:26 +0200 Message-ID: <4763863.6tgchFWduM@diego> In-Reply-To: <5782501.VdNmn5OnKV@diego> References: <20230428013738.30735-1-cnsztl@gmail.com> <20230428013738.30735-2-cnsztl@gmail.com> <5782501.VdNmn5OnKV@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230502_023036_996724_44F2F125 X-CRM114-Status: GOOD ( 20.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 2. Mai 2023, 11:28:22 CEST schrieb Heiko St=FCbner: > Hi, > = > Am Freitag, 28. April 2023, 03:37:37 CEST schrieb Tianling Shen: > > Lunzn Fastrhino R66S is a high-performance mini router. > > = > > Specification: > > - Rockchip RK3568 > > - 1/2GB LPDDR4 RAM > > - SD card slot > > - M.2 Connector > > - 2x USB 3.0 Port > > - 2x 2500 Base-T (PCIe, r8125b) > > - 12v DC Jack > > = > > Signed-off-by: Tianling Shen > > --- > > arch/arm64/boot/dts/rockchip/Makefile | 1 + > > .../dts/rockchip/rk3568-fastrhino-r66s.dts | 27 + > > .../dts/rockchip/rk3568-fastrhino-r66s.dtsi | 507 ++++++++++++++++++ > > 3 files changed, 535 insertions(+) > > create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.= dts > > create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.= dtsi > > = > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dt= s/rockchip/Makefile > > index 2d585bbb8f3a..15089a78555a 100644 > > --- a/arch/arm64/boot/dts/rockchip/Makefile > > +++ b/arch/arm64/boot/dts/rockchip/Makefile > > @@ -85,6 +85,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3566-box-demo.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3566-lubancat-1.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-bpi-r2-pro.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-evb1-v10.dtb > > +dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-fastrhino-r66s.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-lubancat-2.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-nanopi-r5c.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-nanopi-r5s.dtb > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dts b/a= rch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dts > > new file mode 100644 > > index 000000000000..fc9e1bdab128 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dts > > @@ -0,0 +1,27 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > > + > > +#include "rk3568-fastrhino-r66s.dtsi" > > + > > +/ { > > + model =3D "Lunzn FastRhino R66S"; > > + compatible =3D "lunzn,fastrhino-r66s", "rockchip,rk3568"; > > + > > + aliases { > > + mmc0 =3D &sdmmc0; > > + }; > > +}; > > + > > +&sdmmc0 { > = > that whole element seems to be duplicated from rk3568-fastrhino-r66s.dtsi? > I don't think we need to declare that twice. If something really changes, > please only declare the new properties when going from dtsi to dts. Looking at patch3 I see the explanation :-) . The base dtsi should not contain the &sdmmc0 node, and it should only be included in the rk3568-fastrhino-r66s.dts, right? Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel