From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FD45C2BA19 for ; Tue, 21 Apr 2020 08:37:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA28820B1F for ; Tue, 21 Apr 2020 08:37:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IC9K7d5i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA28820B1F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lqtwPtAaYuNrDiASzL7A0NAOlKzec6kQKOvidJwFHJ8=; b=IC9K7d5i0fIA8J CKIhbcekoHc4Q/vuMPoRUSr8ZF4qWPl6tQlwdbrvYpW/g1E+dFdnP49S7GHMGaw42kidRf6QEE4sE O5ZmdQ5i9+9es+iv/s0X4Eo0tmsh8mFfXTMJygWTpEJ8Zr7t2GbawQIoVKT1yA+0MvAJcLlCrt6F8 iTQmG13rI8Qi+skJ9x6yFwdqm51yOR3Flc1ozbuxPCaV6RoBc24uLBx8jE2PPP8aUKPs0Rbscra/K RyKMc3hU2BusbTGaVQi0PLXt6UGsVvEKRCRRHkLh5LvRkLiT/ZMMh+VwELrBvKFYf+n24zyPL5/85 ARy+fYIY1RFRF+4KydKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQoPf-0006mt-3k; Tue, 21 Apr 2020 08:37:51 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQoPc-0006ln-IN; Tue, 21 Apr 2020 08:37:49 +0000 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jQoPZ-0001XI-1R; Tue, 21 Apr 2020 10:37:45 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chen-Yu Tsai Subject: Re: [PATCH 1/3] arm64: dts: rockchip: add bus-width properties to mmc nodes for rk3328.dtsi Date: Tue, 21 Apr 2020 10:37:44 +0200 Message-ID: <4769044.6T0MzsmYic@diego> In-Reply-To: References: <20200416181944.5879-1-jbx6244@gmail.com> <2710874.PL6qFFFsBp@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200421_013748_605020_A222ED6F X-CRM114-Status: GOOD ( 18.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-kernel , "open list:ARM/Rockchip SoC..." , Rob Herring , Johan Jonker , linux-arm-kernel Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 21. April 2020, 10:29:49 CEST schrieb Chen-Yu Tsai: > On Tue, Apr 21, 2020 at 4:23 PM Heiko St=FCbner wrote: > > > > Hi ChenYu, > > > > Am Dienstag, 21. April 2020, 05:48:52 CEST schrieb Chen-Yu Tsai: > > > On Fri, Apr 17, 2020 at 2:19 AM Johan Jonker wrot= e: > > > > > > > > 'bus-width' and pinctrl containing the bus-pins > > > > should be in the same file, so add them to > > > > all mmc nodes in 'rk3328.dtsi'. > > > > > > Nope. First of all, pinctrl usage is with pinctrl-N properties, not t= he > > > pinctrl device, and there are no defaults set for any of the mmc node= s. > > > Second, these are board design specific. For example, boards are free= to > > > use just 4 bits for the eMMC if they so desire. So this should be in = each > > > board dts file. If a board is missing this property, fix the board. > > > > you are correct that the pinctrl entries are missing from the patches, > > bus-width and pinctrl should be defined in the same file each time, > > but for the whole idea I tend to disagree. > > > > So far every board with a Rockchip socs follows Rockchip's reference de= sign > > for a lot of parts - for example I only see sdmmc nodes with bus-width= =3D4 > > etc. > > > > So the basic idea is to have default pinctrl settings for the settings > > everybody uses predefined ... if a board comes along that needs differe= nt > > settings it is free to redefine that. > = > I think having a default is a great idea. :) especially for controllers that only ever use the same settings anyway. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel