From: Krzysztof Kozlowski <krzk@kernel.org>
To: Varada Pavani <v.pavani@samsung.com>,
s.nawrocki@samsung.com, cw00.choi@samsung.com,
alim.akhtar@samsung.com, mturquette@baylibre.com,
sboyd@kernel.org, linux-samsung-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: aswani.reddy@samsung.com, gost.dev@samsung.com
Subject: Re: [PATCH 2/2] arm64: dts: fsd: Fix Clock handle for WDT
Date: Fri, 29 Aug 2025 16:14:34 +0200 [thread overview]
Message-ID: <4770fec3-1b1c-4ade-aa3f-1ad097bbbb3f@kernel.org> (raw)
In-Reply-To: <20250829135643.105406-3-v.pavani@samsung.com>
On 29/08/2025 15:56, Varada Pavani wrote:
> FSD SoC WDT has few changes when compared to exynos7 interms of Clocks,
> PMU register bits for each cluster. So use "tesla,fsd-wdt"
So what was added in 2022?
> compatibility for using correct driver data.
> FSD supports 2 Clocks for WDT (PCLK and CLK).
> - use fin_pll source Clock for all timer related calculations.
> - use bus Clock (IMEM_WDT0_IPCLKPORT_PCLK) to gate/ungate the register
> interface. Update both as per WDT UM.
No, you break all the users. Probably users don't care, but I do care
because I use that arguments for reviewing other patches, so I apply a
bit stricter rules for existing Samsung trees.
Otherwise provide rationale about impact and what was happening in 2022
with this code...
Best regards,
Krzysztof
prev parent reply other threads:[~2025-08-29 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250829135658epcas5p24bb23c6fef2092aa7397faa10e0d9228@epcas5p2.samsung.com>
2025-08-29 13:56 ` [PATCH 0/2] dt-bindings: watchdog: Add support for FSD SoC watchdog Varada Pavani
[not found] ` <CGME20250829135703epcas5p14bbcc16e8d3622950a28e0ce40ff2dcd@epcas5p1.samsung.com>
2025-08-29 13:56 ` [PATCH 1/2] dt-bindings: watchdog: Modify tesla fsd bindings Varada Pavani
2025-08-29 14:12 ` Krzysztof Kozlowski
2025-08-30 8:45 ` Krzysztof Kozlowski
[not found] ` <CGME20250829135708epcas5p1b62d44f8a712b1c865fd82d26e89896f@epcas5p1.samsung.com>
2025-08-29 13:56 ` [PATCH 2/2] arm64: dts: fsd: Fix Clock handle for WDT Varada Pavani
2025-08-29 14:14 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4770fec3-1b1c-4ade-aa3f-1ad097bbbb3f@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=aswani.reddy@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=gost.dev@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=v.pavani@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).