[PATCH v5 0/17] Add Analogix Core Display Port Driver

Javier Martinez Canillas
2015-10-14T08:18:10Z

Hello Yakir,

On 10/13/2015 03:50 PM, Yakir Yang wrote:
> On 10/13/2015 05:21 PM, Javier Martinez Canillas wrote:
>

[snip]

>>> And it's better to enable pstore function on mainline kernel, so we can analysis the last log when
>>> the mainline kernel crashed. After enable PSTORE_RAM in .config, we still need add ramoops node
>> Interesting, I knew about pstore but I never used it with the Exynos Chromebooks.
>>
>>> into file, like:
>>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>>> @@ -750,6 +750,15 @@
>>> iommu = <&sysmmu_gsc3>;
>>> };
>>>
>>> + ramoops: ramoops {
>>> + compatible = "ramoops";
>>> + name = "ramoops";
>>> + reg = <0x41f00000 0x100000>;
>>> + record-size = <0x20000>;
>>> + dump-oops;
>>> + status = "okay";
>>> + };
>>> +
>> Are you using mainline? There isn't a "ramoops" compatible string documented
>> in the upstream DT bindings, platform_match() would match by driver name as
>> a fallback but I don't see code in fs/pstore/ram.c that parses the properties
>> in your device node. I wonder how this works for you or did I missunderstand?
>
> Aha, I lost some things that I back port the pstore/ram.c from chrome
> v3.14 tree which driver would parsed the "ramoops" compatible.
>

Ah, that explains it then.

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America