From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 22 Nov 2016 10:04:21 +0100 Subject: [PATCH] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation In-Reply-To: References: <20161116152047.3336967-1-arnd@arndb.de> Message-ID: <4774803.kQO20ucMKM@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday, November 22, 2016 9:47:20 AM CET Linus Walleij wrote: > On Wed, Nov 16, 2016 at 4:20 PM, Arnd Bergmann wrote: > > > This function clearly never worked and always returns true, > > as pointed out by gcc-7: > > > > arch/arm/mach-ux500/pm.c: In function 'prcmu_is_cpu_in_wfi': > > arch/arm/mach-ux500/pm.c:137:212: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-bool-context] > > > > With the added braces, the condition actually makes sense. > > > > Fixes: 34fe6f107eab ("mfd : Check if the other db8500 core is in WFI") > > Signed-off-by: Arnd Bergmann > > Acked-by: Linus Walleij > > Will you apply it directly to ARM SoC or should I queue it and > send it with a pull request? I'd prefer you to queue and track it, thanks, Arnd