From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F272DC04A95 for ; Tue, 25 Oct 2022 05:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WN53liUE+uzZ41KwtEQknFyuXu3dkXXSA2tOeaoNG10=; b=FnADLa92T0WVEa Ti+c7fP1s5UXRcJeMfc3kJXWJhqqHTvn8bckT/BTbQaTKXmXxetpkA2+TBvZiCXMEeyjsUsjTA00o waho0N5EG8aPrUifWWqQHV1B6XR+4Jv/XT6NPLueiFrVIOYTp1FZqtAel0zp8fo9Pt22rCctj1Mwf PsZA5mWiA5wm7gNgG2oZ3VNU1OpvAn7NYXWZq0SwvqCNg++TmSIfatZRTxBSbjFLKKckuOcIoiwFy 2N7WVXyU1TTM6Ui5VLFxuVQf3VsEva3ZKVIyJpxxdaKHTO08zcSJnACbdn2cNEQ2no7GLHJXETbru uWWmboAwH6/RvjcacGKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onC4m-003q0i-NY; Tue, 25 Oct 2022 05:02:08 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onC4i-003pzH-Mc for linux-arm-kernel@lists.infradead.org; Tue, 25 Oct 2022 05:02:06 +0000 Received: by mail-ej1-x630.google.com with SMTP id t25so4188410ejb.8 for ; Mon, 24 Oct 2022 22:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PdxBLNzeJXsLg4JPPQOp9WmP0XzX3jm+VBFzQsBEwu8=; b=ZH1Av+781KKvjoXRQNesJgXbfiJS3TrOv3jGtMkFEom3W58VHecGcVB82utVr409/K 3jN78yr6nFMc7gCvPflM89MvTG03mCJPQvy38XW6ry1t1fjxX8QFqWRCxgFD6/KdvCvA gIdHl9u8m+Ja6iZs5xFhDq1UOynBX9P9TwfZzqHZpbit/sRiBHTrpLqntfsWF3QC3Cnz p9JPbB///VEgS7w0JmXWhdpx23fBgx5IPNSVvG3kadBIO7+FOCJ+9Gr1O2k/xd4qvj0d y2Zjqx2EXBm2uIFk9vQ12kDs8PH/Up0X5ljKYqsACb/huPMz6N1ByKKemdqJGtvooo3J X7vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PdxBLNzeJXsLg4JPPQOp9WmP0XzX3jm+VBFzQsBEwu8=; b=UyAATINL7mcoM6+UWmeHZwAXlaRbgFDpOv91dOu0g80F7rJax4xhIXHo2i3CtO20/z Itz7dRqYHFxDkA4GKUNwkrv+q2jaWEcLz3FvbZNqb7WQwL8iHL86Nr98BjJxtmbMuy+R cYibW5bIta8gBErvLKZRpo26y31yJQOW0UHnpdqPQETLokOSCKMG2V4eMObIoYji/xxO TXovqAyFSe6WRPUWOIs2rxptn75bxOmOhF1yZAcBZ3LoJ4VCzTMecQkDYi+9sgYeDDJb WupTt86gUFSnPnk0Za36i+CI+bSAbk/2to+eOdwyOet9x4sLYs4/McQ4XnQ6qVU3Kdxu 8BqQ== X-Gm-Message-State: ACrzQf0aAAwl4Nh6XnLuwG+h6VMuaIIwCP4xrnXZBocXAHqHiovnIxdb bVgO5zqgCSHcTqQwQMh+KK0= X-Google-Smtp-Source: AMsMyM6f6O6P2agNUV8uPOTJvBphd3OgsKm+lyd13PR+wFtgsQ4fr6n5UbtP65RuOg0fjWCZI3PLsA== X-Received: by 2002:a17:907:ea7:b0:78f:4ae:965c with SMTP id ho39-20020a1709070ea700b0078f04ae965cmr30535593ejc.127.1666674121468; Mon, 24 Oct 2022 22:02:01 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id l19-20020a056402345300b00458898fe90asm919332edc.5.2022.10.24.22.02.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 22:02:00 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Paul Kocialkowski Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Sakari Ailus , Hans Verkuil , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v7 0/6] Allwinner A31/A83T MIPI CSI-2 and A31 ISP / ISP Driver Date: Tue, 25 Oct 2022 07:01:59 +0200 Message-ID: <4776447.31r3eYUQgx@jernej-laptop> In-Reply-To: References: <20220924153304.77598-1-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221024_220204_770400_05605ACB X-CRM114-Status: GOOD ( 33.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, Dne petek, 21. oktober 2022 ob 16:14:26 CEST je Paul Kocialkowski napisal(a): > Hi, > > On Sat 24 Sep 22, 17:32, Paul Kocialkowski wrote: > > This part only concerns the introduction of the new ISP driver and related > > adaptation of the CSI driver. > > I don't think there is any significant issue preventing this series from > being merged in Linux 6.2 at this point. > > Could we move forward on it? It's been around for quite some time now. While I'm no expert in ISP drivers, I can take a look (for other series too) this week. Could you attach output of v4l2-complience output (for both)? Best regards, Jernej > > Thanks! > > Paul > > > Most non-dt patches still need reviewing but should be pretty > > straightforward. Since this multi-part series has been going on for a > > while, it would be great to see it merged soon! > > > > Changes since v6: > > - Added a per-compatible check for the required port in dt binding; > > - Reworded ISP output port description in dt binding; > > - Reversed ISP detection order to have fwnode first; > > - Removed info print when ISP link is detected; > > - Added warn print when ISP is linked but not enabled in config; > > - Fixed sun6i_csi_isp_detect return type; > > - Removed useless initialization in sun6i_csi_isp_detect; > > - Fixed typo in sun6i_csi_isp_detect; > > - Added collected tags; > > > > Changes since v5: > > - Rebased on latest media tree; > > - Added collected tag; > > - Switched to using media_pad_remote_pad_first; > > - Switched to using media_pad_remote_pad_unique. > > > > Changes since v4: > > - Fixed device-tree binding indent-align; > > - Added collected tag; > > - Rebased on latest media tree; > > > > Changes since v3: > > - Removed the v4l2 controls handler from the driver; > > - Added variant structure for table sizes; > > - Removed the info message about video device registration; > > - Removed comments in uAPI header; > > - Used '/schemas/graph.yaml#/properties/port' whenever possible in > > bindings; - Added CSI patches dependent on the ISP driver; > > - Rebased on the latest media tree; > > > > Changes since all-in-one v2: > > - Updated Kconfig to follow the latest media-wide changes; > > - Reworked async subdev handling with a dedicated structure holding the > > > > corresponding source to avoid matching in the driver; > > > > - Switched to clock-managed regmap mmio; > > - Used helper to get a single enabled link for an entity's pad, to replace > > > > source selection at link_validate time and select the remote source at > > stream on time instead; > > > > - Added mutex for mbus format serialization; > > - Used endpoint-base instead of video-interface for "internal" endpoints > > > > in device-tree schema; > > > > - Added TODO with unstaging requirements; > > - Various cosmetic cleanups; > > - Updated copyright years; > > > > Paul Kocialkowski (6): > > dt-bindings: media: Add Allwinner A31 ISP bindings documentation > > dt-bindings: media: sun6i-a31-csi: Add internal output port to the ISP > > staging: media: Add support for the Allwinner A31 ISP > > MAINTAINERS: Add entry for the Allwinner A31 ISP driver > > media: sun6i-csi: Detect the availability of the ISP > > media: sun6i-csi: Add support for hooking to the isp devices > > > > .../media/allwinner,sun6i-a31-csi.yaml | 4 + > > .../media/allwinner,sun6i-a31-isp.yaml | 101 +++ > > MAINTAINERS | 9 + > > .../platform/sunxi/sun6i-csi/sun6i_csi.c | 75 +- > > .../platform/sunxi/sun6i-csi/sun6i_csi.h | 10 + > > .../sunxi/sun6i-csi/sun6i_csi_bridge.c | 32 +- > > .../sunxi/sun6i-csi/sun6i_csi_capture.c | 19 +- > > .../sunxi/sun6i-csi/sun6i_csi_capture.h | 1 + > > drivers/staging/media/sunxi/Kconfig | 1 + > > drivers/staging/media/sunxi/Makefile | 1 + > > drivers/staging/media/sunxi/sun6i-isp/Kconfig | 15 + > > .../staging/media/sunxi/sun6i-isp/Makefile | 4 + > > .../staging/media/sunxi/sun6i-isp/TODO.txt | 6 + > > .../staging/media/sunxi/sun6i-isp/sun6i_isp.c | 555 +++++++++++++ > > .../staging/media/sunxi/sun6i-isp/sun6i_isp.h | 90 +++ > > .../media/sunxi/sun6i-isp/sun6i_isp_capture.c | 742 ++++++++++++++++++ > > .../media/sunxi/sun6i-isp/sun6i_isp_capture.h | 78 ++ > > .../media/sunxi/sun6i-isp/sun6i_isp_params.c | 566 +++++++++++++ > > .../media/sunxi/sun6i-isp/sun6i_isp_params.h | 52 ++ > > .../media/sunxi/sun6i-isp/sun6i_isp_proc.c | 577 ++++++++++++++ > > .../media/sunxi/sun6i-isp/sun6i_isp_proc.h | 66 ++ > > .../media/sunxi/sun6i-isp/sun6i_isp_reg.h | 275 +++++++ > > .../sunxi/sun6i-isp/uapi/sun6i-isp-config.h | 43 + > > 23 files changed, 3309 insertions(+), 13 deletions(-) > > create mode 100644 > > Documentation/devicetree/bindings/media/allwinner,sun6i-a31-isp.yaml > > create mode 100644 drivers/staging/media/sunxi/sun6i-isp/Kconfig > > create mode 100644 drivers/staging/media/sunxi/sun6i-isp/Makefile > > create mode 100644 drivers/staging/media/sunxi/sun6i-isp/TODO.txt > > create mode 100644 drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c > > create mode 100644 drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.h > > create mode 100644 > > drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c create mode > > 100644 drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.h create > > mode 100644 drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c > > create mode 100644 > > drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.h create mode > > 100644 drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c create > > mode 100644 drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.h > > create mode 100644 drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_reg.h > > create mode 100644 > > drivers/staging/media/sunxi/sun6i-isp/uapi/sun6i-isp-config.h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel