From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67A90C47258 for ; Tue, 16 Jan 2024 19:56:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hx5lLXqjQ2V81z1Q24Yp1ehmNrjb+Q0vhaVNjjFrZ+U=; b=tz6SQbJlTdsa9C aEJ27Qn9B6IqnI52MlL9MMGDJaW5nkXi2qlPonxiW63b6waTrepCDnrTjiRPj1RLhtLwR0yDmwpkV iliqurEbnAyZQoxOkjvHlR9XsT7/WIRzK+JY/s2wm43XH9NgZPjWBI9nk8+5ea8dbyFmbHmQ5MlCh XWdpPQQgxOjOPpWj44jm+DM4ZlZ9hT8jCmHFGWhGIzIi04kPT47Revfvi4EDRBdIg9mrr5JVK6BxX Pd7SNb0zoVeliqi1QvSsfr8hlziHYbR85uxjxycdu8eKjQDQWPnQHW2Ta/P0Bfp8sZofKkCvsfSE8 ycDvnmZmV1qtepIo4Svw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPpXb-00DHAM-1d; Tue, 16 Jan 2024 19:56:07 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rPpXW-00DH3k-0x; Tue, 16 Jan 2024 19:56:06 +0000 Received: from i5e860cd7.versanet.de ([94.134.12.215] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rPpX7-00076A-9P; Tue, 16 Jan 2024 20:55:37 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Rob Herring Cc: Tim Lunn , KyuHyuk Lee , Krzysztof Kozlowski , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Tianling Shen , Jagan Teki , Ondrej Jirman , Andy Yan , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: rockchip: Fix Hardkernel ODROID-M1 board bindings Date: Tue, 16 Jan 2024 20:55:35 +0100 Message-ID: <47795047.XUcTiDjVJD@diego> In-Reply-To: <20240116192605.GA274661-robh@kernel.org> References: <20240115145142.6292-1-lee@kyuhyuk.kr> <2421144.zToM8qfIzz@diego> <20240116192605.GA274661-robh@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240116_115602_337294_A57B3B3A X-CRM114-Status: GOOD ( 32.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 16. Januar 2024, 20:26:05 CET schrieb Rob Herring: > On Tue, Jan 16, 2024 at 09:31:35AM +0100, Heiko St=FCbner wrote: > > Am Dienstag, 16. Januar 2024, 08:24:44 CET schrieb Krzysztof Kozlowski: > > > On 16/01/2024 03:00, Tim Lunn wrote: > > > > = > > > > On 1/16/24 01:58, Krzysztof Kozlowski wrote: > > > >> On 15/01/2024 15:51, KyuHyuk Lee wrote: > > > >>> The vendor in ODROID-M1 is hardkernel, but it was incorrectly wri= tten > > > >>> as rockchip. Fixed the vendor prefix correctly. > > > >>> > > > >>> Signed-off-by: KyuHyuk Lee > > > >>> --- > > > >>> Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +- > > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > > >> You need to start testing your patches. Your last M1 fails as well= in > > > >> multiple places. > > > >> > > > >> It does not look like you tested the DTS against bindings. Please = run > > > >> `make dtbs_check W=3D1` (see > > > >> Documentation/devicetree/bindings/writing-schema.rst or > > > >> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicet= ree-sources-with-the-devicetree-schema/ > > > >> for instructions). > > > >> > > > >> The DTS change will break the users, so would be nice to mention t= his in > > > >> its commit msg. > > > > = > > > > I notice there are a couple of other boards that incorrectly use = > > > > rockchip as the vendor also: > > > > = > > > > - const: rockchip,rk3399-orangepi > > > > - const: rockchip,rk3568-bpi-r2pro > > > > = > > > > Perhaps these should also be fixed at the same time? > > > = > > > What is happening with rockchip boards? > > = > > Copy-paste stuff ... boards using rockchip,boardname instead of > > vendor,boardname for their compatible. > > = > > I do remember us noticing this a number of times on some boards > > and requesting fixes, but looks like some slipped through. > > = > > So I guess Tim is suggesting changing the compatible, but with boards > > being merged a while ago, this would break backwards compatibility. > > So I guess both the Orange and Banana Pies will need to live with that. > = > You may get away with it because we generally don't use the names... > = > Though there are some discussions to start using them to select dtbs by = > bootloaders. Ah, that's good to know (both points) ... so essentially right now would be a good time to do what Tim suggested, before the names get actual usage. @Tim: is that something you'd want to do? Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel