From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org
Cc: alexander.shishkin@linux.intel.com, coresight@lists.linaro.org,
acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
leo.yan@linaro.org, mike.leach@linaro.org
Subject: Re: [PATCH V2 5/6] coresight: perf: Don't set the truncated flag in snapshot mode
Date: Thu, 16 May 2019 16:22:23 +0100 [thread overview]
Message-ID: <478c71d9-d13e-96f5-5a07-bb48c7166b5d@arm.com> (raw)
In-Reply-To: <20190514194018.23420-6-mathieu.poirier@linaro.org>
On 14/05/2019 20:40, Mathieu Poirier wrote:
> This patch avoids setting the truncated flag when operating in snapshot
> mode since the trace buffer is expected to be truncated and discontinuous
> from one snapshot to another. Moreover when the truncated flag is set
> the perf core stops enabling the event, waiting for user space to consume
> the data. In snapshot mode this is clearly not what we want since it
> results in stale data.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
For patches 2-5:
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-16 15:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 19:40 [PATCH V2 0/6] coresight: Fix snapshot mode Mathieu Poirier
2019-05-14 19:40 ` [PATCH V2 1/6] coresight: etb10: Properly set AUX buffer head in " Mathieu Poirier
2019-05-15 9:45 ` Suzuki K Poulose
2019-05-15 14:28 ` Mathieu Poirier
2019-05-16 9:41 ` Suzuki K Poulose
2019-05-14 19:40 ` [PATCH V2 2/6] coresight: tmc-etr: " Mathieu Poirier
2019-05-14 19:40 ` [PATCH V2 3/6] coresight: tmc-etf: " Mathieu Poirier
2019-05-14 19:40 ` [PATCH V2 4/6] coresight: tmc-etf: Fix snapshot mode update function Mathieu Poirier
2019-05-14 19:40 ` [PATCH V2 5/6] coresight: perf: Don't set the truncated flag in snapshot mode Mathieu Poirier
2019-05-16 15:22 ` Suzuki K Poulose [this message]
2019-05-14 19:40 ` [PATCH V2 6/6] perf tools: Properly set the value of 'old' and 'head' " Mathieu Poirier
2019-05-16 15:00 ` Leo Yan
2019-05-20 19:53 ` Mathieu Poirier
2019-05-21 1:54 ` Leo Yan
2019-05-16 15:09 ` [PATCH V2 0/6] coresight: Fix " Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478c71d9-d13e-96f5-5a07-bb48c7166b5d@arm.com \
--to=suzuki.poulose@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox