From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 245FAC43381 for ; Tue, 12 Mar 2019 13:18:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAEE52171F for ; Tue, 12 Mar 2019 13:18:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EB76nvGP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAEE52171F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=22AxgzVxc9u6AZoeVUlaVFAEp0sj0bvrLQj3c24X8pk=; b=EB76nvGPbS1lwt C477G/kS8IfaTiCgiRitXgDO6+p791/3dt0vWqTI3ReAzcoXWI6sOpTSHipphhvDWhiKjoP4cs7r9 yCnLMdFixZwhQzxsmr6os8K6wNfVSoSM6RrETu0ukaflqC8KQJQCJqxACQ7NbqDq+ehSAbgiuaUIB mbl/+RteII/FS+rwLeRWE4Jb9NmpfS/ygHoWJLai3ErPoQu4ZiMLcCsBUrI6h6bh9qzixBUqCKbSK VGqWAahc/WcWyFrRWgF5933qaoOFVJhG5dhNnQkyybFi4HxQZBbwV2utLHOg8kgGzkATAZxhKNcmR 97EvEi/WAfILmCQugslg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3hIT-0006p4-T8; Tue, 12 Mar 2019 13:18:21 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3hIQ-0006oO-M6; Tue, 12 Mar 2019 13:18:20 +0000 Received: from we0652.dip.tu-dresden.de ([141.76.178.140] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h3hI4-0001pp-39; Tue, 12 Mar 2019 14:17:56 +0100 From: Heiko Stuebner To: Christoph =?ISO-8859-1?Q?M=FCllner?= Subject: Re: [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd. Date: Tue, 12 Mar 2019 14:17:55 +0100 Message-ID: <4793843.T1TZ7EF8k3@phil> In-Reply-To: <3BCC2A27-3AF4-4E5E-BBD4-6A5B49831D3C@theobroma-systems.com> References: <20190307084329.25416-1-christoph.muellner@theobroma-systems.com> <37a96eda-196e-bacf-7ae2-5b9354c70273@intel.com> <3BCC2A27-3AF4-4E5E-BBD4-6A5B49831D3C@theobroma-systems.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_061818_877441_0A0A4032 X-CRM114-Status: GOOD ( 21.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, ulf.hansson@linaro.org, Emil Renner Berthing , Viresh Kumar , shawn.lin@rock-chips.com, Adrian Hunter , Tony Xie , Klaus Goger , Philipp Tomsich , Michal Simek , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Randy Li , Vicente Bergas , robh+dt@kernel.org, Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, Lin Huang , linux-mmc@vger.kernel.org, Douglas Anderson , linux-kernel@vger.kernel.org, Enric Balletbo i Serra Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 8. M=E4rz 2019, 14:10:45 CET schrieb Christoph M=FCllner: > = > > On 08.03.2019, at 13:46, Adrian Hunter wrote: > > = > > On 7/03/19 10:43 AM, Christoph Muellner wrote: > >> This patch documents the new property disable-cqe-dcmd > >> for the Arasan eMMC 5.1 driver. > >> = > >> Signed-off-by: Christoph Muellner > >> Signed-off-by: Philipp Tomsich > >> --- > >> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> = > >> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/= Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > >> index 1edbb049cccb..ec699bf98b7c 100644 > >> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > >> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > >> @@ -44,6 +44,10 @@ Optional Properties: > >> properly. Test mode can be used to force the controller to functio= n. > >> - xlnx,int-clock-stable-broken: when present, the controller always = reports > >> that the internal clock is stable even when it is not. > >> + - disable-cqe-dcmd: The eMMC 5.1 standard specifies direct commands= (DCMDs) > >> + as part of the command queue engine (CQE). On controllers with a = CQHCI, > >> + such as the Arasan eMMC 5.1 host controller, the driver has to en= able DCMDs. > >> + This is done unless disable-cqe-dcmd is specified. This needs a rewording please. See below for hw-description vs. driver, so the description should be centered around why this is a property of the hw [like faulty controller implementation or whatever] > > If "supports-cqe" is in mmc.txt, should "disable-cqe-dcmd" be there als= o? > = > The file mmc.txt says on top: > "These properties are common to multiple MMC host controllers". > As my patchset introduces "disable-cqe-dcmd" just for sdhci-of-arasan, > I would say it should not go into that file. > = > Also I wonder why "supports-cqe" is in mmc.txt, because > only sdhci-tegra.c is evaluating that property. > So I would expect it to be documented in > Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt > = > However, I see that "disable-cqe-dcmd" could go into other drivers as wel= l. > But is this enough to document it in mmc.txt? Devicetree is always about describing the hardware capabilites and never about the actual nitty-gritty of driver implementation, aka it is not meant as a space for hardware-independent config-settings or such. As for only tegra evaluating this, is probably because it is still so new, = like january 2019 and Rob explicitly suggested it becoming common [0], which suggests that the disable-cqe-dcmds should probably also be common. Heiko [0] https://lore.kernel.org/patchwork/patch/1031163/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel