From: "Christian Kohlschütter" <christian@kohlschutter.com>
To: Mark Brown <broonie@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Linux MMC List" <linux-mmc@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Markus Reichl" <m.reichl@fivetechno.de>,
"Robin Murphy" <robin.murphy@arm.com>,
"Vincent Legoll" <vincent.legoll@gmail.com>,
wens@kernel.org
Subject: Re: [PATCH v5] regulator: core: Resolve supply name earlier to prevent double-init
Date: Mon, 29 Aug 2022 19:01:38 +0200 [thread overview]
Message-ID: <479AFACA-866E-4B3B-B0C2-ABA83591DA56@kohlschutter.com> (raw)
In-Reply-To: <YwzerCnjvTKsEyIi@sirena.org.uk>
> On 29. Aug 2022, at 17:43, Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Aug 25, 2022 at 09:28:42PM +0000, Christian Kohlschütter wrote:
>> Previously, an unresolved regulator supply reference upon calling
>> regulator_register on an always-on or boot-on regulator caused
>> set_machine_constraints to be called twice.
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code. Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.
>
> Please don't send new patches in reply to old patches or serieses, this
> makes it harder for both people and tools to understand what is going
> on - it can bury things in mailboxes and make it difficult to keep track
> of what current patches are, both for the new patches and the old ones.
My apologies, I wasn't aware that's not the preferred way forward.
Following up with "regulator: core: Fix regulator supply registration with sysfs", see
https://lore.kernel.org/all/20220829165543.24856-1-christian@kohlschutter.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-29 17:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEwRq=qe+Frwpe=Zr4n_8A6vjOJnV3noegdnHSN7NTazkKejBA@mail.gmail.com>
2022-08-04 10:44 ` [PATCH v3] regulator: core: Resolve supply name earlier to prevent double-init Christian Kohlschütter
2022-08-15 11:17 ` Mark Brown
2022-08-18 12:46 ` [PATCH v4] " Christian Kohlschütter
2022-08-18 15:23 ` Mark Brown
2022-08-25 11:32 ` Marek Szyprowski
2022-08-25 12:21 ` Mark Brown
2022-08-25 14:23 ` Marek Szyprowski
2022-08-25 15:18 ` Christian Kohlschütter
2022-08-25 21:28 ` [PATCH v5] " Christian Kohlschütter
2022-08-25 21:35 ` Christian Kohlschütter
2022-08-26 5:55 ` Marek Szyprowski
2022-08-29 15:43 ` Mark Brown
2022-08-29 17:01 ` Christian Kohlschütter [this message]
2023-02-17 23:22 ` Saravana Kannan
2023-02-17 23:33 ` Christian Kohlschütter
2023-02-17 23:46 ` Saravana Kannan
2023-02-18 0:01 ` Christian Kohlschütter
2023-02-18 0:05 ` Saravana Kannan
2022-08-18 15:22 ` [PATCH v3] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479AFACA-866E-4B3B-B0C2-ABA83591DA56@kohlschutter.com \
--to=christian@kohlschutter.com \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=vincent.legoll@gmail.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox