From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8875AC4727E for ; Thu, 24 Sep 2020 11:16:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2D5F2388A for ; Thu, 24 Sep 2020 11:16:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P1MHihRs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2D5F2388A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0Sfb6IRJLvi1y+2/iNOexuPoAb7OhFT1isITlKZYx7M=; b=P1MHihRs8bE8OdZzmclnahgle G/rcTrx/nY3KTkUT0LEOszUVWHPCOxUcJebDBVSvzp1ZmaSRaL+CdMfmsBKhPrEgfJKeoFs1zxIOb w9yndcCRjUCkM8l4nHi3P3c6q8UEFa98s5fkTa88UjnIuQ0vHrt1YhDnnge0y2ABnKGnp6zQkbYHY vA7YYt0xT1gEjUdlNqC1io9sklvfcZLELacE90H3r42KjxXrTCxp+PcFayhtvM7ahrR8l7TRXDLeg KtPF6NgG0V75cY4PD9NfYu34kdNhRnqrC+OlRyA0HzFs/PEsFwb2EC81k/+OGfekg2E/fTQTTeKZU ai86C+uQw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLPCP-0003h1-1O; Thu, 24 Sep 2020 11:14:05 +0000 Received: from lhrrgout.huawei.com ([185.176.76.210] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLPBr-0003SQ-Tu for linux-arm-kernel@lists.infradead.org; Thu, 24 Sep 2020 11:13:35 +0000 Received: from lhreml713-chm.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id F173988DD8CE65492693; Thu, 24 Sep 2020 12:13:23 +0100 (IST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by lhreml713-chm.china.huawei.com (10.201.108.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Thu, 24 Sep 2020 12:13:23 +0100 Received: from lhreml710-chm.china.huawei.com ([169.254.81.184]) by lhreml710-chm.china.huawei.com ([169.254.81.184]) with mapi id 15.01.1913.007; Thu, 24 Sep 2020 12:13:23 +0100 From: Shameerali Kolothum Thodi To: Jean-Philippe Brucker Subject: RE: [PATCH v10 10/13] iommu/arm-smmu-v3: Check for SVA features Thread-Topic: [PATCH v10 10/13] iommu/arm-smmu-v3: Check for SVA features Thread-Index: AQHWjaVYIOfN4SdH50ySUPU7pQ9X7Klyx0+AgATDYgCAAB0CgA== Date: Thu, 24 Sep 2020 11:13:23 +0000 Message-ID: <47b244b99f284790b82b2c0a968ba830@huawei.com> References: <20200918101852.582559-1-jean-philippe@linaro.org> <20200918101852.582559-11-jean-philippe@linaro.org> <753bcd76c21c4ea98ef1d4e492db01f4@huawei.com> <20200924101340.GC170808@myrica> In-Reply-To: <20200924101340.GC170808@myrica> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.47.86.144] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200924_071332_062107_F0036112 X-CRM114-Status: GOOD ( 16.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "fenghua.yu@intel.com" , "will@kernel.org" , Suzuki K Poulose , "catalin.marinas@arm.com" , "linux-mm@kvack.org" , "iommu@lists.linux-foundation.org" , "zhangfei.gao@linaro.org" , "robin.murphy@arm.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Jean-Philippe Brucker [mailto:jean-philippe@linaro.org] > Sent: 24 September 2020 11:14 > To: Shameerali Kolothum Thodi > Cc: iommu@lists.linux-foundation.org; linux-arm-kernel@lists.infradead.org; > linux-mm@kvack.org; fenghua.yu@intel.com; catalin.marinas@arm.com; > Suzuki K Poulose ; robin.murphy@arm.com; > zhangfei.gao@linaro.org; will@kernel.org > Subject: Re: [PATCH v10 10/13] iommu/arm-smmu-v3: Check for SVA features > > Hi Shameer, > > On Mon, Sep 21, 2020 at 08:59:39AM +0000, Shameerali Kolothum Thodi > wrote: > > > +bool arm_smmu_sva_supported(struct arm_smmu_device *smmu) > > > +{ > > > + unsigned long reg, fld; > > > + unsigned long oas; > > > + unsigned long asid_bits; > > > + u32 feat_mask = ARM_SMMU_FEAT_BTM | > > > ARM_SMMU_FEAT_COHERENCY; > > > > Why is BTM mandated for SVA? I couldn't find this requirement in SMMU spec > > (Sorry if I missed it or this got discussed earlier). But if performance is the > only concern here, > > is it better just to allow it with a warning rather than limiting SMMUs without > BTM? > > It's a performance concern and requires to support multiple > configurations, but the spec allows it. Are there SMMUs without BTM that > need it? Ok. Thanks for clarifying. May be better to add a comment here. Our platforms do support BTM, but I had a strange case where the UEFI didn't enable DVM but SMMU reported BTM and was causing random failures due to lack of explicit tlbi on mm invalidation. Anyway that doesn't count here :) Thanks, Shameer > Thanks, > Jean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel