From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E318AC433F5 for ; Sat, 5 Mar 2022 08:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l12kdbHEafzHOQnbLMvEl8Qffl5D7tXNhmkzStymrFU=; b=ocJsiVzjZ+SZt1L4TZ1tsBLjof DpnmjAq6C/Y1QHQgjNEfVNJJ+mfYJ+z3fXlQ/N+HTRYOZjUnbuT+JfuiTKPCCI6DzSSOZRcL42LkI hJS1XQCruw1megNYYDRPTWsW7Ez+fCNc5NL8l2Ff4t6xAESb3rwL0H1z4IHumsmMxxI3QbYyT32cQ bgeFz6TjaACYRd22fHmzj7rhJZTOlapj3w6Qpm4AIK/dRa6fPyczyrSS5ga2Wljbsya5Z4vwPlFY1 kFaNqsGUK3b2vTNVvFc+Lt8jIvzRmw/au5nNdFOfPhzUUK/qBhKttKEZr7K0jLfuB8v17EbhoLqpG N4scOVZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQPvj-00CyyA-Ig; Sat, 05 Mar 2022 08:38:23 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQPvg-00Cyxi-GU for linux-arm-kernel@lists.infradead.org; Sat, 05 Mar 2022 08:38:21 +0000 Received: by mail-pl1-x633.google.com with SMTP id i1so9769767plr.2 for ; Sat, 05 Mar 2022 00:38:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=4q9rupxAtgeh0z74bvSngfTH3q+iMizoxg7UH0B4T/o=; b=btIKdS/FS+BX5jnCkXzHGhLWyAwM7A4CN9T3gOQW3bKxtSfv1NLvqa2oPzSDgPUIvI UVLo3SWgHLbmQVWY1SH4Jl1WF3D02PyCrf05AvaTR79v8kYsgerAmHM145FhUkiEHE/0 pXVk7/6CjNYa1i7CjX4T5NeE0oOrgn30aP3p6pu9wcLB/MS60SzeeFqlwdD0Y/CDPivG /3mgWdGeorKgmq/+zOmM9W4UBhaPGYDjwI6j3a0jpbZQrTFD1m+uWR/XBeATEQdyQre5 Fu6jYuTcCQZGPO3pAp5FZ+jDScDuyJLT2w1W6J/iG+rq1kTsDV7kHKNk+U6KEQ1Z5jfA okgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=4q9rupxAtgeh0z74bvSngfTH3q+iMizoxg7UH0B4T/o=; b=37P15k4RTJdhXr2hp2GUlhowm8e0teWMEAG1x+HT+ZbzmiekRhV6jZII75V/jdpsK1 zWXYovECqqo2E83fu0tVd9z62KCjXjY32t4WHBn66WR5UHgLJHBslySkWxRGeHT1IlSe 6JAzaXEWYNJ2BcZ/7t81Krrxu1skR/8QaLIL4PROwcAObpkxtN0xhi4kf1Tl4kwgtcZ6 Jn47w4ioOIF5BufbAoVV7hDvwwYgALUm+YyebP3fFtf/wwzmVF/cflCgwmBzbVgJJld+ uJ97uK+wnvb5SdwMdzC9HeTbf2umsPcaf2c9vIQEBbxZmcNC+UsqpsolryY0cLwkmsrD yfmg== X-Gm-Message-State: AOAM533rRKG0GgBcwji0MugNaDPLYRWOmqu2WrU6QfFKmlttqMorJzmb nwrl4T0VHYzEPdsEpDlYFx4zX2g0A4rkxg== X-Google-Smtp-Source: ABdhPJwrqasm/Aj96Sb/8B66of8QRPaNNoC3JjmddWhpSQd0G6BpPFgWNdhVFq3NO2IF1nkMqSouag== X-Received: by 2002:a17:902:ccc6:b0:14f:88e6:8040 with SMTP id z6-20020a170902ccc600b0014f88e68040mr2332802ple.13.1646469498919; Sat, 05 Mar 2022 00:38:18 -0800 (PST) Received: from [10.107.0.6] ([64.64.123.82]) by smtp.gmail.com with ESMTPSA id d5-20020a17090acd0500b001b9c05b075dsm12586726pju.44.2022.03.05.00.38.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Mar 2022 00:38:18 -0800 (PST) Subject: Re: [PATCH] dma: xilinx: check the return value of dma_set_mask() in zynqmp_dma_probe() To: Michael Tretter Cc: vkoul@kernel.org, michal.simek@xilinx.com, yukuai3@huawei.com, lars@metafoo.de, libaokun1@huawei.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de References: <20220303024334.813-1-baijiaju1990@gmail.com> <20220304082024.GO8137@pengutronix.de> From: Jia-Ju Bai Message-ID: <47bca068-9bc2-73c7-dfa4-ddd5ce78618c@gmail.com> Date: Sat, 5 Mar 2022 16:38:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20220304082024.GO8137@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220305_003820_580185_64D7DED7 X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/3/4 16:20, Michael Tretter wrote: > On Wed, 02 Mar 2022 18:43:34 -0800, Jia-Ju Bai wrote: >> The function dma_set_mask() in zynqmp_dma_probe() can fail, so its >> return value should be checked. >> >> Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver support") >> Reported-by: TOTE Robot >> Signed-off-by: Jia-Ju Bai >> --- >> drivers/dma/xilinx/zynqmp_dma.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c >> index 7aa63b652027..963fb1de93af 100644 >> --- a/drivers/dma/xilinx/zynqmp_dma.c >> +++ b/drivers/dma/xilinx/zynqmp_dma.c >> @@ -1050,7 +1050,8 @@ static int zynqmp_dma_probe(struct platform_device *pdev) >> zdev->dev = &pdev->dev; >> INIT_LIST_HEAD(&zdev->common.channels); >> >> - dma_set_mask(&pdev->dev, DMA_BIT_MASK(44)); >> + if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(44))) >> + return -EIO; > Thanks. > > You may print an error message with dev_err_probe and forward the return value > of dma_set_mask. Hi Michael, Thanks for the advice. I will send a V2 patch. Best wishes, Jia-Ju Bai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel