From: Lucas Stach <l.stach@pengutronix.de>
To: Marek Vasut <marex@denx.de>, linux-arm-kernel@lists.infradead.org
Cc: ch@denx.de, Frieder Schrempf <frieder.schrempf@kontron.de>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 1/2] soc: imx: gpcv2: Turn domain->pgc into bitfield
Date: Sat, 17 Jul 2021 01:34:57 +0200 [thread overview]
Message-ID: <47e87f9368b719925dc1794fa73d30c9d2a0a2bd.camel@pengutronix.de> (raw)
In-Reply-To: <62cfb9ca-d4b6-ce4d-bfc5-a00e40535b6e@denx.de>
Hi Marek,
Am Freitag, dem 02.07.2021 um 19:48 +0200 schrieb Marek Vasut:
> On 7/2/21 7:02 PM, Lucas Stach wrote:
> > Am Donnerstag, dem 01.07.2021 um 01:01 +0200 schrieb Marek Vasut:
> > > There is currently the MX8MM GPU domain, which is in fact a composite domain
> > > for both GPU2D and GPU3D. To correctly configure this domain, it is necessary
> > > to control both GPC_PGC_nCTRL(GPU_2D) and GPC_PGC_nCTRL(GPU_3D) at the same
> > > time. This is currently not possible.
> > >
> > > Turn the domain->pgc from value into bitfield and use for_each_set_bit() to
> > > iterate over all bits set in domain->pgc when configuring GPC_PGC_nCTRL
> > > register array. This way it is possible to configure all GPC_PGC_nCTRL
> > > registers required in a particular domain.
> > >
> > > This is a preparatory patch, no functional change.
> >
> > Which tree was used to generate this patch? This does not apply on top
> > of next or Shawn's imx/drivers tree and from a glance is at least
> > missing the 8MN power domains.
>
> Next with this additional patch
> [PATCH] soc: imx: gpcv2: Assert reset before ungating clock
I've picked up this patch in the series of i.MX8MM power domain
improvements I just sent. Compared to your version I dropped the above
base patch and fixed up the i.MX8MN domains.
Regards,
Lucas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-07-16 23:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 23:01 [PATCH 1/2] soc: imx: gpcv2: Turn domain->pgc into bitfield Marek Vasut
2021-06-30 23:01 ` [PATCH 2/2] soc: imx: gpcv2: Set both GPC_PGC_nCTRL(GPU_2D|GPU_3D) for MX8MM GPU domain Marek Vasut
2021-07-01 1:44 ` Peng Fan (OSS)
2021-07-01 1:48 ` [PATCH 1/2] soc: imx: gpcv2: Turn domain->pgc into bitfield Peng Fan (OSS)
2021-07-02 17:02 ` Lucas Stach
2021-07-02 17:48 ` Marek Vasut
2021-07-16 23:34 ` Lucas Stach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47e87f9368b719925dc1794fa73d30c9d2a0a2bd.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=ch@denx.de \
--cc=frieder.schrempf@kontron.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
--cc=peng.fan@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).