From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D36BC433EF for ; Mon, 11 Apr 2022 14:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:Cc:To:From:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=6j5o9DmUg6A/joCN8zjs/hIGsZBHaLAh8UdicBo1zmk=; b=A4f4H9N+blIYaTpVjU7WwJSElP 5bIo0wFT3cZl5VIgvYicGGok+4jV/vwOcFW+jWaAcqYmN0duwzo572y/7alao/wB6r4190Io4xGv7 gIr+139t32zMqnqQ9f5n3ITFXUNtb+gjxMzi2QBezG3HsIYhYPd9JpoXpqlzT7jv+VdgUqjJyOVxi j7uey7ycfxaorXY5n4xLFPDTlKS5con3AwMLjuPK+FTS0Nq1soR+xq7aYgYDxZDrZPDTWk9he9r85 HlmGnoAeW5UtwiTxVE/zQO5zE5a7jariCABHN623/LaQhTzVel4OvBT+LCbvr2DOubtTnS7vSB0JB X3IaxpUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndv9C-009PVp-Bl; Mon, 11 Apr 2022 14:36:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndv99-009PV5-MY for linux-arm-kernel@lists.infradead.org; Mon, 11 Apr 2022 14:36:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4C4761570; Mon, 11 Apr 2022 07:36:02 -0700 (PDT) Received: from [10.1.30.132] (e127744.cambridge.arm.com [10.1.30.132]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4BBF43F73B; Mon, 11 Apr 2022 07:35:58 -0700 (PDT) Subject: Re: [PATCH v5 3/5] perf tools: sync addition of PERF_MEM_SNOOPX_PEER From: German Gomez To: Ali Saidi , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, leo.yan@linaro.org, acme@kernel.org Cc: benh@kernel.crashing.org, Nick.Forrington@arm.com, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org References: <20220408195344.32764-1-alisaidi@amazon.com> <20220408195344.32764-4-alisaidi@amazon.com> <39448754-adf5-f1ba-25e7-8ee3d76f0159@arm.com> Message-ID: <47ec29fe-75ea-62ef-447b-1164569616de@arm.com> Date: Mon, 11 Apr 2022 15:35:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <39448754-adf5-f1ba-25e7-8ee3d76f0159@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_073603_885821_B0F716CE X-CRM114-Status: GOOD ( 12.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/04/2022 11:26, German Gomez wrote: > On 08/04/2022 20:53, Ali Saidi wrote: >> Add a flag to the perf mem data struct to signal that a request caused a >> cache-to-cache transfer of a line from a peer of the requestor and >> wasn't sourced from a lower cache level. The line being moved from one >> peer cache to another has latency and performance implications. On Arm64 >> Neoverse systems the data source can indicate a cache-to-cache transfer >> but not if the line is dirty or clean, so instead of overloading HITM >> define a new flag that indicates this type of transfer. > I think it's fine to merge this and the previous commit rather than have > two commits with the same msg. > I take it back. It has been pointed out to me that having the separation is normal/ok. So my comment doesn't apply. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel