From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28CBFC433EF for ; Wed, 15 Sep 2021 05:27:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E452C610E8 for ; Wed, 15 Sep 2021 05:27:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E452C610E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=eCVoY64No+JlJ6n5oI8hXp0MuatZvIiBxXpJIMRANOk=; b=JZ2stskOg1sTX3/4/Rn92zpeGS K8LwyAUAeIKDPiUaNbydnAY2vKa4ZL1F0D4xZuxsam/z22UpbsnaBcUDhpO5hlpx86g97wVbUwmUZ +f2czIS7rJNGKxX6poCIZwUKXEAeUdrReN8TecEQFRfTXxkbiwiBmHLONL/WECvZifMQXGPE+jCjO zWoBAXY3wG5k2me2b2BBPOTjjqPjG/s5E0X3ZNUL9ozSkCM9/tKGxSSGQ6fiRqh1VY/8GY0JSx0kb +IinhgNmAJh8dsQ7QN9sYTnWD3TPkYsm9tauGDd0d9L8D2hYjZmU5QtfApo65sfaFZDjvzW3tOewa ASEiU7CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQNQ8-00865q-GE; Wed, 15 Sep 2021 05:25:20 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQNQ4-008653-JD for linux-arm-kernel@lists.infradead.org; Wed, 15 Sep 2021 05:25:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5943231B; Tue, 14 Sep 2021 22:25:15 -0700 (PDT) Received: from [10.163.70.189] (unknown [10.163.70.189]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 256783F719; Tue, 14 Sep 2021 22:25:11 -0700 (PDT) Subject: Re: [PATCH v3 05/10] coresight: trbe: Drop duplicate TRUNCATE flags To: Suzuki K Poulose , coresight@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, tamas.zsoldos@arm.com, jinlmao@qti.qualcomm.com, al.grant@arm.com, denik@google.com References: <20210914102641.1852544-1-suzuki.poulose@arm.com> <20210914102641.1852544-6-suzuki.poulose@arm.com> From: Anshuman Khandual Message-ID: <47f5a2cd-c435-7804-c3ff-06b8d266ee9b@arm.com> Date: Wed, 15 Sep 2021 10:56:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210914102641.1852544-6-suzuki.poulose@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_222516_744608_A790F6A0 X-CRM114-Status: GOOD ( 24.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/14/21 3:56 PM, Suzuki K Poulose wrote: > We mark the buffer as TRUNCATED when there is no space left > in the buffer. But we do it at different points. > __trbe_normal_offset() > and also, at all the callers of the above function via > compute_trbe_buffer_limit(), when the limit == base (i.e > offset = 0 as returned by the __trbe_normal_offset()). > > So, given that the callers already mark the buffer as TRUNCATED > drop the caller inside the __trbe_normal_offset(). > > This is in preparation to moving the handling of TRUNCATED > into a central place. > > Cc: Anshuman Khandual > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Leo Yan > Signed-off-by: Suzuki K Poulose Reviewed-by: Anshuman Khandual A small nit though. > --- > Change since v2: > - Added the flag for trbe_handle_spurious() - Anshuman > --- > drivers/hwtracing/coresight/coresight-trbe.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index 81bf183a73a1..5297b11f26b7 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -252,13 +252,9 @@ static unsigned long __trbe_normal_offset(struct perf_output_handle *handle) > * trbe_base trbe_base + nr_pages > * > * Perf aux buffer does not have any space for the driver to write into. > - * Just communicate trace truncation event to the user space by marking > - * it with PERF_AUX_FLAG_TRUNCATED. Should not this comment be moved, where PERF_AUX_FLAG_TRUNCATED gets marked after this change ? > */ > - if (!handle->size) { > - perf_aux_output_flag(handle, PERF_AUX_FLAG_TRUNCATED); > + if (!handle->size) > return 0; > - } > > /* Compute the tail and wakeup indices now that we've aligned head */ > tail = PERF_IDX2OFF(handle->head + handle->size, buf); > @@ -360,7 +356,6 @@ static unsigned long __trbe_normal_offset(struct perf_output_handle *handle) > return limit; > > trbe_pad_buf(handle, handle->size); > - perf_aux_output_flag(handle, PERF_AUX_FLAG_TRUNCATED); > return 0; > } > > @@ -688,6 +683,7 @@ static void trbe_handle_spurious(struct perf_output_handle *handle) > buf->trbe_write = buf->trbe_base + PERF_IDX2OFF(handle->head, buf); > if (buf->trbe_limit == buf->trbe_base) { > trbe_drain_and_disable_local(); > + perf_aux_output_flag(handle, PERF_AUX_FLAG_TRUNCATED); > return; > } > trbe_enable_hw(buf); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel