From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F112BC54E67 for ; Thu, 28 Mar 2024 14:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cjTZ7YsKrkKFpcKB5l35MmX5rp9C3hXHaNLlzYgequ8=; b=Bp7khs1uVhqsQE mRDDxxSBPOmQpIKn3A2U+TNIdyzXSBiKy2yYaXBBGuPO3CN1UVVpVfl65zHCoOfhjoMwtwbrBULtq wlobfC/mkBLqon8BnfiIYearPhLQHNiA+PrCUa46Qi7wfb5h5/6B0BCKJtrU72PKdt+dcVHOpB6Ul +/9d0gQXR4wXZhtw8kpizS7JN65PL28crlv3KeeqD7rPnlW/RYA/uXd+PZ8miSUoBcrotEAMlCAQP wabP59N3blM/UoYrHsbmQxv/tAtSuSnFZO/Vo1sdN0im5d+QQDZYy1mA7U1p8oot567CJsWP+VJUT NZpR7gLqhrPjx4k9mj1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpqb1-0000000EI7W-3ej4; Thu, 28 Mar 2024 14:19:12 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpqaz-0000000EI5r-0t98 for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2024 14:19:10 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2FBB68818C; Thu, 28 Mar 2024 15:19:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1711635545; bh=SonutgD18/IvJSdqtAfr8jPeMT+pqsEe9jBU5XMTvVM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hs3RqxMJQCoEI9woF3jNnqv5D63sMTWJjGzivOtDRxDy2hrbQeSd7eSwq7O6GgRC0 xaOgPFJVGNvbkgDPdfPH7WEBN83mQhn2m+ViwPZEZAF5/FwwM7JgCL7wCxACaGR03J l/8aEwaAXPvaaOKTnHuKLpUhAj3b39PsM67Q09qLJW6wsm2NFscYMT6ccD2NVxU/df GJc4OAWnxF5RmGXXjR/VpLiR70+M/hugonzdB3zGJyr3j5r6kB8eACLloha5PyXXEN Up6lSzcfFAMheNlq0c+0vsVsnlL3o/GNGtIiF6xKhO8UrpHIA1DAQmi+00rM8RjCOA evKusuNNo5nNg== Message-ID: <480d4064-b553-4005-ad98-499a862703ff@denx.de> Date: Thu, 28 Mar 2024 15:19:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/1] dt-bindings: net: dwmac: Document STM32 property st,ext-phyclk To: Christophe Roullier , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240328140803.324141-1-christophe.roullier@foss.st.com> <20240328140803.324141-2-christophe.roullier@foss.st.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <20240328140803.324141-2-christophe.roullier@foss.st.com> X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_071909_438166_8823FB73 X-CRM114-Status: GOOD ( 15.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/28/24 3:08 PM, Christophe Roullier wrote: [...] > | RMII | - | eth-ck | eth-ck | n/a | > | | | st,ext-phyclk | st,eth-ref-clk-sel | | > | | | | or st,ext-phyclk | | > > --------------------------------------------------------------------------- > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Christophe Roullier > --- > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > index fc8c96b08d7dc..b35eae80ed6ac 100644 > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > @@ -82,6 +82,13 @@ properties: > Should be phandle/offset pair. The phandle to the syscon node which > encompases the glue register, and the offset of the control register > > +st,ext-phyclk: Don't you need two spaces in front of the 'st,' here ? > + description: > + set this property in RMII mode when you have PHY without crystal 50MHz and want to > + select RCC clock instead of ETH_REF_CLK. OR in RGMII mode when you want to select > + RCC clock instead of ETH_CLK125. > + type: boolean > + With that fixed: Reviewed-by: Marek Vasut _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel