From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 067A0C636CC for ; Tue, 31 Jan 2023 07:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AT5BDfJppokPdl8UfzG3Byhz4WKccATBWniZwNj79gk=; b=WQKcdD7B64xVB/ HnSCY3aCh00JJKtK1Fr9wUOfTPlw9R0SILm8g+Qdk+1iX1GIPKrFvz3Z1c4bFNdmom5D+I5FhVdeb yuXne6ws00fJbQZ/avZEeax42kJHlBIymbC9vrqgbKx2BtZrAe3Ky4/2UcOIzbjl+KMc2mcN0Tdkg rmgjL2BBNWKSSnD7OUMbz6BnUkNw1kCKQEHfZ9d/T2Xb4XpGzeUS9jv1kMbrc9nGN12rV5m42TqVy nncFpHBJisY9ixFbNjF9XwgOIawLWwXyM8o1djC7MvdbYAX2sxvj1w5HJvaybXvPJNUNsO6ixT7ji mYhHntRpQFP+Htq3ix6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMl3b-006ZXN-93; Tue, 31 Jan 2023 07:27:55 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMl3Y-006ZWR-3k for linux-arm-kernel@lists.infradead.org; Tue, 31 Jan 2023 07:27:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1675150072; x=1706686072; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xNwizkJY+v60PNO9GG4mkHO1ahzr03HqLvbQsMxs1tQ=; b=YRK1+ZBVh4r1P77NN6gqBFEeAwOfYkpdAaSxu+lv9kq+9wGhZsQlQ+G9 eZdWsTja/1FeP6NBE8uzjLIzFQaCY9Eh0IoTq2sb9gJLXhKvzAq7/gUQ1 3UxD0y52PkC3rXv/V94k/2yzWcXzR16wK7V4SQjh0V8vr3M4yFhpaD+1+ 53s73K53m+kAgl8qYkUBoiKEVEgIv2hicsjCR6FtXwpNyQSIwRjxBCarx FxAYUgihSkrkybEHk3l2aeMMxUIXxOt7mGXRLpHEIUNXjD2489+iCTSZA G8HwsE8KW9loAwxcESWwsFv/vYiGnTeKmKRxC3NIC0nBM8rVnWLO6d3vI A==; X-IronPort-AV: E=Sophos;i="5.97,259,1669071600"; d="scan'208";a="28758465" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 31 Jan 2023 08:27:48 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 31 Jan 2023 08:27:48 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 31 Jan 2023 08:27:48 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1675150068; x=1706686068; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xNwizkJY+v60PNO9GG4mkHO1ahzr03HqLvbQsMxs1tQ=; b=krbHB8bD1twLxw4NPWwxL7tuxe05ZDg4cVx300IjLc2qmrNXbf7AOsn1 TpN7ctjIYorY9n3HIfny1Ar3BwBWOKZyHjGWuRpiAhWr8Fq0i2s9To3pK hZ0nGY0I/uI6Y+xVuNd6qidOUiqK5TDCLoZ+V0Vl4ZJpObEWbE6gF/Qmh jOpchq9ZGcZPmJpE+WlFzdkjCvwhMDp/xHrjSRWa7cZuT5NpOyZghdF/i NDR3BEt2QLm+I6W6jMnN4QvhA/ZbUOmtSmUdSXzzQ/5B+CSR3GX8u5HsL F59HeK35gXgdb9MFTkp9Xz7zQcp1JGDYtq8qs3kmf5Rj9Pl6ZbbNCZiqE Q==; X-IronPort-AV: E=Sophos;i="5.97,259,1669071600"; d="scan'208";a="28758463" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 31 Jan 2023 08:27:48 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 2B58B280056; Tue, 31 Jan 2023 08:27:48 +0100 (CET) From: Alexander Stein To: Rasmus Villemoes Cc: Marek Vasut , Jagan Teki , linux-arm-kernel@lists.infradead.org, Laurent.pinchart@ideasonboard.com, aford173@gmail.com, andrzej.hajda@intel.com, dri-devel@lists.freedesktop.org, frieder.schrempf@kontron.de, inki.dae@samsung.com, kyungmin.park@samsung.com, linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-samsung-soc@vger.kernel.org, m.szyprowski@samsung.com, matteo.lisi@engicam.com, sw0312.kim@samsung.com, tharvey@gateworks.com Subject: Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge Date: Tue, 31 Jan 2023 08:27:45 +0100 Message-ID: <4811510.31r3eYUQgx@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20230126144427.607098-1-jagan@amarulasolutions.com> <31ccc974-4b01-ae47-9505-626617f07758@denx.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_232752_718941_8ADDE92B X-CRM114-Status: GOOD ( 24.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rasmus, Am Montag, 30. Januar 2023, 13:45:38 CET schrieb Rasmus Villemoes: > On 27/01/2023 12.30, Marek Vasut wrote: > > On 1/27/23 12:04, Jagan Teki wrote: > >>> Thanks, but that's exactly what I'm doing, and I don't see any > >>> modification of imx8mp.dtsi in that branch. I'm basically looking for > >>> help to do the equivalent of > >>> > >>> 88775338cd58 - arm64: dts: imx8mm: Add MIPI DSI pipeline > >>> f964f67dd6ee - arm64: dts: imx8mm: Add eLCDIF node support > >>> > >>> for imx8mp in order to test those patches on our boards (we have two > >>> variants). > >> > >> Marek, any help here, thanks. > > > > Try attached patch. > > Thanks. I removed the lcdif2 and ldb nodes I had added from Alexander's > patch (94e6197dadc9 in linux-next) in order to apply it. I get a couple > of errors during boot: > > clk: /soc@0/bus@32c00000/mipi_dsi@32e60000: failed to reparent > media_apb to sys_pll1_266m: -22 > > and enabling a pr_debug in clk_core_set_parent_nolock() shows that this > is because > > clk_core_set_parent_nolock: clk sys_pll1_266m can not be parent of clk > media_apb > > Further, the mipi_dsi fails to probe due to > > /soc@0/bus@32c00000/mipi_dsi@32e60000: failed to get > 'samsung,burst-clock-frequency' property > > All other .dtsi files seem to have those samsung,burst-clock-frequency > and samsung,esc-clock-frequency properties, so I suppose those should > also go into the imx8mp.dtsi and are not something that the board .dts > file should supply(?). > > > [There's also some differences between your patch and Alexander's > regarding the lcdif2 and ldb nodes, so while my lvds display still sorta > works, I get > > fsl-ldb 32ec0000.blk-ctrl:lvds-ldb: Configured LDB clock (297000000 > Hz) does not match requested LVDS clock: 346500000 Hz > > and the image is oddly distorted/shifted. But I suppose that's > orthogonal to getting the lcdif1 -> mipi-dsi -> ... pipeline working.] It seems my patch indicates exactly what's your problem here. Your clock rate configuration for LCDIF2 and LDB are not compatible (ratio 1:7). For now manual clock config is necessary in this case. Check the clock tree in debugfs how your root clocks are configured and if it affects lcdif1 and lcdif2. Best regards Alexander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel