From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC26C10DCE for ; Wed, 11 Mar 2020 01:32:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A06AB205ED for ; Wed, 11 Mar 2020 01:32:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Kqq/GCFW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A06AB205ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=euvNB0qFkYaGekOuy5lgHN461TPHVQYSj58lQXR7vmQ=; b=Kqq/GCFW7qHijh kTmEZIy6kQklWTFcE8D1JIKI2hNq0ph2TiCnvgdut16HlOpPy86+g3cn2YI2tLKiK1RdlnK/7v/nW kgQfuQ+fjtwf9Zi1QeQwbI/jPLwmsWjJIKmLobzoFnOPIKOfxU+P0QX1tv+kHjsZku9Q5LwRpmNl7 pDsBuxZ5ezsETBQi3i6AUS6E2QdLALjSGEvDRU5MEJWAvONEpWgOSXG9xnLnM+I/i3ZMn/lERgDQF mOYcQ9B1eqE7IIKld5CztRIU2xVNhblKuRQvtpAA+Aotngg3kUMVgxOO7qsGqdlsL1HdMNEmE7Iou IbKkm1KUOBGDZApyUa0Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBqEE-0001My-GX; Wed, 11 Mar 2020 01:32:10 +0000 Received: from kernel.crashing.org ([76.164.61.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBqEA-0001ML-DJ for linux-arm-kernel@lists.infradead.org; Wed, 11 Mar 2020 01:32:09 +0000 Received: from localhost (gate.crashing.org [63.228.1.57]) (authenticated bits=0) by kernel.crashing.org (8.14.7/8.14.7) with ESMTP id 02B1VNCw010399 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 10 Mar 2020 20:31:27 -0500 Message-ID: <481e9b7d40c51505518a34ddc2515d3200dbf158.camel@kernel.crashing.org> Subject: Re: [PATCH v2] usb: gadget: aspeed: improve vhub port irq handling From: Benjamin Herrenschmidt To: rentao.bupt@gmail.com, Felipe Balbi , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , Chunfeng Yun , Stephen Boyd , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, taoren@fb.com Date: Wed, 11 Mar 2020 12:31:22 +1100 In-Reply-To: <20200305234746.1002-1-rentao.bupt@gmail.com> References: <20200305234746.1002-1-rentao.bupt@gmail.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200310_183206_840068_B98F2C7D X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-03-05 at 15:47 -0800, rentao.bupt@gmail.com wrote: > From: Tao Ren > > This patch evaluates vhub ports' irq mask before going through per-port > irq handling one by one, which helps to speed up irq handling in case > there is no port interrupt. > > Signed-off-by: Tao Ren > --- > Changes in v2: > - use "for_each_set_bit" to speed up port irq handling. > > drivers/usb/gadget/udc/aspeed-vhub/core.c | 11 ++++++++--- > drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 8 +++----- > 2 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c b/drivers/usb/gadget/udc/aspeed-vhub/core.c > index f8d35dd60c34..af2dbd405361 100644 > --- a/drivers/usb/gadget/udc/aspeed-vhub/core.c > +++ b/drivers/usb/gadget/udc/aspeed-vhub/core.c > @@ -134,11 +134,14 @@ static irqreturn_t ast_vhub_irq(int irq, void *data) > } > > /* Handle device interrupts */ > - for (i = 0; i < vhub->max_ports; i++) { > - u32 dev_mask = VHUB_IRQ_DEVICE1 << i; > + if (istat & vhub->port_irq_mask) { > + int offset = VHUB_IRQ_DEV1_BIT; > + int size = VHUB_IRQ_DEV1_BIT + vhub->max_ports; > > - if (istat & dev_mask) > + for_each_set_bit_from(offset, (unsigned long *)&istat, size) That type cast is very bad. It will not work on big endian for example (yes this driver isn't used on big endian today but still). Please assign istat to an unsigned long (or make it unsigned long to begin with). > + i = offset - VHUB_IRQ_DEV1_BIT; > ast_vhub_dev_irq(&vhub->ports[i].dev); > + } > } > > /* Handle top-level vHub EP0 interrupts */ > @@ -332,6 +335,8 @@ static int ast_vhub_probe(struct platform_device *pdev) > > spin_lock_init(&vhub->lock); > vhub->pdev = pdev; > + vhub->port_irq_mask = GENMASK(VHUB_IRQ_DEV1_BIT + vhub->max_ports - 1, > + VHUB_IRQ_DEV1_BIT); > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > vhub->regs = devm_ioremap_resource(&pdev->dev, res); > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/vhub.h b/drivers/usb/gadget/udc/aspeed-vhub/vhub.h > index fac79ef6d669..23a1ac91f8d2 100644 > --- a/drivers/usb/gadget/udc/aspeed-vhub/vhub.h > +++ b/drivers/usb/gadget/udc/aspeed-vhub/vhub.h > @@ -51,14 +51,11 @@ > #define VHUB_CTRL_UPSTREAM_CONNECT (1 << 0) > > /* IER & ISR */ > +#define VHUB_IRQ_DEV1_BIT 9 > #define VHUB_IRQ_USB_CMD_DEADLOCK (1 << 18) > #define VHUB_IRQ_EP_POOL_NAK (1 << 17) > #define VHUB_IRQ_EP_POOL_ACK_STALL (1 << 16) > -#define VHUB_IRQ_DEVICE5 (1 << 13) > -#define VHUB_IRQ_DEVICE4 (1 << 12) > -#define VHUB_IRQ_DEVICE3 (1 << 11) > -#define VHUB_IRQ_DEVICE2 (1 << 10) > -#define VHUB_IRQ_DEVICE1 (1 << 9) > +#define VHUB_IRQ_DEVICE1 (1 << (VHUB_IRQ_DEV1_BIT)) > #define VHUB_IRQ_BUS_RESUME (1 << 8) > #define VHUB_IRQ_BUS_SUSPEND (1 << 7) > #define VHUB_IRQ_BUS_RESET (1 << 6) > @@ -402,6 +399,7 @@ struct ast_vhub { > /* Per-port info */ > struct ast_vhub_port *ports; > u32 max_ports; > + u32 port_irq_mask; > > /* Generic EP data structures */ > struct ast_vhub_ep *epns; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel