[PATCH v6 0/1] acpi: apei: Bug fix to enable APEI support for ARMv8

[PATCH v6 0/1] acpi: apei: Bug fix to enable APEI support for ARMv8

[Loc Ho]

v6:
* Update the patch description

v5:
* Remove the patch set 1/2 as it was accepted
* Fix the signed-off-by using Co-authored-by

v4:
* Update patch commit log for gsi.c patch
* Make change to be 80 column aligned

v3
* Change the title of the patch to reflect the patch
* Completely dropped the driver. Instead, move completely to the FW by
  accessing the GIC directly.
* Fix a bug with function acpi_gsi_to_irq
* Enable APEI multiple GHES source to share an single external IRQ

v2
* Make all code more generic naming
* Still waiting for comment from Linaro folks on APEI

---
Loc Ho (1):
  acpi: apei: Enable APEI multiple GHES source to share an single
    external IRQ

 drivers/acpi/apei/ghes.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.8.3.1

[PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

[Loc Ho]

X-Gene platforms describe multiple GHES error sources with the same hardware
error notification type (external interrupt) and interrupt number.
Change the GHES interrupt request to support sharing the same IRQ.

Co-authored-by: Tuan Phan <tphan@apm.com>
Signed-off-by: Loc Ho <lho@apm.com>
---
 drivers/acpi/apei/ghes.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index d661d45..eed09fc 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
 			       generic->header.source_id);
 			goto err_edac_unreg;
 		}
-		rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
+		rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
+				 "GHES IRQ", ghes);
 		if (rc) {
 			pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
 			       generic->header.source_id);
-- 
1.8.3.1

[PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

[Borislav Petkov]

On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> X-Gene platforms describe multiple GHES error sources with the same hardware
> error notification type (external interrupt) and interrupt number.
> Change the GHES interrupt request to support sharing the same IRQ.
> 
> Co-authored-by: Tuan Phan <tphan@apm.com>
> Signed-off-by: Loc Ho <lho@apm.com>
> ---
>  drivers/acpi/apei/ghes.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index d661d45..eed09fc 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
>  			       generic->header.source_id);
>  			goto err_edac_unreg;
>  		}
> -		rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> +		rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> +				 "GHES IRQ", ghes);
>  		if (rc) {
>  			pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
>  			       generic->header.source_id);
> -- 

Acked-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imend?rffer, Jane Smithard, Graham Norton, HRB 21284 (AG N?rnberg)
-- 

[PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

[Rafael J. Wysocki]

On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote:
> On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> > X-Gene platforms describe multiple GHES error sources with the same hardware
> > error notification type (external interrupt) and interrupt number.
> > Change the GHES interrupt request to support sharing the same IRQ.
> > 
> > Co-authored-by: Tuan Phan <tphan@apm.com>
> > Signed-off-by: Loc Ho <lho@apm.com>
> > ---
> >  drivers/acpi/apei/ghes.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > index d661d45..eed09fc 100644
> > --- a/drivers/acpi/apei/ghes.c
> > +++ b/drivers/acpi/apei/ghes.c
> > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
> >  			       generic->header.source_id);
> >  			goto err_edac_unreg;
> >  		}
> > -		rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> > +		rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> > +				 "GHES IRQ", ghes);
> >  		if (rc) {
> >  			pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
> >  			       generic->header.source_id);
> 
> Acked-by: Borislav Petkov <bp@suse.de>

OK

Should I apply this or will Tony do that?

[PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

[Rafael J. Wysocki]

On Sunday, July 23, 2017 12:01:10 AM Rafael J. Wysocki wrote:
> On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote:
> > On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> > > X-Gene platforms describe multiple GHES error sources with the same hardware
> > > error notification type (external interrupt) and interrupt number.
> > > Change the GHES interrupt request to support sharing the same IRQ.
> > > 
> > > Co-authored-by: Tuan Phan <tphan@apm.com>
> > > Signed-off-by: Loc Ho <lho@apm.com>
> > > ---
> > >  drivers/acpi/apei/ghes.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > > index d661d45..eed09fc 100644
> > > --- a/drivers/acpi/apei/ghes.c
> > > +++ b/drivers/acpi/apei/ghes.c
> > > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
> > >  			       generic->header.source_id);
> > >  			goto err_edac_unreg;
> > >  		}
> > > -		rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> > > +		rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> > > +				 "GHES IRQ", ghes);
> > >  		if (rc) {
> > >  			pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
> > >  			       generic->header.source_id);
> > 
> > Acked-by: Borislav Petkov <bp@suse.de>
> 
> OK
> 
> Should I apply this or will Tony do that?

So am I suppsed to drop this?

[PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

[Borislav Petkov]

On Wed, Jul 26, 2017 at 08:57:03PM +0200, Rafael J. Wysocki wrote:
> > Should I apply this or will Tony do that?
> 
> So am I suppsed to drop this?

Well, as suggested in another mail, I think it'll be best if Tony and I
put ourselves as reviewers for the APEI crap and you still collect it.

Unless you want to give it to us and we can arrange some pull order to
send it to you.

What do you prefer?

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imend?rffer, Jane Smithard, Graham Norton, HRB 21284 (AG N?rnberg)
-- 

[PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

[Rafael J. Wysocki]

On Thu, Jul 27, 2017 at 7:58 AM, Borislav Petkov <bp@suse.de> wrote:
> On Wed, Jul 26, 2017 at 08:57:03PM +0200, Rafael J. Wysocki wrote:
>> > Should I apply this or will Tony do that?
>>
>> So am I suppsed to drop this?
>
> Well, as suggested in another mail, I think it'll be best if Tony and I
> put ourselves as reviewers for the APEI crap and you still collect it.
>
> Unless you want to give it to us and we can arrange some pull order to
> send it to you.
>
> What do you prefer?

I can collect it, no problem.

So from now on I will pick up APEI things with ACKs from you or Tony.

Thanks,
Rafael

[PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

[Borislav Petkov]

On Thu, Jul 27, 2017 at 04:34:59PM +0200, Rafael J. Wysocki wrote:
> I can collect it, no problem.
> 
> So from now on I will pick up APEI things with ACKs from you or Tony.

If you agree with that, that is. But we kinda do that already, more or
less. :-)

Then I guess we should add something like this so that get_maintainer
finds us:

diff --git a/MAINTAINERS b/MAINTAINERS
index f66488dfdbc9..985413fb5d83 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -310,6 +310,14 @@ F:	drivers/pci/*/*acpi*
 F:	drivers/pci/*/*/*acpi*
 F:	tools/power/acpi/
 
+ACPI APEI
+M:	"Rafael J. Wysocki" <rjw@rjwysocki.net>
+M:	Len Brown <lenb@kernel.org>
+L:	linux-acpi at vger.kernel.org
+R:	Tony Luck <tony.luck@intel.com>
+R:	Borislav Petkov <bp@alien8.de>
+F:	drivers/acpi/apei/
+
 ACPI COMPONENT ARCHITECTURE (ACPICA)
 M:	Robert Moore <robert.moore@intel.com>
 M:	Lv Zheng <lv.zheng@intel.com>

---

Provided Tony agrees though... I'd venture a guess and say that he
doesn't have a choice, woahahhahaha...

:-)))

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imend?rffer, Jane Smithard, Graham Norton, HRB 21284 (AG N?rnberg)
-- 

[PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

[Rafael J. Wysocki]

On Thu, Jul 27, 2017 at 4:49 PM, Borislav Petkov <bp@suse.de> wrote:
> On Thu, Jul 27, 2017 at 04:34:59PM +0200, Rafael J. Wysocki wrote:
>> I can collect it, no problem.
>>
>> So from now on I will pick up APEI things with ACKs from you or Tony.
>
> If you agree with that, that is. But we kinda do that already, more or
> less. :-)
>
> Then I guess we should add something like this so that get_maintainer
> finds us:
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f66488dfdbc9..985413fb5d83 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -310,6 +310,14 @@ F: drivers/pci/*/*acpi*
>  F:     drivers/pci/*/*/*acpi*
>  F:     tools/power/acpi/
>
> +ACPI APEI
> +M:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
> +M:     Len Brown <lenb@kernel.org>
> +L:     linux-acpi at vger.kernel.org
> +R:     Tony Luck <tony.luck@intel.com>
> +R:     Borislav Petkov <bp@alien8.de>
> +F:     drivers/acpi/apei/
> +
>  ACPI COMPONENT ARCHITECTURE (ACPICA)
>  M:     Robert Moore <robert.moore@intel.com>
>  M:     Lv Zheng <lv.zheng@intel.com>
>
> ---
>
> Provided Tony agrees though... I'd venture a guess and say that he
> doesn't have a choice, woahahhahaha...
>
> :-)))

Well, I guess send this officially with a CC:Tony and see what he says. :-)

[PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

[Luck, Tony]

>> Provided Tony agrees though... I'd venture a guess and say that he
>> doesn't have a choice, woahahhahaha...
>>
>> :-)))
>
> Well, I guess send this officially with a CC:Tony and see what he says. :-)

That's definitely part of my day job ... so yes, please add me as a reviewer.

-Tony

[PATCH] MAINTAINERS: Add Tony and Boris as ACPI/APEI reviewers

[Borislav Petkov]

Since this piece of the ACPI pile is doing RAS, it is perhaps prudent if
we at least paid attention to it and the direction it takes. So add Tony
and me as reviewers.

Signed-off-by: Borislav Petkov <bp@suse.de>
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index f66488dfdbc9..985413fb5d83 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -310,6 +310,14 @@ F:	drivers/pci/*/*acpi*
 F:	drivers/pci/*/*/*acpi*
 F:	tools/power/acpi/
 
+ACPI APEI
+M:	"Rafael J. Wysocki" <rjw@rjwysocki.net>
+M:	Len Brown <lenb@kernel.org>
+L:	linux-acpi at vger.kernel.org
+R:	Tony Luck <tony.luck@intel.com>
+R:	Borislav Petkov <bp@alien8.de>
+F:	drivers/acpi/apei/
+
 ACPI COMPONENT ARCHITECTURE (ACPICA)
 M:	Robert Moore <robert.moore@intel.com>
 M:	Lv Zheng <lv.zheng@intel.com>
-- 
2.14.0.rc0

SUSE Linux GmbH, GF: Felix Imend?rffer, Jane Smithard, Graham Norton, HRB 21284 (AG N?rnberg)
-- 

[PATCH] MAINTAINERS: Add Tony and Boris as ACPI/APEI reviewers

[Luck, Tony]

> Since this piece of the ACPI pile is doing RAS, it is perhaps prudent if
> we at least paid attention to it and the direction it takes. So add Tony
> and me as reviewers.

Acked-by: Tony Luck <tony.luck@intel.com>
 

[PATCH] MAINTAINERS: Add Tony and Boris as ACPI/APEI reviewers

[Rafael J. Wysocki]

On Friday, July 28, 2017 05:02:11 PM Luck, Tony wrote:
> > Since this piece of the ACPI pile is doing RAS, it is perhaps prudent if
> > we at least paid attention to it and the direction it takes. So add Tony
> > and me as reviewers.
> 
> Acked-by: Tony Luck <tony.luck@intel.com>

Applied, thanks!

[PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

[Rafael J. Wysocki]

On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote:
> On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> > X-Gene platforms describe multiple GHES error sources with the same hardware
> > error notification type (external interrupt) and interrupt number.
> > Change the GHES interrupt request to support sharing the same IRQ.
> > 
> > Co-authored-by: Tuan Phan <tphan@apm.com>
> > Signed-off-by: Loc Ho <lho@apm.com>
> > ---
> >  drivers/acpi/apei/ghes.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > index d661d45..eed09fc 100644
> > --- a/drivers/acpi/apei/ghes.c
> > +++ b/drivers/acpi/apei/ghes.c
> > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
> >  			       generic->header.source_id);
> >  			goto err_edac_unreg;
> >  		}
> > -		rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> > +		rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> > +				 "GHES IRQ", ghes);
> >  		if (rc) {
> >  			pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
> >  			       generic->header.source_id);
> 
> Acked-by: Borislav Petkov <bp@suse.de>

Applied, thanks!