From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Joel Stanley" <joel@jms.id.au>,
openbmc@lists.ozlabs.org,
"Andrew Geissler" <geissonator@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH 1/2] ARM: dts: rainier, everest: Add TPM reset GPIO
Date: Tue, 27 Jul 2021 13:28:57 +0930 [thread overview]
Message-ID: <4836fc6e-1b82-4cac-939c-a7d2052a9ea4@www.fastmail.com> (raw)
In-Reply-To: <20210727033319.473152-2-joel@jms.id.au>
On Tue, 27 Jul 2021, at 13:03, Joel Stanley wrote:
> The GPIO is used to place the BMC-connected TPM in reset. This state is
> latched until the BMC is next reset, blocking access to the TPM for that
> boot.
>
> On both machines this net is called TPM_RESET_LATCH_B.
Hmm, unless we have different schematics where this has been changed,
it's TPM_RESET_LATCH_N for Rainier (Ingraham) but TPM_RESET_LATCH_B for
Everest (Tola).
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts | 2 +-
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
> b/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
> index aa24cac8e5be..4536cd538af9 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts
> @@ -253,7 +253,7 @@ &gpio0 {
> /*O0-O7*/ "","","","","","","","",
> /*P0-P7*/ "","","","","led-pcieslot-power","","","",
> /*Q0-Q7*/ "","","","","","","","",
> - /*R0-R7*/ "","","","","","I2C_FLASH_MICRO_N","","",
> + /*R0-R7*/ "bmc-tpm-reset","","","","","I2C_FLASH_MICRO_N","","",
> /*S0-S7*/ "","","","","","","","",
> /*T0-T7*/ "","","","","","","","",
> /*U0-U7*/ "","","","","","","","",
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 481d0ee1f85f..06b3d1573780 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -271,7 +271,7 @@ &gpio0 {
> /*O0-O7*/ "","","","usb-power","","","","",
> /*P0-P7*/ "","","","","pcieslot-power","","","",
> /*Q0-Q7*/ "cfam-reset","","","","","","","",
> - /*R0-R7*/ "","","","","","","","",
> + /*R0-R7*/ "bmc-tpm-reset","","","","","","","",
Andrew G (/ Joel): we should probably add a "*-reset" class of GPIOs to
the documentation ([1]). bmc-tpm-reset seems fine to me.
We should probably resolve the net name issue, but other than that:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
[1] https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-27 4:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 3:33 [PATCH 0/2] ARM: dts: aspeed: Add TPM GPIO names Joel Stanley
2021-07-27 3:33 ` [PATCH 1/2] ARM: dts: rainier, everest: Add TPM reset GPIO Joel Stanley
2021-07-27 3:58 ` Andrew Jeffery [this message]
2021-07-27 3:33 ` [PATCH 2/2] ARM: dts: aspeed: tacoma: " Joel Stanley
2021-07-27 4:04 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4836fc6e-1b82-4cac-939c-a7d2052a9ea4@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=geissonator@gmail.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).