From: elfring@users.sourceforge.net (SF Markus Elfring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] coresight: etb10: Improve a size determination in etb_alloc_buffer()
Date: Mon, 15 May 2017 21:34:33 +0200 [thread overview]
Message-ID: <483aafb4-c864-058b-6e61-1189be427d27@users.sourceforge.net> (raw)
In-Reply-To: <CANLsYkwxkXZ5t5L1_=2e9FLdkwOg7KUT=u2o-KeEfH8QYOfStA@mail.gmail.com>
>> +++ b/drivers/hwtracing/coresight/coresight-etb10.c
>> @@ -278,8 +278,7 @@ static void *etb_alloc_buffer(struct coresight_device *csdev, int cpu,
>> if (cpu == -1)
>> cpu = smp_processor_id();
>> node = cpu_to_node(cpu);
>> -
>> - buf = kzalloc_node(sizeof(struct cs_buffers), GFP_KERNEL, node);
>> + buf = kzalloc_node(sizeof(*buf), GFP_KERNEL, node);
>
> I'm fine with this change but if it's going to happen, it has to be in
> all the coresight drivers and not just this one - please respin with
> all instances fixed. One patch per driver would be much appreciated.
Do you imagine that any more modules are affected in a similar way
for this software area?
How do you think about other update suggestions from my selection
which are waiting for a corresponding review?
Regards,
Markus
prev parent reply other threads:[~2017-05-15 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 18:50 [PATCH 0/3] CoreSight-ETB10: Adjustments for three function implementations SF Markus Elfring
2017-05-12 18:51 ` [PATCH 1/3] coresight: etb10: Delete an error message for a failed memory allocation in etb_probe() SF Markus Elfring
2017-05-15 17:44 ` Mathieu Poirier
2017-05-12 18:52 ` [PATCH 2/3] coresight: etb10: Fix a typo in a comment line SF Markus Elfring
2017-05-15 17:44 ` Mathieu Poirier
2017-05-12 18:53 ` [PATCH 3/3] coresight: etb10: Improve a size determination in etb_alloc_buffer() SF Markus Elfring
2017-05-15 17:47 ` Mathieu Poirier
2017-05-15 19:34 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483aafb4-c864-058b-6e61-1189be427d27@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).