From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: rockchip: replace gpio-key, wakeup with wakeup-source property
Date: Wed, 10 Feb 2016 00:32:51 +0100 [thread overview]
Message-ID: <48510660.EJbbczq5fX@phil> (raw)
In-Reply-To: <1454968512-11956-1-git-send-email-sudeep.holla@arm.com>
Hi Sudeep,
Am Montag, 8. Februar 2016, 21:55:12 schrieb Sudeep Holla:
> Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy
> "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup
> source.
>
> Few dts files assign value "1" to gpio-key,wakeup and in one instance a
> value "0" is assigned probably assuming it won't be enabled as a wakeup
> source. Since the presence of the boolean property indicates it is
> enabled, value of "0" have no value.
>
> This patch replaces the legacy "gpio-key,wakeup" with the unified
> "wakeup-source" property which inturn fixes the above mentioned issue.
>
> Cc: linux-rockchip at lists.infradead.org
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> arch/arm/boot/dts/rk3066a-bqcurie2.dts | 3 +--
> arch/arm/boot/dts/rk3066a-rayeager.dts | 2 +-
> arch/arm/boot/dts/rk3188-radxarock.dts | 2 +-
> arch/arm/boot/dts/rk3288-evb.dtsi | 2 +-
> arch/arm/boot/dts/rk3288-firefly.dtsi | 2 +-
> arch/arm/boot/dts/rk3288-popmetal.dts | 2 +-
> arch/arm/boot/dts/rk3288-r89.dts | 2 +-
> arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 2 +-
> arch/arm/boot/dts/rk3288-veyron.dtsi | 2 +-
> arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi | 2 +-
> arch/arm64/boot/dts/rockchip/rk3368-r88.dts | 2 +-
> 11 files changed, 11 insertions(+), 12 deletions(-)
>
> Hi Heiko,
>
> You can reviewed this, however there are couple of ARM64 dts additions.
> Also most of the other platform/SoC maintainers preferred to take it via
> their tree and few of these got missed during v4.5 merge window.
> Can you take it via your tree for v4.6 ?
I've split the patch in two, as the 32 and 64 bit devicetree parts go
through separate branches and applied both to their respective branches for
v4.6
Heiko
next prev parent reply other threads:[~2016-02-09 23:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 21:55 [PATCH] ARM: dts: rockchip: replace gpio-key, wakeup with wakeup-source property Sudeep Holla
2016-02-09 23:32 ` Heiko Stuebner [this message]
2016-02-10 9:51 ` [PATCH] ARM: dts: rockchip: replace gpio-key,wakeup " Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48510660.EJbbczq5fX@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox