linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/7] crypto: rk3288 - Use helper to set reqsize
@ 2023-12-18 16:46 ovidiu.panait
  2023-12-18 16:46 ` [PATCH 4/7] crypto: stm32/cryp " ovidiu.panait
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: ovidiu.panait @ 2023-12-18 16:46 UTC (permalink / raw)
  To: linux-crypto
  Cc: linux-kernel, herbert, davem, Ovidiu Panait, Heiko Stuebner,
	Corentin Labbe, linux-rockchip, linux-arm-kernel

From: Ovidiu Panait <ovidiu.panait@windriver.com>

The value of reqsize must only be changed through the helper.

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Corentin Labbe <clabbe@baylibre.com>
Cc: linux-rockchip@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org

 drivers/crypto/rockchip/rk3288_crypto_skcipher.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c
index da95747d973f..9393e10671c2 100644
--- a/drivers/crypto/rockchip/rk3288_crypto_skcipher.c
+++ b/drivers/crypto/rockchip/rk3288_crypto_skcipher.c
@@ -445,8 +445,8 @@ static int rk_cipher_tfm_init(struct crypto_skcipher *tfm)
 		return PTR_ERR(ctx->fallback_tfm);
 	}
 
-	tfm->reqsize = sizeof(struct rk_cipher_rctx) +
-		crypto_skcipher_reqsize(ctx->fallback_tfm);
+	crypto_skcipher_set_reqsize(tfm, sizeof(struct rk_cipher_rctx) +
+				    crypto_skcipher_reqsize(ctx->fallback_tfm));
 
 	return 0;
 }
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 4/7] crypto: stm32/cryp - Use helper to set reqsize
  2023-12-18 16:46 [PATCH 1/7] crypto: rk3288 - Use helper to set reqsize ovidiu.panait
@ 2023-12-18 16:46 ` ovidiu.panait
  2023-12-18 16:46 ` [PATCH 5/7] crypto: sl3516 " ovidiu.panait
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: ovidiu.panait @ 2023-12-18 16:46 UTC (permalink / raw)
  To: linux-crypto
  Cc: linux-kernel, herbert, davem, Ovidiu Panait, Maxime Coquelin,
	Alexandre Torgue, linux-stm32, linux-arm-kernel

From: Ovidiu Panait <ovidiu.panait@windriver.com>

The value of reqsize must only be changed through the helper.

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org

 drivers/crypto/stm32/stm32-cryp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c
index c3cbc2673338..11ad4ffdce0d 100644
--- a/drivers/crypto/stm32/stm32-cryp.c
+++ b/drivers/crypto/stm32/stm32-cryp.c
@@ -838,7 +838,7 @@ static int stm32_cryp_aead_one_req(struct crypto_engine *engine, void *areq);
 
 static int stm32_cryp_aes_aead_init(struct crypto_aead *tfm)
 {
-	tfm->reqsize = sizeof(struct stm32_cryp_reqctx);
+	crypto_aead_set_reqsize(tfm, sizeof(struct stm32_cryp_reqctx));
 
 	return 0;
 }
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 5/7] crypto: sl3516 - Use helper to set reqsize
  2023-12-18 16:46 [PATCH 1/7] crypto: rk3288 - Use helper to set reqsize ovidiu.panait
  2023-12-18 16:46 ` [PATCH 4/7] crypto: stm32/cryp " ovidiu.panait
@ 2023-12-18 16:46 ` ovidiu.panait
  2023-12-18 23:44   ` Linus Walleij
  2023-12-18 16:46 ` [PATCH 6/7] crypto: sun8i-ce " ovidiu.panait
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 9+ messages in thread
From: ovidiu.panait @ 2023-12-18 16:46 UTC (permalink / raw)
  To: linux-crypto
  Cc: linux-kernel, herbert, davem, Ovidiu Panait, Hans Ulli Kroll,
	Linus Walleij, Corentin Labbe, linux-arm-kernel

From: Ovidiu Panait <ovidiu.panait@windriver.com>

The value of reqsize must only be changed through the helper.

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Corentin Labbe <clabbe@baylibre.com>
Cc: linux-arm-kernel@lists.infradead.org

 drivers/crypto/gemini/sl3516-ce-cipher.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/gemini/sl3516-ce-cipher.c b/drivers/crypto/gemini/sl3516-ce-cipher.c
index 49dce9e0a834..583010b2d007 100644
--- a/drivers/crypto/gemini/sl3516-ce-cipher.c
+++ b/drivers/crypto/gemini/sl3516-ce-cipher.c
@@ -332,8 +332,8 @@ int sl3516_ce_cipher_init(struct crypto_tfm *tfm)
 		return PTR_ERR(op->fallback_tfm);
 	}
 
-	sktfm->reqsize = sizeof(struct sl3516_ce_cipher_req_ctx) +
-			 crypto_skcipher_reqsize(op->fallback_tfm);
+	crypto_skcipher_set_reqsize(sktfm, sizeof(struct sl3516_ce_cipher_req_ctx) +
+				    crypto_skcipher_reqsize(op->fallback_tfm));
 
 	dev_info(op->ce->dev, "Fallback for %s is %s\n",
 		 crypto_tfm_alg_driver_name(&sktfm->base),
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 6/7] crypto: sun8i-ce - Use helper to set reqsize
  2023-12-18 16:46 [PATCH 1/7] crypto: rk3288 - Use helper to set reqsize ovidiu.panait
  2023-12-18 16:46 ` [PATCH 4/7] crypto: stm32/cryp " ovidiu.panait
  2023-12-18 16:46 ` [PATCH 5/7] crypto: sl3516 " ovidiu.panait
@ 2023-12-18 16:46 ` ovidiu.panait
  2023-12-18 19:56   ` Jernej Škrabec
  2023-12-18 16:46 ` [PATCH 7/7] crypto: sun8i-ss " ovidiu.panait
  2023-12-29  3:28 ` [PATCH 1/7] crypto: rk3288 " Herbert Xu
  4 siblings, 1 reply; 9+ messages in thread
From: ovidiu.panait @ 2023-12-18 16:46 UTC (permalink / raw)
  To: linux-crypto
  Cc: linux-kernel, herbert, davem, Ovidiu Panait, Corentin Labbe,
	Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-arm-kernel,
	linux-sunxi

From: Ovidiu Panait <ovidiu.panait@windriver.com>

The value of reqsize must only be changed through the helper.

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Samuel Holland <samuel@sholland.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sunxi@lists.linux.dev

 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
index 8d4c42863a62..1262a7773ef3 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
@@ -431,8 +431,8 @@ int sun8i_ce_cipher_init(struct crypto_tfm *tfm)
 		return PTR_ERR(op->fallback_tfm);
 	}
 
-	sktfm->reqsize = sizeof(struct sun8i_cipher_req_ctx) +
-			 crypto_skcipher_reqsize(op->fallback_tfm);
+	crypto_skcipher_set_reqsize(sktfm, sizeof(struct sun8i_cipher_req_ctx) +
+				    crypto_skcipher_reqsize(op->fallback_tfm));
 
 	memcpy(algt->fbname,
 	       crypto_tfm_alg_driver_name(crypto_skcipher_tfm(op->fallback_tfm)),
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 7/7] crypto: sun8i-ss - Use helper to set reqsize
  2023-12-18 16:46 [PATCH 1/7] crypto: rk3288 - Use helper to set reqsize ovidiu.panait
                   ` (2 preceding siblings ...)
  2023-12-18 16:46 ` [PATCH 6/7] crypto: sun8i-ce " ovidiu.panait
@ 2023-12-18 16:46 ` ovidiu.panait
  2023-12-18 19:56   ` Jernej Škrabec
  2023-12-29  3:28 ` [PATCH 1/7] crypto: rk3288 " Herbert Xu
  4 siblings, 1 reply; 9+ messages in thread
From: ovidiu.panait @ 2023-12-18 16:46 UTC (permalink / raw)
  To: linux-crypto
  Cc: linux-kernel, herbert, davem, Ovidiu Panait, Corentin Labbe,
	Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-arm-kernel,
	linux-sunxi

From: Ovidiu Panait <ovidiu.panait@windriver.com>

The value of reqsize must only be changed through the helper.

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Samuel Holland <samuel@sholland.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sunxi@lists.linux.dev

 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
index 7fa359725ec7..9b9605ce8ee6 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
@@ -405,9 +405,8 @@ int sun8i_ss_cipher_init(struct crypto_tfm *tfm)
 		return PTR_ERR(op->fallback_tfm);
 	}
 
-	sktfm->reqsize = sizeof(struct sun8i_cipher_req_ctx) +
-			 crypto_skcipher_reqsize(op->fallback_tfm);
-
+	crypto_skcipher_set_reqsize(sktfm, sizeof(struct sun8i_cipher_req_ctx) +
+				    crypto_skcipher_reqsize(op->fallback_tfm));
 
 	memcpy(algt->fbname,
 	       crypto_tfm_alg_driver_name(crypto_skcipher_tfm(op->fallback_tfm)),
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 6/7] crypto: sun8i-ce - Use helper to set reqsize
  2023-12-18 16:46 ` [PATCH 6/7] crypto: sun8i-ce " ovidiu.panait
@ 2023-12-18 19:56   ` Jernej Škrabec
  0 siblings, 0 replies; 9+ messages in thread
From: Jernej Škrabec @ 2023-12-18 19:56 UTC (permalink / raw)
  To: linux-crypto, ovidiu.panait
  Cc: linux-kernel, herbert, davem, Ovidiu Panait, Corentin Labbe,
	Chen-Yu Tsai, Samuel Holland, linux-arm-kernel, linux-sunxi

Dne ponedeljek, 18. december 2023 ob 17:46:48 CET je ovidiu.panait@windriver.com napisal(a):
> From: Ovidiu Panait <ovidiu.panait@windriver.com>
> 
> The value of reqsize must only be changed through the helper.
> 
> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 7/7] crypto: sun8i-ss - Use helper to set reqsize
  2023-12-18 16:46 ` [PATCH 7/7] crypto: sun8i-ss " ovidiu.panait
@ 2023-12-18 19:56   ` Jernej Škrabec
  0 siblings, 0 replies; 9+ messages in thread
From: Jernej Škrabec @ 2023-12-18 19:56 UTC (permalink / raw)
  To: linux-crypto, ovidiu.panait
  Cc: linux-kernel, herbert, davem, Ovidiu Panait, Corentin Labbe,
	Chen-Yu Tsai, Samuel Holland, linux-arm-kernel, linux-sunxi

Dne ponedeljek, 18. december 2023 ob 17:46:49 CET je ovidiu.panait@windriver.com napisal(a):
> From: Ovidiu Panait <ovidiu.panait@windriver.com>
> 
> The value of reqsize must only be changed through the helper.
> 
> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 5/7] crypto: sl3516 - Use helper to set reqsize
  2023-12-18 16:46 ` [PATCH 5/7] crypto: sl3516 " ovidiu.panait
@ 2023-12-18 23:44   ` Linus Walleij
  0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2023-12-18 23:44 UTC (permalink / raw)
  To: ovidiu.panait
  Cc: linux-crypto, linux-kernel, herbert, davem, Hans Ulli Kroll,
	Corentin Labbe, linux-arm-kernel

On Mon, Dec 18, 2023 at 5:46 PM <ovidiu.panait@windriver.com> wrote:

> From: Ovidiu Panait <ovidiu.panait@windriver.com>
>
> The value of reqsize must only be changed through the helper.
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>

Looks right to me:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/7] crypto: rk3288 - Use helper to set reqsize
  2023-12-18 16:46 [PATCH 1/7] crypto: rk3288 - Use helper to set reqsize ovidiu.panait
                   ` (3 preceding siblings ...)
  2023-12-18 16:46 ` [PATCH 7/7] crypto: sun8i-ss " ovidiu.panait
@ 2023-12-29  3:28 ` Herbert Xu
  4 siblings, 0 replies; 9+ messages in thread
From: Herbert Xu @ 2023-12-29  3:28 UTC (permalink / raw)
  To: ovidiu.panait
  Cc: linux-crypto, linux-kernel, davem, Heiko Stuebner, Corentin Labbe,
	linux-rockchip, linux-arm-kernel

On Mon, Dec 18, 2023 at 06:46:43PM +0200, ovidiu.panait@windriver.com wrote:
> From: Ovidiu Panait <ovidiu.panait@windriver.com>
> 
> The value of reqsize must only be changed through the helper.
> 
> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
> ---
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Corentin Labbe <clabbe@baylibre.com>
> Cc: linux-rockchip@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> 
>  drivers/crypto/rockchip/rk3288_crypto_skcipher.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-12-29  3:29 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-18 16:46 [PATCH 1/7] crypto: rk3288 - Use helper to set reqsize ovidiu.panait
2023-12-18 16:46 ` [PATCH 4/7] crypto: stm32/cryp " ovidiu.panait
2023-12-18 16:46 ` [PATCH 5/7] crypto: sl3516 " ovidiu.panait
2023-12-18 23:44   ` Linus Walleij
2023-12-18 16:46 ` [PATCH 6/7] crypto: sun8i-ce " ovidiu.panait
2023-12-18 19:56   ` Jernej Škrabec
2023-12-18 16:46 ` [PATCH 7/7] crypto: sun8i-ss " ovidiu.panait
2023-12-18 19:56   ` Jernej Škrabec
2023-12-29  3:28 ` [PATCH 1/7] crypto: rk3288 " Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).