From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E93ACC3DA4A for ; Mon, 19 Aug 2024 16:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xdsvNz0MRnUqtsG1nQoeDFrCqHr/x15EvwOI9zUXp5c=; b=Q9tJvQSab7MdqLFN8ZQW+lIz8Q 63+SKY8fQVDHdQFdSfA6LGpb7ZM9csBQ/UXxcrj5Ovom0eqvs38kURwmTgE6MplgPovJYqlD/zZeJ 9kPAhG17Xr9E+i8NGABbfuz52fBR5/IapTczy2GGZpKsgcHxSmI3Y3ad3LApb1NeILUV49TL70/On SOiT86A340Fqmr44lUWzTsCO/KswcORiNr5YJDuEC9vkrWuFazRWag2St5em5Ok4h8P9b6NBc7dn1 WmEDwxeXmScYvd6dHcfCez1/eekBPbMxXjT0vWlQ72bb5zQMZv7AnFy7j6ZKFESRhKRaB7XOJZH9I SWNwaaFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg5SS-00000002DcD-16mV; Mon, 19 Aug 2024 16:42:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg5Rm-00000002DYF-1exT for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 16:41:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 294FB339; Mon, 19 Aug 2024 09:41:59 -0700 (PDT) Received: from [10.1.196.40] (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E30E83F58B; Mon, 19 Aug 2024 09:41:31 -0700 (PDT) Message-ID: <4854a6b2-805a-4705-b2d2-df723cfc1311@arm.com> Date: Mon, 19 Aug 2024 17:41:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] perf/arm-cmn: Refactor DTC PMU register access To: Mark Rutland Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ilkka@os.amperecomputing.com References: From: Robin Murphy Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_094134_511694_6A7FA875 X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/08/2024 11:29 am, Mark Rutland wrote: > On Fri, Aug 09, 2024 at 08:15:45PM +0100, Robin Murphy wrote: >> Annoyingly, we're soon going to have to cope with PMU registers moving >> about. This will mostly be straightforward, except for the hard-coding >> of CMN_PMU_OFFSET for the DTC PMU registers. As a first step, refactor >> those accessors to allow for encapsulating a variable offset without >> making a big mess all over. >> >> Signed-off-by: Robin Murphy >> --- >> drivers/perf/arm-cmn.c | 64 ++++++++++++++++++++++++------------------ >> 1 file changed, 36 insertions(+), 28 deletions(-) > > Aside from a minoe comment below this looks fine to me. > >> struct arm_cmn_dtc { >> void __iomem *base; >> + void __iomem *pmu_base; >> int irq; >> - int irq_friend; >> + s8 irq_friend; > > Unrelated change? > > AFAICT there's no reason for 'irq_friend' to change from 'int' to 's8', > and nothing in the commit message explains it. Oops, I had meant to note in the commit message that this is a little structure repacking where there was a hole already, to compensate for adding the new member... I shall un-forget that for v2. > Otherwise this all looks fine to me. Thanks, Robin. > > Mark.